* [PATCH] media: atomisp: add ibuf_ctrl_rmgr.c to ISP2401 build only
@ 2021-04-24 18:18 Rodrigo Figueiredo Zaiden
0 siblings, 0 replies; 2+ messages in thread
From: Rodrigo Figueiredo Zaiden @ 2021-04-24 18:18 UTC (permalink / raw)
To: mchehab, sakari.ailus, gregkh
Cc: linux-media, linux-staging, linux-kernel, rodrigoffzz
When CONFIG_VIDEO_ATOMISP_ISP2401 is not set, sparse shows
the following warnings:
drivers/staging/media/atomisp/pci/runtime/isys/src/ibuf_ctrl_rmgr.c:34:6: warning: symbol 'ia_css_isys_ibuf_rmgr_init' was not declared. Should it be static?
drivers/staging/media/atomisp/pci/runtime/isys/src/ibuf_ctrl_rmgr.c:40:6: warning: symbol 'ia_css_isys_ibuf_rmgr_uninit' was not declared. Should it be static?
drivers/staging/media/atomisp/pci/runtime/isys/src/ibuf_ctrl_rmgr.c:46:6: warning: symbol 'ia_css_isys_ibuf_rmgr_acquire' was not declared. Should it be static?
drivers/staging/media/atomisp/pci/runtime/isys/src/ibuf_ctrl_rmgr.c:106:6: warning: symbol 'ia_css_isys_ibuf_rmgr_release' was not declared. Should it be static?
The symbols stated as not declared are actually declared
under ISP2401 definition in ia_css_isys.h.
So, the file ibuf_ctrl_rmgr.c should be compiled only when
ISP2401 is enabled.
Signed-off-by: Rodrigo Figueiredo Zaiden <rodrigoffzz@gmail.com>
---
drivers/staging/media/atomisp/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/atomisp/Makefile b/drivers/staging/media/atomisp/Makefile
index 1dfad0dd02d0..555f2efa35b7 100644
--- a/drivers/staging/media/atomisp/Makefile
+++ b/drivers/staging/media/atomisp/Makefile
@@ -126,7 +126,6 @@ atomisp-objs += \
pci/runtime/inputfifo/src/inputfifo.o \
pci/runtime/isp_param/src/isp_param.o \
pci/runtime/isys/src/csi_rx_rmgr.o \
- pci/runtime/isys/src/ibuf_ctrl_rmgr.o \
pci/runtime/isys/src/isys_dma_rmgr.o \
pci/runtime/isys/src/isys_init.o \
pci/runtime/isys/src/isys_stream2mmio_rmgr.o \
@@ -175,7 +174,8 @@ obj-cht = \
pci/css_2401_system/host/ibuf_ctrl.o \
pci/css_2401_system/host/isys_dma.o \
pci/css_2401_system/host/isys_irq.o \
- pci/css_2401_system/host/isys_stream2mmio.o
+ pci/css_2401_system/host/isys_stream2mmio.o \
+ pci/runtime/isys/src/ibuf_ctrl_rmgr.o
INCLUDES += \
-I$(atomisp)/ \
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] media: atomisp: add ibuf_ctrl_rmgr.c to ISP2401 build only
@ 2021-03-28 22:43 Rodrigo Figueiredo Zaiden
0 siblings, 0 replies; 2+ messages in thread
From: Rodrigo Figueiredo Zaiden @ 2021-03-28 22:43 UTC (permalink / raw)
Cc: rodrigoffzz, Mauro Carvalho Chehab, Sakari Ailus,
Greg Kroah-Hartman, linux-media, linux-staging, linux-kernel
When CONFIG_VIDEO_ATOMISP_ISP2401 is not set, sparse shows
the following warnings:
drivers/staging/media/atomisp/pci/runtime/isys/src/ibuf_ctrl_rmgr.c:34:6: warning: symbol 'ia_css_isys_ibuf_rmgr_init' was not declared. Should it be static?
drivers/staging/media/atomisp/pci/runtime/isys/src/ibuf_ctrl_rmgr.c:40:6: warning: symbol 'ia_css_isys_ibuf_rmgr_uninit' was not declared. Should it be static?
drivers/staging/media/atomisp/pci/runtime/isys/src/ibuf_ctrl_rmgr.c:46:6: warning: symbol 'ia_css_isys_ibuf_rmgr_acquire' was not declared. Should it be static?
drivers/staging/media/atomisp/pci/runtime/isys/src/ibuf_ctrl_rmgr.c:106:6: warning: symbol 'ia_css_isys_ibuf_rmgr_release' was not declared. Should it be static?
The symbols stated as not declared are actually declared
under ISP2401 definition in ia_css_isys.h.
So, the file ibuf_ctrl_rmgr.c should be compiled only when
ISP2401 is enabled.
Signed-off-by: Rodrigo Figueiredo Zaiden <rodrigoffzz@gmail.com>
---
drivers/staging/media/atomisp/Makefile | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/atomisp/Makefile b/drivers/staging/media/atomisp/Makefile
index 1dfad0dd02d0..555f2efa35b7 100644
--- a/drivers/staging/media/atomisp/Makefile
+++ b/drivers/staging/media/atomisp/Makefile
@@ -126,7 +126,6 @@ atomisp-objs += \
pci/runtime/inputfifo/src/inputfifo.o \
pci/runtime/isp_param/src/isp_param.o \
pci/runtime/isys/src/csi_rx_rmgr.o \
- pci/runtime/isys/src/ibuf_ctrl_rmgr.o \
pci/runtime/isys/src/isys_dma_rmgr.o \
pci/runtime/isys/src/isys_init.o \
pci/runtime/isys/src/isys_stream2mmio_rmgr.o \
@@ -175,7 +174,8 @@ obj-cht = \
pci/css_2401_system/host/ibuf_ctrl.o \
pci/css_2401_system/host/isys_dma.o \
pci/css_2401_system/host/isys_irq.o \
- pci/css_2401_system/host/isys_stream2mmio.o
+ pci/css_2401_system/host/isys_stream2mmio.o \
+ pci/runtime/isys/src/ibuf_ctrl_rmgr.o
INCLUDES += \
-I$(atomisp)/ \
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-24 18:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-24 18:18 [PATCH] media: atomisp: add ibuf_ctrl_rmgr.c to ISP2401 build only Rodrigo Figueiredo Zaiden
-- strict thread matches above, loose matches on Subject: below --
2021-03-28 22:43 Rodrigo Figueiredo Zaiden
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).