* [PATCH v2] soc: ti: smartreflex after the relocation to maintain consistency
@ 2021-04-22 11:16 Yang Li
2021-04-26 14:47 ` Nishanth Menon
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2021-04-22 11:16 UTC (permalink / raw)
To: ssantosh; +Cc: nm, linux-kernel, linux-arm-kernel, linux-pm, Yang Li
v2: According to Nishanth Menon's suggestion, the subject has been
corrected.
https://lore.kernel.org/patchwork/patch/1383883/
Fix the following coccicheck warning:
./drivers/soc/ti/smartreflex.c:820:0-23: WARNING: pm_sr_fops should be
defined with DEFINE_DEBUGFS_ATTRIBUTE
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Reviewed-by: Nishanth Menon <nm@ti.com>
---
drivers/soc/ti/smartreflex.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/ti/smartreflex.c b/drivers/soc/ti/smartreflex.c
index 5376f3d..b3c7460 100644
--- a/drivers/soc/ti/smartreflex.c
+++ b/drivers/soc/ti/smartreflex.c
@@ -817,7 +817,7 @@ static int omap_sr_autocomp_store(void *data, u64 val)
return 0;
}
-DEFINE_SIMPLE_ATTRIBUTE(pm_sr_fops, omap_sr_autocomp_show,
+DEFINE_DEBUGFS_ATTRIBUTE(pm_sr_fops, omap_sr_autocomp_show,
omap_sr_autocomp_store, "%llu\n");
static int omap_sr_probe(struct platform_device *pdev)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] soc: ti: smartreflex after the relocation to maintain consistency
2021-04-22 11:16 [PATCH v2] soc: ti: smartreflex after the relocation to maintain consistency Yang Li
@ 2021-04-26 14:47 ` Nishanth Menon
0 siblings, 0 replies; 2+ messages in thread
From: Nishanth Menon @ 2021-04-26 14:47 UTC (permalink / raw)
To: Yang Li; +Cc: ssantosh, linux-kernel, linux-arm-kernel, linux-pm
On 19:16-20210422, Yang Li wrote:
> v2: According to Nishanth Menon's suggestion, the subject has been
> corrected.
> https://lore.kernel.org/patchwork/patch/1383883/
The above does'nt belong to commit message. it should probably be posted
in diffstat section.
will also be good to rebase once 5.13-rc1 is out.
>
> Fix the following coccicheck warning:
> ./drivers/soc/ti/smartreflex.c:820:0-23: WARNING: pm_sr_fops should be
> defined with DEFINE_DEBUGFS_ATTRIBUTE
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> Reviewed-by: Nishanth Menon <nm@ti.com>
> ---
> drivers/soc/ti/smartreflex.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/ti/smartreflex.c b/drivers/soc/ti/smartreflex.c
> index 5376f3d..b3c7460 100644
> --- a/drivers/soc/ti/smartreflex.c
> +++ b/drivers/soc/ti/smartreflex.c
> @@ -817,7 +817,7 @@ static int omap_sr_autocomp_store(void *data, u64 val)
> return 0;
> }
>
> -DEFINE_SIMPLE_ATTRIBUTE(pm_sr_fops, omap_sr_autocomp_show,
> +DEFINE_DEBUGFS_ATTRIBUTE(pm_sr_fops, omap_sr_autocomp_show,
> omap_sr_autocomp_store, "%llu\n");
>
> static int omap_sr_probe(struct platform_device *pdev)
> --
> 1.8.3.1
>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-26 14:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-22 11:16 [PATCH v2] soc: ti: smartreflex after the relocation to maintain consistency Yang Li
2021-04-26 14:47 ` Nishanth Menon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).