* [PATCH][next] gpio: sim: Fix dereference of free'd pointer config
@ 2021-04-27 10:24 Colin King
2021-04-27 11:33 ` Bartosz Golaszewski
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2021-04-27 10:24 UTC (permalink / raw)
To: Linus Walleij, Bartosz Golaszewski, Andy Shevchenko, linux-gpio
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The error return of config->id dereferences the kfree'd object config.
Fix this by using a temporary variable for the id to avoid this issue.
Addresses-Coverity: ("Read from pointer aftyer free")
Fixes: a49d14276ac4 ("gpio: sim: allocate IDA numbers earlier")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpio/gpio-sim.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c
index 2e2e6399e453..7bba5783a043 100644
--- a/drivers/gpio/gpio-sim.c
+++ b/drivers/gpio/gpio-sim.c
@@ -751,8 +751,10 @@ gpio_sim_config_make_item(struct config_group *group, const char *name)
config->id = ida_alloc(&gpio_sim_ida, GFP_KERNEL);
if (config->id < 0) {
+ int id = config->id;
+
kfree(config);
- return ERR_PTR(config->id);
+ return ERR_PTR(id);
}
config_item_init_type_name(&config->item, name,
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH][next] gpio: sim: Fix dereference of free'd pointer config
2021-04-27 10:24 [PATCH][next] gpio: sim: Fix dereference of free'd pointer config Colin King
@ 2021-04-27 11:33 ` Bartosz Golaszewski
2021-04-27 11:50 ` Colin Ian King
0 siblings, 1 reply; 3+ messages in thread
From: Bartosz Golaszewski @ 2021-04-27 11:33 UTC (permalink / raw)
To: Colin King
Cc: Linus Walleij, Andy Shevchenko, linux-gpio, kernel-janitors, LKML
On Tue, Apr 27, 2021 at 12:24 PM Colin King <colin.king@canonical.com> wrote:
>
> From: Colin Ian King <colin.king@canonical.com>
>
> The error return of config->id dereferences the kfree'd object config.
> Fix this by using a temporary variable for the id to avoid this issue.
>
> Addresses-Coverity: ("Read from pointer aftyer free")
> Fixes: a49d14276ac4 ("gpio: sim: allocate IDA numbers earlier")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/gpio/gpio-sim.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c
> index 2e2e6399e453..7bba5783a043 100644
> --- a/drivers/gpio/gpio-sim.c
> +++ b/drivers/gpio/gpio-sim.c
> @@ -751,8 +751,10 @@ gpio_sim_config_make_item(struct config_group *group, const char *name)
>
> config->id = ida_alloc(&gpio_sim_ida, GFP_KERNEL);
> if (config->id < 0) {
> + int id = config->id;
> +
> kfree(config);
> - return ERR_PTR(config->id);
> + return ERR_PTR(id);
> }
>
> config_item_init_type_name(&config->item, name,
> --
> 2.30.2
>
Thanks! Can you do something like this:
diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c
index 2e2e6399e453..b21541c0b700 100644
--- a/drivers/gpio/gpio-sim.c
+++ b/drivers/gpio/gpio-sim.c
@@ -744,20 +744,22 @@ static struct config_item *
gpio_sim_config_make_item(struct config_group *group, const char *name)
{
struct gpio_sim_chip_config *config;
+ int id;
config = kzalloc(sizeof(*config), GFP_KERNEL);
if (!config)
return ERR_PTR(-ENOMEM);
- config->id = ida_alloc(&gpio_sim_ida, GFP_KERNEL);
- if (config->id < 0) {
+ id = ida_alloc(&gpio_sim_ida, GFP_KERNEL);
+ if (id < 0) {
kfree(config);
- return ERR_PTR(config->id);
+ return ERR_PTR(id);
}
config_item_init_type_name(&config->item, name,
&gpio_sim_chip_config_type);
config->num_lines = 1;
+ config->id = id;
mutex_init(&config->lock);
return &config->item;
I think this looks more elegant without the local variable inside the if.
Bart
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH][next] gpio: sim: Fix dereference of free'd pointer config
2021-04-27 11:33 ` Bartosz Golaszewski
@ 2021-04-27 11:50 ` Colin Ian King
0 siblings, 0 replies; 3+ messages in thread
From: Colin Ian King @ 2021-04-27 11:50 UTC (permalink / raw)
To: Bartosz Golaszewski
Cc: Linus Walleij, Andy Shevchenko, linux-gpio, kernel-janitors, LKML
On 27/04/2021 12:33, Bartosz Golaszewski wrote:
> On Tue, Apr 27, 2021 at 12:24 PM Colin King <colin.king@canonical.com> wrote:
>>
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> The error return of config->id dereferences the kfree'd object config.
>> Fix this by using a temporary variable for the id to avoid this issue.
>>
>> Addresses-Coverity: ("Read from pointer aftyer free")
>> Fixes: a49d14276ac4 ("gpio: sim: allocate IDA numbers earlier")
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>> drivers/gpio/gpio-sim.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c
>> index 2e2e6399e453..7bba5783a043 100644
>> --- a/drivers/gpio/gpio-sim.c
>> +++ b/drivers/gpio/gpio-sim.c
>> @@ -751,8 +751,10 @@ gpio_sim_config_make_item(struct config_group *group, const char *name)
>>
>> config->id = ida_alloc(&gpio_sim_ida, GFP_KERNEL);
>> if (config->id < 0) {
>> + int id = config->id;
>> +
>> kfree(config);
>> - return ERR_PTR(config->id);
>> + return ERR_PTR(id);
>> }
>>
>> config_item_init_type_name(&config->item, name,
>> --
>> 2.30.2
>>
>
> Thanks! Can you do something like this:
>
> diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c
> index 2e2e6399e453..b21541c0b700 100644
> --- a/drivers/gpio/gpio-sim.c
> +++ b/drivers/gpio/gpio-sim.c
> @@ -744,20 +744,22 @@ static struct config_item *
> gpio_sim_config_make_item(struct config_group *group, const char *name)
> {
> struct gpio_sim_chip_config *config;
> + int id;
>
> config = kzalloc(sizeof(*config), GFP_KERNEL);
> if (!config)
> return ERR_PTR(-ENOMEM);
>
> - config->id = ida_alloc(&gpio_sim_ida, GFP_KERNEL);
> - if (config->id < 0) {
> + id = ida_alloc(&gpio_sim_ida, GFP_KERNEL);
> + if (id < 0) {
> kfree(config);
> - return ERR_PTR(config->id);
> + return ERR_PTR(id);
> }
>
> config_item_init_type_name(&config->item, name,
> &gpio_sim_chip_config_type);
> config->num_lines = 1;
> + config->id = id;
> mutex_init(&config->lock);
>
> return &config->item;
>
>
> I think this looks more elegant without the local variable inside the if.
OK, good idea, V2 sent.
>
> Bart
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-27 11:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-27 10:24 [PATCH][next] gpio: sim: Fix dereference of free'd pointer config Colin King
2021-04-27 11:33 ` Bartosz Golaszewski
2021-04-27 11:50 ` Colin Ian King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).