* [PATCH] Add blank line after declarations
@ 2021-04-29 9:25 Sanjana Srinidhi
0 siblings, 0 replies; 7+ messages in thread
From: Sanjana Srinidhi @ 2021-04-29 9:25 UTC (permalink / raw)
To: linux, bhelgaas, kw; +Cc: linux-kernel
Blank line is added after declarations to maintain code uniformity.
Signed-off-by: Sanjana Srinidhi <sanjanasrinidhi1810@gmail.com>
---
drivers/pcmcia/yenta_socket.c | 17 ++++++++++++++++-
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/drivers/pcmcia/yenta_socket.c b/drivers/pcmcia/yenta_socket.c
index e9da9c197ff1..c47158abf1d3 100644
--- a/drivers/pcmcia/yenta_socket.c
+++ b/drivers/pcmcia/yenta_socket.c
@@ -84,6 +84,7 @@ MODULE_PARM_DESC(override_bios, "yenta ignore bios resource allocation");
static inline u32 cb_readl(struct yenta_socket *socket, unsigned reg)
{
u32 val = readl(socket->base + reg);
+
debug("%04x %08x\n", socket, reg, val);
return val;
}
@@ -98,6 +99,7 @@ static inline void cb_writel(struct yenta_socket *socket, unsigned reg, u32 val)
static inline u8 config_readb(struct yenta_socket *socket, unsigned offset)
{
u8 val;
+
pci_read_config_byte(socket->dev, offset, &val);
debug("%04x %02x\n", socket, offset, val);
return val;
@@ -106,6 +108,7 @@ static inline u8 config_readb(struct yenta_socket *socket, unsigned offset)
static inline u16 config_readw(struct yenta_socket *socket, unsigned offset)
{
u16 val;
+
pci_read_config_word(socket->dev, offset, &val);
debug("%04x %04x\n", socket, offset, val);
return val;
@@ -114,6 +117,7 @@ static inline u16 config_readw(struct yenta_socket *socket, unsigned offset)
static inline u32 config_readl(struct yenta_socket *socket, unsigned offset)
{
u32 val;
+
pci_read_config_dword(socket->dev, offset, &val);
debug("%04x %08x\n", socket, offset, val);
return val;
@@ -140,6 +144,7 @@ static inline void config_writel(struct yenta_socket *socket, unsigned offset, u
static inline u8 exca_readb(struct yenta_socket *socket, unsigned reg)
{
u8 val = readb(socket->base + 0x800 + reg);
+
debug("%04x %02x\n", socket, reg, val);
return val;
}
@@ -147,6 +152,7 @@ static inline u8 exca_readb(struct yenta_socket *socket, unsigned reg)
static inline u8 exca_readw(struct yenta_socket *socket, unsigned reg)
{
u16 val;
+
val = readb(socket->base + 0x800 + reg);
val |= readb(socket->base + 0x800 + reg + 1) << 8;
debug("%04x %04x\n", socket, reg, val);
@@ -179,6 +185,7 @@ static ssize_t show_yenta_registers(struct device *yentadev, struct device_attri
offset = snprintf(buf, PAGE_SIZE, "CB registers:");
for (i = 0; i < 0x24; i += 4) {
unsigned val;
+
if (!(i & 15))
offset += scnprintf(buf + offset, PAGE_SIZE - offset, "\n%02x:", i);
val = cb_readl(socket, i);
@@ -188,6 +195,7 @@ static ssize_t show_yenta_registers(struct device *yentadev, struct device_attri
offset += scnprintf(buf + offset, PAGE_SIZE - offset, "\n\nExCA registers:");
for (i = 0; i < 0x45; i++) {
unsigned char val;
+
if (!(i & 7)) {
if (i & 8) {
memcpy(buf + offset, " -", 2);
@@ -227,6 +235,7 @@ static int yenta_get_status(struct pcmcia_socket *sock, unsigned int *value)
val |= (state & CB_PWRCYCLE) ? SS_POWERON | SS_READY : 0;
} else if (state & CB_16BITCARD) {
u8 status = exca_readb(socket, I365_STATUS);
+
val |= ((status & I365_CS_DETECT) == I365_CS_DETECT) ? SS_DETECT : 0;
if (exca_readb(socket, I365_INTCTL) & I365_PC_IOCARD) {
val |= (status & I365_CS_STSCHG) ? 0 : SS_STSCHG;
@@ -249,6 +258,7 @@ static void yenta_set_power(struct yenta_socket *socket, socket_state_t *state)
if (!(cb_readl(socket, CB_SOCKET_STATE) & CB_CBCARD) &&
(socket->flags & YENTA_16BIT_POWER_EXCA)) {
u8 reg, old;
+
reg = old = exca_readb(socket, I365_POWER);
reg &= ~(I365_VCC_MASK | I365_VPP1_MASK | I365_VPP2_MASK);
@@ -297,7 +307,9 @@ static void yenta_set_power(struct yenta_socket *socket, socket_state_t *state)
if (reg != old)
exca_writeb(socket, I365_POWER, reg);
} else {
- u32 reg = 0; /* CB_SC_STPCLK? */
+ u32 reg = 0;
+
+ /* CB_SC_STPCLK? */
switch (state->Vcc) {
case 33:
reg = CB_SC_VCC_3V;
@@ -338,6 +350,7 @@ static int yenta_set_socket(struct pcmcia_socket *sock, socket_state_t *state)
bridge = config_readw(socket, CB_BRIDGE_CONTROL) & ~(CB_BRIDGE_CRST | CB_BRIDGE_INTR);
if (cb_readl(socket, CB_SOCKET_STATE) & CB_CBCARD) {
u8 intr;
+
bridge |= (state->flags & SS_RESET) ? CB_BRIDGE_CRST : 0;
/* ISA interrupt control? */
@@ -638,6 +651,7 @@ static int yenta_search_one_res(struct resource *root, struct resource *res,
} else {
unsigned long avail = root->end - root->start;
int i;
+
size = BRIDGE_MEM_MAX;
if (size > avail/8) {
size = (avail+1)/8;
@@ -763,6 +777,7 @@ static void yenta_free_res(struct yenta_socket *socket, int nr)
static void yenta_allocate_resources(struct yenta_socket *socket)
{
int program = 0;
+
program += yenta_allocate_res(socket, PCI_CB_BRIDGE_IO_0_WINDOW,
IORESOURCE_IO,
PCI_CB_IO_BASE_0, PCI_CB_IO_LIMIT_0);
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] Add blank line after declarations
@ 2021-04-29 8:54 Sanjana Srinidhi
0 siblings, 0 replies; 7+ messages in thread
From: Sanjana Srinidhi @ 2021-04-29 8:54 UTC (permalink / raw)
To: linux; +Cc: linux-kernel
Blank line is added after declarations to maintain code uniformity.
Signed-off-by: Sanjana Srinidhi <sanjanasrinidhi1810@gmail.com>
---
drivers/pcmcia/soc_common.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/pcmcia/soc_common.c b/drivers/pcmcia/soc_common.c
index 3a8c84bb174d..98b6d96a4435 100644
--- a/drivers/pcmcia/soc_common.c
+++ b/drivers/pcmcia/soc_common.c
@@ -63,6 +63,7 @@ void soc_pcmcia_debug(struct soc_pcmcia_socket *skt, const char *func,
{
struct va_format vaf;
va_list args;
+
if (pc_debug > lvl) {
va_start(args, fmt);
@@ -464,6 +465,7 @@ static void soc_common_check_status(struct soc_pcmcia_socket *skt)
static void soc_common_pcmcia_poll_event(struct timer_list *t)
{
struct soc_pcmcia_socket *skt = from_timer(skt, t, poll_timer);
+
debug(skt, 4, "polling for events\n");
mod_timer(&skt->poll_timer, jiffies + SOC_PCMCIA_POLL_PERIOD);
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] Add blank line after declarations
@ 2021-04-28 19:52 Sanjana Srinidhi
0 siblings, 0 replies; 7+ messages in thread
From: Sanjana Srinidhi @ 2021-04-28 19:52 UTC (permalink / raw)
To: geoff, mpe, benh, paulus; +Cc: linuxppc-dev, linux-kernel
Blank line is added after declarations to maintain code uniformity.
Signed-off-by: Sanjana Srinidhi <sanjanasrinidhi1810@gmail.com>
---
drivers/ps3/ps3av.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ps3/ps3av.c b/drivers/ps3/ps3av.c
index 9d66257e1da5..c4ea494ce464 100644
--- a/drivers/ps3/ps3av.c
+++ b/drivers/ps3/ps3av.c
@@ -175,6 +175,7 @@ static int ps3av_vuart_write(struct ps3_system_bus_device *dev,
const void *buf, unsigned long size)
{
int error;
+
dev_dbg(&dev->core, " -> %s:%d\n", __func__, __LINE__);
error = ps3_vuart_write(dev, buf, size);
dev_dbg(&dev->core, " <- %s:%d\n", __func__, __LINE__);
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] Add blank line after declarations
@ 2021-04-28 9:26 Sanjana Srinidhi
0 siblings, 0 replies; 7+ messages in thread
From: Sanjana Srinidhi @ 2021-04-28 9:26 UTC (permalink / raw)
To: dan.j.williams, vishal.l.verma, dave.jiang; +Cc: linux-nvdimm, linux-kernel
Blank line is added after declarations to maintain code uniformity.
Signed-off-by: Sanjana Srinidhi <sanjanasrinidhi1810@gmail.com>
---
drivers/dax/super.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/dax/super.c b/drivers/dax/super.c
index 5fa6ae9dbc8b..1f7cd75e379f 100644
--- a/drivers/dax/super.c
+++ b/drivers/dax/super.c
@@ -477,6 +477,7 @@ static struct dax_device *to_dax_dev(struct inode *inode)
static void dax_free_inode(struct inode *inode)
{
struct dax_device *dax_dev = to_dax_dev(inode);
+
kfree(dax_dev->host);
dax_dev->host = NULL;
if (inode->i_rdev)
@@ -487,6 +488,7 @@ static void dax_free_inode(struct inode *inode)
static void dax_destroy_inode(struct inode *inode)
{
struct dax_device *dax_dev = to_dax_dev(inode);
+
WARN_ONCE(test_bit(DAXDEV_ALIVE, &dax_dev->flags),
"kill_dax() must be called before final iput()\n");
}
@@ -502,6 +504,7 @@ static const struct super_operations dax_sops = {
static int dax_init_fs_context(struct fs_context *fc)
{
struct pseudo_fs_context *ctx = init_pseudo(fc, DAXFS_MAGIC);
+
if (!ctx)
return -ENOMEM;
ctx->ops = &dax_sops;
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
[parent not found: <20210428081412.dyxwuh3soluhd4h6@sanjana-VirtualBox>]
* Re: [PATCH] Add blank line after declarations
[not found] <20210428081412.dyxwuh3soluhd4h6@sanjana-VirtualBox>
@ 2021-04-28 8:26 ` Borislav Petkov
0 siblings, 0 replies; 7+ messages in thread
From: Borislav Petkov @ 2021-04-28 8:26 UTC (permalink / raw)
To: Sanjana Srinidhi; +Cc: mchehab, tony.luck, james.morse, rric, linux-edac, lkml
On Wed, Apr 28, 2021 at 01:44:12PM +0530, Sanjana Srinidhi wrote:
> Blank line is added after declarations to maintain code uniformity.
>
> Signed-off-by: Sanjana Srinidhi <sanjanasrinidhi1810@gmail.com>
> ---
> drivers/edac/edac_mc.c | 3 +++
> 1 file changed, 3 insertions(+)
Before you send a patch, do:
git log -p -1 | ./scripts/get_maintainer.pl
that'll give you who to Cc. Then you'll see that there's no
edac@vger.kernel.org
mailing list but
linux-edac@vger.kernel.org
I've fixed up that now.
There's no
kernel@vger.kernel.org
either.
> diff --git a/drivers/edac/edac_mc.c b/drivers/edac/edac_mc.c
> index f6d462d0be2d..6b776bebd83f 100644
> --- a/drivers/edac/edac_mc.c
> +++ b/drivers/edac/edac_mc.c
> @@ -674,6 +674,7 @@ int edac_mc_add_mc_with_groups(struct mem_ctl_info *mci,
> const struct attribute_group **groups)
> {
> int ret = -EINVAL;
> +
> edac_dbg(0, "\n");
>
> #ifdef CONFIG_EDAC_DEBUG
> @@ -833,9 +834,11 @@ int edac_mc_find_csrow_by_page(struct mem_ctl_info *mci, unsigned long page)
>
> for (i = 0; i < mci->nr_csrows; i++) {
> struct csrow_info *csrow = csrows[i];
> +
> n = 0;
> for (j = 0; j < csrow->nr_channels; j++) {
> struct dimm_info *dimm = csrow->channels[j]->dimm;
> +
> n += dimm->nr_pages;
> }
> if (n == 0)
> --
Please no, this is adding useless churn.
Such stylistic changes - if they would make sense at all - should be
done as part of other fixes - not as a standalone patch.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] add blank line after declarations
@ 2017-04-07 12:41 Manny Vindiola
2017-04-08 11:03 ` Greg Kroah-Hartman
0 siblings, 1 reply; 7+ messages in thread
From: Manny Vindiola @ 2017-04-07 12:41 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Greg Kroah-Hartman, Alan Cox, linux-media,
devel, linux-kernel
Cc: Manny Vindiola
Add blank line after variable declarations as part of checkpatch.pl style fixup.
Signed-off-by: Manny Vindiola <mannyv@gmail.com>
---
drivers/staging/media/atomisp/pci/atomisp2/atomisp_tpg.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_tpg.c b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_tpg.c
index 996d1bd..48b9604 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/atomisp_tpg.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/atomisp_tpg.c
@@ -56,6 +56,7 @@ static int tpg_set_fmt(struct v4l2_subdev *sd,
struct v4l2_subdev_format *format)
{
struct v4l2_mbus_framefmt *fmt = &format->format;
+
if (format->pad)
return -EINVAL;
/* only raw8 grbg is supported by TPG */
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] add blank line after declarations
2017-04-07 12:41 [PATCH] add " Manny Vindiola
@ 2017-04-08 11:03 ` Greg Kroah-Hartman
0 siblings, 0 replies; 7+ messages in thread
From: Greg Kroah-Hartman @ 2017-04-08 11:03 UTC (permalink / raw)
To: Manny Vindiola
Cc: Mauro Carvalho Chehab, Alan Cox, linux-media, devel, linux-kernel
On Fri, Apr 07, 2017 at 08:41:11AM -0400, Manny Vindiola wrote:
> Add blank line after variable declarations as part of checkpatch.pl style fixup.
>
> Signed-off-by: Manny Vindiola <mannyv@gmail.com>
> ---
> drivers/staging/media/atomisp/pci/atomisp2/atomisp_tpg.c | 1 +
> 1 file changed, 1 insertion(+)
Your subject line needs a lot of work, please read the reference
material I sent you for your last patch...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-04-29 9:25 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-29 9:25 [PATCH] Add blank line after declarations Sanjana Srinidhi
-- strict thread matches above, loose matches on Subject: below --
2021-04-29 8:54 Sanjana Srinidhi
2021-04-28 19:52 Sanjana Srinidhi
2021-04-28 9:26 Sanjana Srinidhi
[not found] <20210428081412.dyxwuh3soluhd4h6@sanjana-VirtualBox>
2021-04-28 8:26 ` Borislav Petkov
2017-04-07 12:41 [PATCH] add " Manny Vindiola
2017-04-08 11:03 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).