* [PATCH] i2c: icy: Remove unused variable new_fwnode in icy_probe()
@ 2021-05-03 7:02 Geert Uytterhoeven
2021-05-03 13:05 ` Max Staudt
2021-05-25 19:22 ` Wolfram Sang
0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2021-05-03 7:02 UTC (permalink / raw)
To: Heikki Krogerus, Max Staudt, Wolfram Sang
Cc: linux-i2c, linux-kernel, Geert Uytterhoeven
The last user of new_fwnode was removed, leading to:
drivers/i2c/busses/i2c-icy.c: In function ‘icy_probe’:
drivers/i2c/busses/i2c-icy.c:126:24: warning: unused variable ‘new_fwnode’ [-Wunused-variable]
126 | struct fwnode_handle *new_fwnode;
| ^~~~~~~~~~
Fixes: dd7a37102b79ae55 ("i2c: icy: Constify the software node")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/i2c/busses/i2c-icy.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-icy.c b/drivers/i2c/busses/i2c-icy.c
index c8c422e9dda43393..5dae7cab72605592 100644
--- a/drivers/i2c/busses/i2c-icy.c
+++ b/drivers/i2c/busses/i2c-icy.c
@@ -123,7 +123,6 @@ static int icy_probe(struct zorro_dev *z,
{
struct icy_i2c *i2c;
struct i2c_algo_pcf_data *algo_data;
- struct fwnode_handle *new_fwnode;
struct i2c_board_info ltc2990_info = {
.type = "ltc2990",
.swnode = &icy_ltc2990_node,
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: icy: Remove unused variable new_fwnode in icy_probe()
2021-05-03 7:02 [PATCH] i2c: icy: Remove unused variable new_fwnode in icy_probe() Geert Uytterhoeven
@ 2021-05-03 13:05 ` Max Staudt
2021-05-25 19:22 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Max Staudt @ 2021-05-03 13:05 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Heikki Krogerus, Wolfram Sang, linux-i2c, linux-kernel
Thanks for catching this warning :)
Reviewed-by: Max Staudt <max@enpas.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] i2c: icy: Remove unused variable new_fwnode in icy_probe()
2021-05-03 7:02 [PATCH] i2c: icy: Remove unused variable new_fwnode in icy_probe() Geert Uytterhoeven
2021-05-03 13:05 ` Max Staudt
@ 2021-05-25 19:22 ` Wolfram Sang
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2021-05-25 19:22 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Heikki Krogerus, Max Staudt, linux-i2c, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 562 bytes --]
On Mon, May 03, 2021 at 09:02:20AM +0200, Geert Uytterhoeven wrote:
> The last user of new_fwnode was removed, leading to:
>
> drivers/i2c/busses/i2c-icy.c: In function ‘icy_probe’:
> drivers/i2c/busses/i2c-icy.c:126:24: warning: unused variable ‘new_fwnode’ [-Wunused-variable]
> 126 | struct fwnode_handle *new_fwnode;
> | ^~~~~~~~~~
>
> Fixes: dd7a37102b79ae55 ("i2c: icy: Constify the software node")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-25 19:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-03 7:02 [PATCH] i2c: icy: Remove unused variable new_fwnode in icy_probe() Geert Uytterhoeven
2021-05-03 13:05 ` Max Staudt
2021-05-25 19:22 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).