* [PATCH] x86: make x86nops symbol static
@ 2021-05-06 19:07 Pavel Skripkin
2021-05-12 11:16 ` [tip: x86/cleanups] x86/alternatives: Make the x86nops[] " tip-bot2 for Pavel Skripkin
0 siblings, 1 reply; 2+ messages in thread
From: Pavel Skripkin @ 2021-05-06 19:07 UTC (permalink / raw)
To: tglx, mingo, bp; +Cc: linux-kernel, Pavel Skripkin
Sparse says:
arch/x86/kernel/alternative.c:78:21: warning: symbol 'x86nops' was not declared. Should it be static?
Since x86nops is not used outside this file,
it can be made static.
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
---
arch/x86/kernel/alternative.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c
index 6974b5174495..75c752b0628c 100644
--- a/arch/x86/kernel/alternative.c
+++ b/arch/x86/kernel/alternative.c
@@ -75,7 +75,7 @@ do { \
} \
} while (0)
-const unsigned char x86nops[] =
+static const unsigned char x86nops[] =
{
BYTES_NOP1,
BYTES_NOP2,
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* [tip: x86/cleanups] x86/alternatives: Make the x86nops[] symbol static
2021-05-06 19:07 [PATCH] x86: make x86nops symbol static Pavel Skripkin
@ 2021-05-12 11:16 ` tip-bot2 for Pavel Skripkin
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot2 for Pavel Skripkin @ 2021-05-12 11:16 UTC (permalink / raw)
To: linux-tip-commits; +Cc: Pavel Skripkin, Ingo Molnar, x86, linux-kernel
The following commit has been merged into the x86/cleanups branch of tip:
Commit-ID: 64e1f5872a8c3d80bce4686b4ab5dbc6e6bd30c5
Gitweb: https://git.kernel.org/tip/64e1f5872a8c3d80bce4686b4ab5dbc6e6bd30c5
Author: Pavel Skripkin <paskripkin@gmail.com>
AuthorDate: Thu, 06 May 2021 22:07:26 +03:00
Committer: Ingo Molnar <mingo@kernel.org>
CommitterDate: Wed, 12 May 2021 12:22:56 +02:00
x86/alternatives: Make the x86nops[] symbol static
Sparse says:
arch/x86/kernel/alternative.c:78:21: warning: symbol 'x86nops' was not declared. Should it be static?
Since x86nops[] is not used outside this file, Sparse is right and it can be made static.
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20210506190726.15575-1-paskripkin@gmail.com
---
arch/x86/kernel/alternative.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c
index 6974b51..75c752b 100644
--- a/arch/x86/kernel/alternative.c
+++ b/arch/x86/kernel/alternative.c
@@ -75,7 +75,7 @@ do { \
} \
} while (0)
-const unsigned char x86nops[] =
+static const unsigned char x86nops[] =
{
BYTES_NOP1,
BYTES_NOP2,
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-12 11:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-06 19:07 [PATCH] x86: make x86nops symbol static Pavel Skripkin
2021-05-12 11:16 ` [tip: x86/cleanups] x86/alternatives: Make the x86nops[] " tip-bot2 for Pavel Skripkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).