From: Bjorn Helgaas <helgaas@kernel.org>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: lorenzo.pieralisi@arm.com, linux-pci@vger.kernel.org,
linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@pengutronix.de,
Richard Zhu <hongxing.zhu@nxp.com>,
andrew.smirnov@gmail.com, shawnguo@kernel.org, kw@linux.com,
bhelgaas@google.com, stefan@agner.ch
Subject: Re: [RESEND v4 1/2] dt-bindings: imx6q-pcie: add one regulator used to power up pcie phy
Date: Thu, 6 May 2021 16:01:17 -0500 [thread overview]
Message-ID: <20210506210117.GA1433800@bjorn-Precision-5520> (raw)
In-Reply-To: <7900502879b346e18727f956965ace34a146c0f1.camel@pengutronix.de>
On Thu, May 06, 2021 at 06:08:24PM +0200, Lucas Stach wrote:
> Hi Lorenzo,
>
> have those two patches fallen through some crack? AFAICS they are gone
> from patchwork, but I also can't find them in any branch in the usual
> git repos.
They were marked "accepted" in patchwork but must have fallen through
the cracks. I reset them to "new" and assigned to Lorenzo.
Neither one follows the subject line capitalization conventions.
The subject line of this patch (1/2) doesn't really make sense. I
*think* this adds a property ("vph-supply") to indicate which
regulator supplys power to the PHY.
> Am Dienstag, dem 30.03.2021 um 16:08 +0800 schrieb Richard Zhu:
> > Both 1.8v and 3.3v power supplies can be used by i.MX8MQ PCIe PHY.
> > In default, the PCIE_VPH voltage is suggested to be 1.8v refer to data
> > sheet. When PCIE_VPH is supplied by 3.3v in the HW schematic design,
> > the VREG_BYPASS bits of GPR registers should be cleared from default
> > value 1b'1 to 1b'0. Thus, the internal 3v3 to 1v8 translator would be
> > turned on.
This commit log doesn't describe the patch, either. Maybe something
like this:
dt-bindings: imx6q-pcie: Add "vph-supply" for PHY supply voltage
The i.MX8MQ PCIe PHY can use either a 1.8V or a 3.3V power supply.
Add a "vph-supply" property to indicate which regulator supplies
power for the PHY.
> > Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> > Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
> > ---
> > Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> > index de4b2baf91e8..d8971ab99274 100644
> > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.txt
> > @@ -38,6 +38,9 @@ Optional properties:
> > The regulator will be enabled when initializing the PCIe host and
> > disabled either as part of the init process or when shutting down the
> > host.
> > +- vph-supply: Should specify the regulator in charge of VPH one of the three
> > + PCIe PHY powers. This regulator can be supplied by both 1.8v and 3.3v voltage
> > + supplies.
Just going by examples for other drivers, I think this should say
something like this:
- vph-supply: Regulator for i.MX8MQ PCIe PHY. May supply either
1.8V or 3.3V.
You mentioned "one of the three PCIe PHY powers"; I don't know what
that means, so I don't know whether it's important to include.
I also don't know what "vph" means; if the "ph" is part of "phy", it'd
be nicer to include the "y", so it would be "vphy-supply".
> > Additional required properties for imx6sx-pcie:
> > - clock names: Must include the following additional entries:
next prev parent reply other threads:[~2021-05-06 21:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 8:08 [RESEND v4 0/2] add one regulator used to power up pcie phy Richard Zhu
2021-03-30 8:08 ` [RESEND v4 1/2] dt-bindings: imx6q-pcie: " Richard Zhu
2021-05-06 16:08 ` Lucas Stach
2021-05-06 21:01 ` Bjorn Helgaas [this message]
2021-05-14 8:35 ` [EXT] " Richard Zhu
2021-03-30 8:08 ` [RESEND v4 2/2] PCI: imx: clear vreg bypass when pcie vph voltage is 3v3 Richard Zhu
2021-05-06 21:09 ` Bjorn Helgaas
2021-05-14 8:36 ` [EXT] " Richard Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210506210117.GA1433800@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=andrew.smirnov@gmail.com \
--cc=bhelgaas@google.com \
--cc=hongxing.zhu@nxp.com \
--cc=kernel@pengutronix.de \
--cc=kw@linux.com \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).