* [PATCH] tracing: Remove redundant assignment to event_var
@ 2021-05-07 10:23 Jiapeng Chong
2021-05-07 13:16 ` Steven Rostedt
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-05-07 10:23 UTC (permalink / raw)
To: rostedt; +Cc: mingo, linux-kernel, Jiapeng Chong
Variable event_var is set to 'ERR_PTR(-EINVAL)', but this value
is never read as it is overwritten or not used later on, hence
it is a redundant assignment and can be removed.
Clean up the following clang-analyzer warning:
kernel/trace/trace_events_hist.c:2437:21: warning: Value stored to
'event_var' during its initialization is never read
[clang-analyzer-deadcode.DeadStores].
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
kernel/trace/trace_events_hist.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c
index c1abd63..b37342c 100644
--- a/kernel/trace/trace_events_hist.c
+++ b/kernel/trace/trace_events_hist.c
@@ -2434,7 +2434,7 @@ static struct trace_event_file *event_file(struct trace_array *tr,
char *subsys_name, char *event_name, char *field_name)
{
struct trace_array *tr = target_hist_data->event_file->tr;
- struct hist_field *event_var = ERR_PTR(-EINVAL);
+ struct hist_field *event_var;
struct hist_trigger_data *hist_data;
unsigned int i, n, first = true;
struct field_var_hist *var_hist;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tracing: Remove redundant assignment to event_var
2021-05-07 10:23 [PATCH] tracing: Remove redundant assignment to event_var Jiapeng Chong
@ 2021-05-07 13:16 ` Steven Rostedt
0 siblings, 0 replies; 2+ messages in thread
From: Steven Rostedt @ 2021-05-07 13:16 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: mingo, linux-kernel
On Fri, 7 May 2021 18:23:50 +0800
Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote:
> Variable event_var is set to 'ERR_PTR(-EINVAL)', but this value
> is never read as it is overwritten or not used later on, hence
> it is a redundant assignment and can be removed.
>
> Clean up the following clang-analyzer warning:
>
> kernel/trace/trace_events_hist.c:2437:21: warning: Value stored to
> 'event_var' during its initialization is never read
> [clang-analyzer-deadcode.DeadStores].
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> kernel/trace/trace_events_hist.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c
> index c1abd63..b37342c 100644
> --- a/kernel/trace/trace_events_hist.c
> +++ b/kernel/trace/trace_events_hist.c
> @@ -2434,7 +2434,7 @@ static struct trace_event_file *event_file(struct trace_array *tr,
> char *subsys_name, char *event_name, char *field_name)
> {
> struct trace_array *tr = target_hist_data->event_file->tr;
> - struct hist_field *event_var = ERR_PTR(-EINVAL);
> + struct hist_field *event_var;
> struct hist_trigger_data *hist_data;
> unsigned int i, n, first = true;
> struct field_var_hist *var_hist;
Thanks, but if you are going to make this change, please move the
declaration of event_var below (or above) key_field, as their names are
both the same size in length and are of the same type. This keeps the
"upside-down x-mas tree" look of the declarations.
-- Steve
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-07 13:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-07 10:23 [PATCH] tracing: Remove redundant assignment to event_var Jiapeng Chong
2021-05-07 13:16 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).