* [PATCH 1/1] usb: dwc3: imx8mp: fix error return code in dwc3_imx8mp_probe()
@ 2021-05-08 1:53 Zhen Lei
2021-05-10 12:13 ` Felipe Balbi
0 siblings, 1 reply; 2+ messages in thread
From: Zhen Lei @ 2021-05-08 1:53 UTC (permalink / raw)
To: Felipe Balbi, Greg Kroah-Hartman, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team, Li Jun,
linux-usb, linux-arm-kernel, linux-kernel
Cc: Zhen Lei
Fix to return a negative error code from the error handling case instead
of 0, as done elsewhere in this function.
Fixes: 6dd2565989b4 ("usb: dwc3: add imx8mp dwc3 glue layer driver")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
drivers/usb/dwc3/dwc3-imx8mp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/dwc3/dwc3-imx8mp.c b/drivers/usb/dwc3/dwc3-imx8mp.c
index b13cfab89d53..97810ca17a2c 100644
--- a/drivers/usb/dwc3/dwc3-imx8mp.c
+++ b/drivers/usb/dwc3/dwc3-imx8mp.c
@@ -167,6 +167,7 @@ static int dwc3_imx8mp_probe(struct platform_device *pdev)
dwc3_np = of_get_child_by_name(node, "dwc3");
if (!dwc3_np) {
+ err = -ENODEV;
dev_err(dev, "failed to find dwc3 core child\n");
goto disable_rpm;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] usb: dwc3: imx8mp: fix error return code in dwc3_imx8mp_probe()
2021-05-08 1:53 [PATCH 1/1] usb: dwc3: imx8mp: fix error return code in dwc3_imx8mp_probe() Zhen Lei
@ 2021-05-10 12:13 ` Felipe Balbi
0 siblings, 0 replies; 2+ messages in thread
From: Felipe Balbi @ 2021-05-10 12:13 UTC (permalink / raw)
To: Zhen Lei, Greg Kroah-Hartman, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, NXP Linux Team, Li Jun,
linux-usb, linux-arm-kernel, linux-kernel
Cc: Zhen Lei
[-- Attachment #1: Type: text/plain, Size: 407 bytes --]
Zhen Lei <thunder.leizhen@huawei.com> writes:
> Fix to return a negative error code from the error handling case instead
> of 0, as done elsewhere in this function.
>
> Fixes: 6dd2565989b4 ("usb: dwc3: add imx8mp dwc3 glue layer driver")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Acked-by: Felipe Balbi <balbi@kernel.org>
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 511 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-10 12:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-08 1:53 [PATCH 1/1] usb: dwc3: imx8mp: fix error return code in dwc3_imx8mp_probe() Zhen Lei
2021-05-10 12:13 ` Felipe Balbi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).