* [PATCH 1/1] drm/mga: Fix error return code in mga_do_pci_dma_bootstrap()
@ 2021-05-08 3:55 Zhen Lei
0 siblings, 0 replies; only message in thread
From: Zhen Lei @ 2021-05-08 3:55 UTC (permalink / raw)
To: David Airlie, Daniel Vetter, dri-devel, linux-kernel; +Cc: Zhen Lei
The user may incorrectly set the value of dma_bs->secondary_bin_count to 0.
In this case, the for loop is not entered and the 'err' value remains 0.
Fixes: 6795c985a648 ("Add support for PCI MGA cards to MGA DRM.")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
---
drivers/gpu/drm/mga/mga_dma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mga/mga_dma.c b/drivers/gpu/drm/mga/mga_dma.c
index 1cb7d120d18f..e41d44ec26de 100644
--- a/drivers/gpu/drm/mga/mga_dma.c
+++ b/drivers/gpu/drm/mga/mga_dma.c
@@ -693,7 +693,7 @@ static int mga_do_pci_dma_bootstrap(struct drm_device *dev,
}
if (bin_count == 0) {
- DRM_ERROR("Unable to add secondary DMA buffers: %d\n", err);
+ DRM_ERROR("Unable to add secondary DMA buffers: %d\n", err ? : -EINVAL);
return err;
}
--
2.25.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-05-08 3:56 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-08 3:55 [PATCH 1/1] drm/mga: Fix error return code in mga_do_pci_dma_bootstrap() Zhen Lei
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).