[PATCH] arm64: dts: qcom: sm8350: use interconnect enums

[PATCH] arm64: dts: qcom: sm8350: use interconnect enums

[Vinod Koul]

Add interconnect enums instead of numbers now that interconnect is in
mainline.

Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
 arch/arm64/boot/dts/qcom/sm8350.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi
index ed0b51bc03ea..a8cd224a2f31 100644
--- a/arch/arm64/boot/dts/qcom/sm8350.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi
@@ -656,7 +656,7 @@ mpss: remoteproc@4080000 {
 					<&rpmhpd 12>;
 			power-domain-names = "load_state", "cx", "mss";
 
-			interconnects = <&mc_virt 0 &mc_virt 1>;
+			interconnects = <&mc_virt MASTER_LLCC &mc_virt SLAVE_EBI1>;
 
 			memory-region = <&pil_modem_mem>;
 
@@ -1063,7 +1063,7 @@ cdsp: remoteproc@98900000 {
 					<&rpmhpd 10>;
 			power-domain-names = "load_state", "cx", "mxc";
 
-			interconnects = <&compute_noc 1 &mc_virt 1>;
+			interconnects = <&compute_noc MASTER_CDSP_PROC &mc_virt SLAVE_EBI1>;
 
 			memory-region = <&pil_cdsp_mem>;
 
-- 
2.26.3

Re: [PATCH] arm64: dts: qcom: sm8350: use interconnect enums

[Bhupesh Sharma]

On Mon, 10 May 2021 at 12:34, Vinod Koul <vkoul@kernel.org> wrote:
>
> Add interconnect enums instead of numbers now that interconnect is in
> mainline.
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
>  arch/arm64/boot/dts/qcom/sm8350.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi
> index ed0b51bc03ea..a8cd224a2f31 100644
> --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi
> @@ -656,7 +656,7 @@ mpss: remoteproc@4080000 {
>                                         <&rpmhpd 12>;
>                         power-domain-names = "load_state", "cx", "mss";
>
> -                       interconnects = <&mc_virt 0 &mc_virt 1>;
> +                       interconnects = <&mc_virt MASTER_LLCC &mc_virt SLAVE_EBI1>;
>
>                         memory-region = <&pil_modem_mem>;
>
> @@ -1063,7 +1063,7 @@ cdsp: remoteproc@98900000 {
>                                         <&rpmhpd 10>;
>                         power-domain-names = "load_state", "cx", "mxc";
>
> -                       interconnects = <&compute_noc 1 &mc_virt 1>;
> +                       interconnects = <&compute_noc MASTER_CDSP_PROC &mc_virt SLAVE_EBI1>;
>
>                         memory-region = <&pil_cdsp_mem>;
>
> --
> 2.26.3

LGTM, so:
Reviewed-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>

Thanks.

Re: [PATCH] arm64: dts: qcom: sm8350: use interconnect enums

[kernel test robot]

[-- Attachment #1: Type: text/plain, Size: 1642 bytes --]

Hi Vinod,

I love your patch! Yet something to improve:

[auto build test ERROR on v5.13-rc1]
[also build test ERROR on next-20210510]
[cannot apply to robh/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Vinod-Koul/arm64-dts-qcom-sm8350-use-interconnect-enums/20210510-150501
base:    6efb943b8616ec53a5e444193dccf1af9ad627b5
config: arm64-allyesconfig (attached as .config)
compiler: aarch64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/1c674f9e806e6046d8afce421fd857417bddb043
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Vinod-Koul/arm64-dts-qcom-sm8350-use-interconnect-enums/20210510-150501
        git checkout 1c674f9e806e6046d8afce421fd857417bddb043
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross W=1 ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

>> Error: arch/arm64/boot/dts/qcom/sm8350.dtsi:659.30-31 syntax error
   FATAL ERROR: Unable to parse input tree

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 77666 bytes --]