From: Mark Brown <broonie@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Liguang Zhang <zhangliguang@linux.alibaba.com>,
Jay Fang <f.fangjian@huawei.com>,
Sven Van Asbroeck <thesven73@gmail.com>,
Xin Hao <xhao@linux.alibaba.com>
Subject: Re: [PATCH v1 1/1] spi: Assume GPIO CS active high in ACPI case
Date: Tue, 11 May 2021 12:13:30 +0100 [thread overview]
Message-ID: <20210511111330.GH4496@sirena.org.uk> (raw)
In-Reply-To: <20210510141022.56499-1-andriy.shevchenko@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 682 bytes --]
On Mon, May 10, 2021 at 05:10:22PM +0300, Andy Shevchenko wrote:
> + bool value = has_acpi_companion(&spi->dev) ? !enable : activate;
Please write normal conditional statements to improve legibility.
> if (spi->cs_gpiod)
> - /* polarity handled by gpiolib */
> - gpiod_set_value_cansleep(spi->cs_gpiod, activate);
> + /* Polarity handled by GPIO library */
> + gpiod_set_value_cansleep(spi->cs_gpiod, value);
> else
> /*
> - * invert the enable line, as active low is
> + * Invert the enable line, as active low is
> * default for SPI.
The change would be clearer with the documentation formatting changes
split out from the rest of it.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-05-11 11:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 14:10 [PATCH v1 1/1] spi: Assume GPIO CS active high in ACPI case Andy Shevchenko
2021-05-10 23:36 ` Sven Van Asbroeck
2021-05-11 11:13 ` Mark Brown [this message]
2021-05-11 12:55 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210511111330.GH4496@sirena.org.uk \
--to=broonie@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=f.fangjian@huawei.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=thesven73@gmail.com \
--cc=xhao@linux.alibaba.com \
--cc=zhangliguang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).