From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Liguang Zhang <zhangliguang@linux.alibaba.com>,
Jay Fang <f.fangjian@huawei.com>,
Sven Van Asbroeck <thesven73@gmail.com>,
Xin Hao <xhao@linux.alibaba.com>
Subject: Re: [PATCH v1 1/1] spi: Assume GPIO CS active high in ACPI case
Date: Tue, 11 May 2021 15:55:01 +0300 [thread overview]
Message-ID: <YJp+pV1mmIxY3LLX@smile.fi.intel.com> (raw)
In-Reply-To: <20210511111330.GH4496@sirena.org.uk>
On Tue, May 11, 2021 at 12:13:30PM +0100, Mark Brown wrote:
> On Mon, May 10, 2021 at 05:10:22PM +0300, Andy Shevchenko wrote:
>
> > + bool value = has_acpi_companion(&spi->dev) ? !enable : activate;
>
> Please write normal conditional statements to improve legibility.
OK!
> > if (spi->cs_gpiod)
> > - /* polarity handled by gpiolib */
> > - gpiod_set_value_cansleep(spi->cs_gpiod, activate);
> > + /* Polarity handled by GPIO library */
> > + gpiod_set_value_cansleep(spi->cs_gpiod, value);
> > else
> > /*
> > - * invert the enable line, as active low is
> > + * Invert the enable line, as active low is
> > * default for SPI.
>
> The change would be clearer with the documentation formatting changes
> split out from the rest of it.
Will remove these changes from a fix in v2.
P.S> something is odd about the series I have submitted, i.e. half of the
patches simply didn't make it. I would wait with any new submission until it
will be clarified, otherwise it's a chance to miss more patches without any
reason why.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-05-11 12:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 14:10 [PATCH v1 1/1] spi: Assume GPIO CS active high in ACPI case Andy Shevchenko
2021-05-10 23:36 ` Sven Van Asbroeck
2021-05-11 11:13 ` Mark Brown
2021-05-11 12:55 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJp+pV1mmIxY3LLX@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=f.fangjian@huawei.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=thesven73@gmail.com \
--cc=xhao@linux.alibaba.com \
--cc=zhangliguang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).