* [PATCH -next] media: omap3isp: add missing unlock on error in isp_subdev_notifier_complete()
@ 2021-05-12 9:23 Yang Yingliang
2021-06-23 23:06 ` Sakari Ailus
0 siblings, 1 reply; 2+ messages in thread
From: Yang Yingliang @ 2021-05-12 9:23 UTC (permalink / raw)
To: linux-kernel, linux-media; +Cc: laurent.pinchart, mchehab
Add the missing unlock before return from isp_subdev_notifier_complete()
in the error handling case.
Fixes: ba689d933361 ("media: omap3isp: Acquire graph mutex for graph traversal")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/media/platform/omap3isp/isp.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c
index 53025c8c7531..20f59c59ff8a 100644
--- a/drivers/media/platform/omap3isp/isp.c
+++ b/drivers/media/platform/omap3isp/isp.c
@@ -2037,8 +2037,10 @@ static int isp_subdev_notifier_complete(struct v4l2_async_notifier *async)
mutex_lock(&isp->media_dev.graph_mutex);
ret = media_entity_enum_init(&isp->crashed, &isp->media_dev);
- if (ret)
+ if (ret) {
+ mutex_unlock(&isp->media_dev.graph_mutex);
return ret;
+ }
list_for_each_entry(sd, &v4l2_dev->subdevs, list) {
if (sd->notifier != &isp->notifier)
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] media: omap3isp: add missing unlock on error in isp_subdev_notifier_complete()
2021-05-12 9:23 [PATCH -next] media: omap3isp: add missing unlock on error in isp_subdev_notifier_complete() Yang Yingliang
@ 2021-06-23 23:06 ` Sakari Ailus
0 siblings, 0 replies; 2+ messages in thread
From: Sakari Ailus @ 2021-06-23 23:06 UTC (permalink / raw)
To: Yang Yingliang; +Cc: linux-kernel, linux-media, laurent.pinchart, mchehab
Hi Yang,
On Wed, May 12, 2021 at 05:23:01PM +0800, Yang Yingliang wrote:
> Add the missing unlock before return from isp_subdev_notifier_complete()
> in the error handling case.
>
> Fixes: ba689d933361 ("media: omap3isp: Acquire graph mutex for graph traversal")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Thanks for the patch. This is already fixed by another patch, accidentally
left sitting in my tree... It'll be in the next pull request.
<URL:https://patchwork.linuxtv.org/project/linux-media/patch/20210407143733.1608806-1-weiyongjun1@huawei.com/>
--
Sakari Ailus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-23 23:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-12 9:23 [PATCH -next] media: omap3isp: add missing unlock on error in isp_subdev_notifier_complete() Yang Yingliang
2021-06-23 23:06 ` Sakari Ailus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).