linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Connor Davis <connojdavis@gmail.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] xen: Export dbgp functions when CONFIG_XEN_DOM0 is enabled
Date: Wed, 12 May 2021 08:58:31 -0600	[thread overview]
Message-ID: <20210512145831.gxmmlimkmnnb6zyc@ceres> (raw)
In-Reply-To: <0c1d6722-138f-62e7-03b3-a644e36d20a5@oracle.com>

On May 12, 21, Boris Ostrovsky wrote:
>
> On 5/11/21 8:18 PM, Connor Davis wrote:
> > Export xen_dbgp_reset_prep and xen_dbgp_external_startup
> > when CONFIG_XEN_DOM0 is defined. This allows use of these symbols
> > even if CONFIG_EARLY_PRINK_DBGP is defined.
> >
> > Signed-off-by: Connor Davis <connojdavis@gmail.com>
> > ---
> >  drivers/xen/dbgp.c | 2 +-
>
>
> Unrelated to your patch but since you are fixing things around that file --- should we return -EPERM in xen_dbgp_op() when !xen_initial_domain()?

Yeah looks like it. That would make patch 3 simpler too.
Do you want me to add a patch that fixes that up?

>
> -boris
>

Thanks,
Connor

  reply	other threads:[~2021-05-12 15:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-12  0:18 [PATCH 0/3] Support xen-driven USB3 debug capability Connor Davis
2021-05-12  0:18 ` [PATCH 1/3] usb: early: Avoid using DbC if already enabled Connor Davis
2021-05-12  0:18 ` [PATCH 2/3] xen: Export dbgp functions when CONFIG_XEN_DOM0 is enabled Connor Davis
2021-05-12  5:41   ` Juergen Gross
2021-05-12 15:01     ` Connor Davis
2021-05-12 13:54   ` Boris Ostrovsky
2021-05-12 14:58     ` Connor Davis [this message]
2021-05-12 15:18       ` Boris Ostrovsky
2021-05-12  0:18 ` [PATCH 3/3] usb: xhci: Notify xen when DbC is unsafe to use Connor Davis
2021-05-12  7:03   ` Greg Kroah-Hartman
2021-05-12 14:59     ` Connor Davis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210512145831.gxmmlimkmnnb6zyc@ceres \
    --to=connojdavis@gmail.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=jgross@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).