From: Connor Davis <connojdavis@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
xen-devel@lists.xenproject.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] usb: xhci: Notify xen when DbC is unsafe to use
Date: Wed, 12 May 2021 08:59:59 -0600 [thread overview]
Message-ID: <20210512145959.h6boyhrh2bvgx5iz@ceres> (raw)
In-Reply-To: <YJt9su1k67KEFh6K@kroah.com>
On May 12, 21, Greg Kroah-Hartman wrote:
> On Tue, May 11, 2021 at 06:18:21PM -0600, Connor Davis wrote:
> > When running as a dom0 guest on Xen, check if the USB3 debug
> > capability is enabled before xHCI reset, suspend, and resume. If it
> > is, call xen_dbgp_reset_prep() to notify Xen that it is unsafe to touch
> > MMIO registers until the next xen_dbgp_external_startup().
> >
> > This notification allows Xen to avoid undefined behavior resulting
> > from MMIO access when the host controller's CNR bit is set or when
> > the device transitions to D3hot.
> >
> > Signed-off-by: Connor Davis <connojdavis@gmail.com>
> > ---
> > drivers/usb/host/xhci-dbgcap.h | 6 ++++
> > drivers/usb/host/xhci.c | 57 ++++++++++++++++++++++++++++++++++
> > drivers/usb/host/xhci.h | 1 +
> > 3 files changed, 64 insertions(+)
> >
> > diff --git a/drivers/usb/host/xhci-dbgcap.h b/drivers/usb/host/xhci-dbgcap.h
> > index c70b78d504eb..24784b82a840 100644
> > --- a/drivers/usb/host/xhci-dbgcap.h
> > +++ b/drivers/usb/host/xhci-dbgcap.h
> > @@ -227,4 +227,10 @@ static inline int xhci_dbc_resume(struct xhci_hcd *xhci)
> > return 0;
> > }
> > #endif /* CONFIG_USB_XHCI_DBGCAP */
> > +
> > +#ifdef CONFIG_XEN_DOM0
> > +int xen_dbgp_reset_prep(struct usb_hcd *hcd);
> > +int xen_dbgp_external_startup(struct usb_hcd *hcd);
> > +#endif /* CONFIG_XEN_DOM0 */
> > +
> > #endif /* __LINUX_XHCI_DBGCAP_H */
> > diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
> > index ca9385d22f68..afe44169183f 100644
> > --- a/drivers/usb/host/xhci.c
> > +++ b/drivers/usb/host/xhci.c
> > @@ -37,6 +37,57 @@ static unsigned long long quirks;
> > module_param(quirks, ullong, S_IRUGO);
> > MODULE_PARM_DESC(quirks, "Bit flags for quirks to be enabled as default");
> >
> > +#ifdef CONFIG_XEN_DOM0
> > +#include <xen/xen.h>
>
> <snip>
>
> Can't this #ifdef stuff go into a .h file?
>
Yep, will clean that up in v2.
> thanks,
>
> greg k-h
Thanks,
Connor
prev parent reply other threads:[~2021-05-12 15:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 0:18 [PATCH 0/3] Support xen-driven USB3 debug capability Connor Davis
2021-05-12 0:18 ` [PATCH 1/3] usb: early: Avoid using DbC if already enabled Connor Davis
2021-05-12 0:18 ` [PATCH 2/3] xen: Export dbgp functions when CONFIG_XEN_DOM0 is enabled Connor Davis
2021-05-12 5:41 ` Juergen Gross
2021-05-12 15:01 ` Connor Davis
2021-05-12 13:54 ` Boris Ostrovsky
2021-05-12 14:58 ` Connor Davis
2021-05-12 15:18 ` Boris Ostrovsky
2021-05-12 0:18 ` [PATCH 3/3] usb: xhci: Notify xen when DbC is unsafe to use Connor Davis
2021-05-12 7:03 ` Greg Kroah-Hartman
2021-05-12 14:59 ` Connor Davis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210512145959.h6boyhrh2bvgx5iz@ceres \
--to=connojdavis@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).