* [PATCH] gpio: gpio-tc3589x: emove platform_set_drvdata() + cleanup probe
@ 2021-05-15 10:58 Alexandru Ardelean
2021-05-24 18:59 ` Bartosz Golaszewski
0 siblings, 1 reply; 2+ messages in thread
From: Alexandru Ardelean @ 2021-05-15 10:58 UTC (permalink / raw)
To: linux-gpio, linux-kernel; +Cc: linus.walleij, bgolaszewski, Alexandru Ardelean
The platform_set_drvdata() call is only useful if we need to retrieve back
the private information.
Since the driver doesn't do that, it's not useful to have it.
If this is removed, we can also just do a direct return on
devm_gpiochip_add_data(). We don't need to print that this call failed as
there are other ways to log/see this during probe.
Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com>
---
drivers/gpio/gpio-tc3589x.c | 11 +----------
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/drivers/gpio/gpio-tc3589x.c b/drivers/gpio/gpio-tc3589x.c
index 55b8dbd13d11..8d158492488f 100644
--- a/drivers/gpio/gpio-tc3589x.c
+++ b/drivers/gpio/gpio-tc3589x.c
@@ -357,16 +357,7 @@ static int tc3589x_gpio_probe(struct platform_device *pdev)
return ret;
}
- ret = devm_gpiochip_add_data(&pdev->dev, &tc3589x_gpio->chip,
- tc3589x_gpio);
- if (ret) {
- dev_err(&pdev->dev, "unable to add gpiochip: %d\n", ret);
- return ret;
- }
-
- platform_set_drvdata(pdev, tc3589x_gpio);
-
- return 0;
+ return devm_gpiochip_add_data(&pdev->dev, &tc3589x_gpio->chip, tc3589x_gpio);
}
static struct platform_driver tc3589x_gpio_driver = {
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] gpio: gpio-tc3589x: emove platform_set_drvdata() + cleanup probe
2021-05-15 10:58 [PATCH] gpio: gpio-tc3589x: emove platform_set_drvdata() + cleanup probe Alexandru Ardelean
@ 2021-05-24 18:59 ` Bartosz Golaszewski
0 siblings, 0 replies; 2+ messages in thread
From: Bartosz Golaszewski @ 2021-05-24 18:59 UTC (permalink / raw)
To: Alexandru Ardelean; +Cc: linux-gpio, LKML, Linus Walleij
On Sat, May 15, 2021 at 12:58 PM Alexandru Ardelean
<aardelean@deviqon.com> wrote:
>
> The platform_set_drvdata() call is only useful if we need to retrieve back
> the private information.
> Since the driver doesn't do that, it's not useful to have it.
>
> If this is removed, we can also just do a direct return on
> devm_gpiochip_add_data(). We don't need to print that this call failed as
> there are other ways to log/see this during probe.
>
> Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com>
> ---
> drivers/gpio/gpio-tc3589x.c | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/drivers/gpio/gpio-tc3589x.c b/drivers/gpio/gpio-tc3589x.c
> index 55b8dbd13d11..8d158492488f 100644
> --- a/drivers/gpio/gpio-tc3589x.c
> +++ b/drivers/gpio/gpio-tc3589x.c
> @@ -357,16 +357,7 @@ static int tc3589x_gpio_probe(struct platform_device *pdev)
> return ret;
> }
>
> - ret = devm_gpiochip_add_data(&pdev->dev, &tc3589x_gpio->chip,
> - tc3589x_gpio);
> - if (ret) {
> - dev_err(&pdev->dev, "unable to add gpiochip: %d\n", ret);
> - return ret;
> - }
> -
> - platform_set_drvdata(pdev, tc3589x_gpio);
> -
> - return 0;
> + return devm_gpiochip_add_data(&pdev->dev, &tc3589x_gpio->chip, tc3589x_gpio);
> }
>
> static struct platform_driver tc3589x_gpio_driver = {
> --
> 2.31.1
>
Applied, thanks!
Bart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-24 19:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-15 10:58 [PATCH] gpio: gpio-tc3589x: emove platform_set_drvdata() + cleanup probe Alexandru Ardelean
2021-05-24 18:59 ` Bartosz Golaszewski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).