* [PATCH-next] sched: Fix Dereference after null check
@ 2021-05-15 17:11 Khaled ROMDHANI
2021-05-15 21:04 ` Peter Zijlstra
0 siblings, 1 reply; 2+ messages in thread
From: Khaled ROMDHANI @ 2021-05-15 17:11 UTC (permalink / raw)
To: mingo, peterz, juri.lelli, vincent.guittot, dietmar.eggemann,
rostedt, bsegall, mgorman, bristot
Cc: Khaled ROMDHANI, linux-kernel, kernel-janitors
The group_cfs_rq derefrence the 'se' variable that could
be passed as NULL pointer. Fix this by adding a check
against the sched entity 'se' before the derefrence.
Addresses-Coverity: ("Dereference after null check")
Signed-off-by: Khaled ROMDHANI <khaledromdhani216@gmail.com>
---
kernel/sched/fair.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 161b92aa1c79..9be6cdba351d 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -7080,7 +7080,8 @@ static struct task_struct *pick_task_fair(struct rq *rq)
}
se = pick_next_entity(cfs_rq, curr);
- cfs_rq = group_cfs_rq(se);
+ if (se)
+ cfs_rq = group_cfs_rq(se);
} while (cfs_rq);
return task_of(se);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH-next] sched: Fix Dereference after null check
2021-05-15 17:11 [PATCH-next] sched: Fix Dereference after null check Khaled ROMDHANI
@ 2021-05-15 21:04 ` Peter Zijlstra
0 siblings, 0 replies; 2+ messages in thread
From: Peter Zijlstra @ 2021-05-15 21:04 UTC (permalink / raw)
To: Khaled ROMDHANI
Cc: mingo, juri.lelli, vincent.guittot, dietmar.eggemann, rostedt,
bsegall, mgorman, bristot, linux-kernel, kernel-janitors
On Sat, May 15, 2021 at 06:11:17PM +0100, Khaled ROMDHANI wrote:
> The group_cfs_rq derefrence the 'se' variable that could
> be passed as NULL pointer. Fix this by adding a check
> against the sched entity 'se' before the derefrence.
>
> Addresses-Coverity: ("Dereference after null check")
> Signed-off-by: Khaled ROMDHANI <khaledromdhani216@gmail.com>
Please, burn that piece of garbage known as Coverity and go do something
useful.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-15 21:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-15 17:11 [PATCH-next] sched: Fix Dereference after null check Khaled ROMDHANI
2021-05-15 21:04 ` Peter Zijlstra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).