* [PATCH v2 -next] iio: adc: ad7793: Add missing error code in ad7793_setup()
@ 2021-05-14 8:02 YueHaibing
2021-05-16 9:17 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2021-05-14 8:02 UTC (permalink / raw)
To: lars, Michael.Hennerich, jic23, yuehaibing, gregkh
Cc: linux-iio, linux-kernel
Set error code while device ID query failed.
Fixes: 88bc30548aae ("IIO: ADC: New driver for AD7792/AD7793 3 Channel SPI ADC")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
v2: use ENODEV instead of EINVAL
drivers/iio/adc/ad7793.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/adc/ad7793.c b/drivers/iio/adc/ad7793.c
index 5e980a06258e..b4f9ac3838e1 100644
--- a/drivers/iio/adc/ad7793.c
+++ b/drivers/iio/adc/ad7793.c
@@ -279,6 +279,7 @@ static int ad7793_setup(struct iio_dev *indio_dev,
id &= AD7793_ID_MASK;
if (id != st->chip_info->id) {
+ ret = -ENODEV;
dev_err(&st->sd.spi->dev, "device ID query failed\n");
goto out;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 -next] iio: adc: ad7793: Add missing error code in ad7793_setup()
2021-05-14 8:02 [PATCH v2 -next] iio: adc: ad7793: Add missing error code in ad7793_setup() YueHaibing
@ 2021-05-16 9:17 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2021-05-16 9:17 UTC (permalink / raw)
To: YueHaibing; +Cc: lars, Michael.Hennerich, gregkh, linux-iio, linux-kernel
On Fri, 14 May 2021 16:02:54 +0800
YueHaibing <yuehaibing@huawei.com> wrote:
> Set error code while device ID query failed.
>
> Fixes: 88bc30548aae ("IIO: ADC: New driver for AD7792/AD7793 3 Channel SPI ADC")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
This one is going to be 'interesting' as that bit of code has changed a lot
since the fixes tag so chances are we may need to do a manual backport (or several!)
Applied to the fixes-togreg branch of iio.git.
Thanks,
Jonathan
> ---
> v2: use ENODEV instead of EINVAL
>
> drivers/iio/adc/ad7793.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/adc/ad7793.c b/drivers/iio/adc/ad7793.c
> index 5e980a06258e..b4f9ac3838e1 100644
> --- a/drivers/iio/adc/ad7793.c
> +++ b/drivers/iio/adc/ad7793.c
> @@ -279,6 +279,7 @@ static int ad7793_setup(struct iio_dev *indio_dev,
> id &= AD7793_ID_MASK;
>
> if (id != st->chip_info->id) {
> + ret = -ENODEV;
> dev_err(&st->sd.spi->dev, "device ID query failed\n");
> goto out;
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-16 9:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-14 8:02 [PATCH v2 -next] iio: adc: ad7793: Add missing error code in ad7793_setup() YueHaibing
2021-05-16 9:17 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).