* [PATCH] poly1305: Make prototypes match
@ 2021-04-25 21:13 Andi Kleen
2021-05-14 10:48 ` Herbert Xu
0 siblings, 1 reply; 4+ messages in thread
From: Andi Kleen @ 2021-04-25 21:13 UTC (permalink / raw)
To: linux-kernel; +Cc: Andi Kleen, Jason A . Donenfeld, Herbert Xu
From: Andi Kleen <andi@firstfloor.org>
gcc 11 complains when arrays in prototypes do not match the function.
Fix this here.
Cc: Jason A. Donenfeld <Jason@zx2c4.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Andi Kleen <andi@firstfloor.org>
---
include/crypto/internal/poly1305.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/crypto/internal/poly1305.h b/include/crypto/internal/poly1305.h
index 064e52ca5248..90ee36411e36 100644
--- a/include/crypto/internal/poly1305.h
+++ b/include/crypto/internal/poly1305.h
@@ -18,7 +18,7 @@
* only the ε-almost-∆-universal hash function (not the full MAC) is computed.
*/
-void poly1305_core_setkey(struct poly1305_core_key *key, const u8 *raw_key);
+void poly1305_core_setkey(struct poly1305_core_key *key, const u8 raw_key[16]);
static inline void poly1305_core_init(struct poly1305_state *state)
{
*state = (struct poly1305_state){};
--
2.25.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] poly1305: Make prototypes match
2021-04-25 21:13 [PATCH] poly1305: Make prototypes match Andi Kleen
@ 2021-05-14 10:48 ` Herbert Xu
2021-05-14 14:13 ` Andi Kleen
0 siblings, 1 reply; 4+ messages in thread
From: Herbert Xu @ 2021-05-14 10:48 UTC (permalink / raw)
To: Andi Kleen; +Cc: linux-kernel, Andi Kleen, Jason A . Donenfeld
On Sun, Apr 25, 2021 at 02:13:25PM -0700, Andi Kleen wrote:
> From: Andi Kleen <andi@firstfloor.org>
>
> gcc 11 complains when arrays in prototypes do not match the function.
> Fix this here.
>
> Cc: Jason A. Donenfeld <Jason@zx2c4.com>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Signed-off-by: Andi Kleen <andi@firstfloor.org>
> ---
> include/crypto/internal/poly1305.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Just noticed that this wasn't cc'ed to linux-crypto. Andi, could
you please resend with a cc to the list?
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] poly1305: Make prototypes match
2021-05-14 10:48 ` Herbert Xu
@ 2021-05-14 14:13 ` Andi Kleen
2021-05-17 1:05 ` Herbert Xu
0 siblings, 1 reply; 4+ messages in thread
From: Andi Kleen @ 2021-05-14 14:13 UTC (permalink / raw)
To: Herbert Xu; +Cc: Andi Kleen, linux-kernel, Andi Kleen, Jason A . Donenfeld
On Fri, May 14, 2021 at 06:48:13PM +0800, Herbert Xu wrote:
> On Sun, Apr 25, 2021 at 02:13:25PM -0700, Andi Kleen wrote:
> > From: Andi Kleen <andi@firstfloor.org>
> >
> > gcc 11 complains when arrays in prototypes do not match the function.
> > Fix this here.
> >
> > Cc: Jason A. Donenfeld <Jason@zx2c4.com>
> > Cc: Herbert Xu <herbert@gondor.apana.org.au>
> > Signed-off-by: Andi Kleen <andi@firstfloor.org>
> > ---
> > include/crypto/internal/poly1305.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Just noticed that this wasn't cc'ed to linux-crypto. Andi, could
> you please resend with a cc to the list?
I thought it was already fixed by Arnd? I think I collided with him.
-Andi
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] poly1305: Make prototypes match
2021-05-14 14:13 ` Andi Kleen
@ 2021-05-17 1:05 ` Herbert Xu
0 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2021-05-17 1:05 UTC (permalink / raw)
To: Andi Kleen; +Cc: Andi Kleen, linux-kernel, Jason A . Donenfeld
On Fri, May 14, 2021 at 07:13:57AM -0700, Andi Kleen wrote:
>
> I thought it was already fixed by Arnd? I think I collided with him.
Nevermind, you are right Andi.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-17 1:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-25 21:13 [PATCH] poly1305: Make prototypes match Andi Kleen
2021-05-14 10:48 ` Herbert Xu
2021-05-14 14:13 ` Andi Kleen
2021-05-17 1:05 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).