* [PATCH net-next] ethtool: stats: Fix a copy-paste error
@ 2021-05-19 2:10 YueHaibing
2021-05-19 2:37 ` Jakub Kicinski
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: YueHaibing @ 2021-05-19 2:10 UTC (permalink / raw)
To: davem, kuba, yuehaibing; +Cc: netdev, linux-kernel
data->ctrl_stats should be memset with correct size.
Fixes: bfad2b979ddc ("ethtool: add interface to read standard MAC Ctrl stats")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
net/ethtool/stats.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ethtool/stats.c b/net/ethtool/stats.c
index b7642dc96d50..ec07f5765e03 100644
--- a/net/ethtool/stats.c
+++ b/net/ethtool/stats.c
@@ -119,7 +119,7 @@ static int stats_prepare_data(const struct ethnl_req_info *req_base,
*/
memset(&data->phy_stats, 0xff, sizeof(data->phy_stats));
memset(&data->mac_stats, 0xff, sizeof(data->mac_stats));
- memset(&data->ctrl_stats, 0xff, sizeof(data->mac_stats));
+ memset(&data->ctrl_stats, 0xff, sizeof(data->ctrl_stats));
memset(&data->rmon_stats, 0xff, sizeof(data->rmon_stats));
if (test_bit(ETHTOOL_STATS_ETH_PHY, req_info->stat_mask) &&
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] ethtool: stats: Fix a copy-paste error
2021-05-19 2:10 [PATCH net-next] ethtool: stats: Fix a copy-paste error YueHaibing
@ 2021-05-19 2:37 ` Jakub Kicinski
2021-05-19 2:38 ` Jakub Kicinski
2021-05-19 19:00 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Jakub Kicinski @ 2021-05-19 2:37 UTC (permalink / raw)
To: YueHaibing; +Cc: davem, netdev, linux-kernel
On Wed, 19 May 2021 10:10:38 +0800 YueHaibing wrote:
> data->ctrl_stats should be memset with correct size.
>
> Fixes: bfad2b979ddc ("ethtool: add interface to read standard MAC Ctrl stats")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Jakub Kicinski <kuba@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] ethtool: stats: Fix a copy-paste error
2021-05-19 2:10 [PATCH net-next] ethtool: stats: Fix a copy-paste error YueHaibing
2021-05-19 2:37 ` Jakub Kicinski
@ 2021-05-19 2:38 ` Jakub Kicinski
2021-05-19 19:00 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Jakub Kicinski @ 2021-05-19 2:38 UTC (permalink / raw)
To: YueHaibing; +Cc: davem, netdev, linux-kernel
On Wed, 19 May 2021 10:10:38 +0800 YueHaibing wrote:
> data->ctrl_stats should be memset with correct size.
>
> Fixes: bfad2b979ddc ("ethtool: add interface to read standard MAC Ctrl stats")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Ah, FWIW this should had been targeting net.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net-next] ethtool: stats: Fix a copy-paste error
2021-05-19 2:10 [PATCH net-next] ethtool: stats: Fix a copy-paste error YueHaibing
2021-05-19 2:37 ` Jakub Kicinski
2021-05-19 2:38 ` Jakub Kicinski
@ 2021-05-19 19:00 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-05-19 19:00 UTC (permalink / raw)
To: YueHaibing; +Cc: davem, kuba, netdev, linux-kernel
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Wed, 19 May 2021 10:10:38 +0800 you wrote:
> data->ctrl_stats should be memset with correct size.
>
> Fixes: bfad2b979ddc ("ethtool: add interface to read standard MAC Ctrl stats")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> net/ethtool/stats.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- [net-next] ethtool: stats: Fix a copy-paste error
https://git.kernel.org/netdev/net/c/c71b99640d2d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-19 19:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-19 2:10 [PATCH net-next] ethtool: stats: Fix a copy-paste error YueHaibing
2021-05-19 2:37 ` Jakub Kicinski
2021-05-19 2:38 ` Jakub Kicinski
2021-05-19 19:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).