* [PATCH] Staging: greybus: fix open parenthesis issue in gbphy.c
@ 2021-05-19 15:11 F.A.Sulaiman
0 siblings, 0 replies; 4+ messages in thread
From: F.A.Sulaiman @ 2021-05-19 15:11 UTC (permalink / raw)
To: ash15.sulaiman, johan, elder, gregkh
Cc: F.A.Sulaiman, greybus-dev, linux-staging, linux-kernel
This fix "Alignment should match open parenthesis" checkpatch
error.
Signed-off-by: "F.A.Sulaiman" <asha.16@itfac.mrt.ac.lk>
---
drivers/staging/greybus/gbphy.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/greybus/gbphy.c b/drivers/staging/greybus/gbphy.c
index 9fc5c47be9bd..13d319860da5 100644
--- a/drivers/staging/greybus/gbphy.c
+++ b/drivers/staging/greybus/gbphy.c
@@ -27,7 +27,7 @@ struct gbphy_host {
static DEFINE_IDA(gbphy_id);
static ssize_t protocol_id_show(struct device *dev,
- struct device_attribute *attr, char *buf)
+ struct device_attribute *attr, char *buf)
{
struct gbphy_device *gbphy_dev = to_gbphy_dev(dev);
@@ -221,7 +221,7 @@ void gb_gbphy_deregister_driver(struct gbphy_driver *driver)
EXPORT_SYMBOL_GPL(gb_gbphy_deregister_driver);
static struct gbphy_device *gb_gbphy_create_dev(struct gb_bundle *bundle,
- struct greybus_descriptor_cport *cport_desc)
+ struct greybus_descriptor_cport *cport_desc)
{
struct gbphy_device *gbphy_dev;
int retval;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Staging: greybus: fix open parenthesis issue in gbphy.c
2021-05-19 15:18 F.A.Sulaiman
@ 2021-05-19 15:57 ` Greg KH
0 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2021-05-19 15:57 UTC (permalink / raw)
To: F.A.Sulaiman; +Cc: johan, elder, greybus-dev, linux-staging, linux-kernel
On Wed, May 19, 2021 at 08:48:51PM +0530, F.A.Sulaiman wrote:
> This fix "Alignment should match open parenthesis" checkpatch error.
>
> Signed-off-by: "F.A.Sulaiman" <asha.16@itfac.mrt.ac.lk>
> ---
> drivers/staging/greybus/gbphy.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/greybus/gbphy.c b/drivers/staging/greybus/gbphy.c
> index 9fc5c47be9bd..13d319860da5 100644
> --- a/drivers/staging/greybus/gbphy.c
> +++ b/drivers/staging/greybus/gbphy.c
> @@ -27,7 +27,7 @@ struct gbphy_host {
> static DEFINE_IDA(gbphy_id);
>
> static ssize_t protocol_id_show(struct device *dev,
> - struct device_attribute *attr, char *buf)
> + struct device_attribute *attr, char *buf)
> {
> struct gbphy_device *gbphy_dev = to_gbphy_dev(dev);
>
> @@ -221,7 +221,7 @@ void gb_gbphy_deregister_driver(struct gbphy_driver *driver)
> EXPORT_SYMBOL_GPL(gb_gbphy_deregister_driver);
>
> static struct gbphy_device *gb_gbphy_create_dev(struct gb_bundle *bundle,
> - struct greybus_descriptor_cport *cport_desc)
> + struct greybus_descriptor_cport *cport_desc)
> {
> struct gbphy_device *gbphy_dev;
> int retval;
> --
> 2.17.1
>
>
You sent this 3 different times, why?
Please send a new version, a v2, and say what changed from the previous
one.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] Staging: greybus: fix open parenthesis issue in gbphy.c
@ 2021-05-19 15:18 F.A.Sulaiman
2021-05-19 15:57 ` Greg KH
0 siblings, 1 reply; 4+ messages in thread
From: F.A.Sulaiman @ 2021-05-19 15:18 UTC (permalink / raw)
To: johan, elder, gregkh
Cc: greybus-dev, linux-staging, linux-kernel, F.A.Sulaiman
This fix "Alignment should match open parenthesis" checkpatch error.
Signed-off-by: "F.A.Sulaiman" <asha.16@itfac.mrt.ac.lk>
---
drivers/staging/greybus/gbphy.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/greybus/gbphy.c b/drivers/staging/greybus/gbphy.c
index 9fc5c47be9bd..13d319860da5 100644
--- a/drivers/staging/greybus/gbphy.c
+++ b/drivers/staging/greybus/gbphy.c
@@ -27,7 +27,7 @@ struct gbphy_host {
static DEFINE_IDA(gbphy_id);
static ssize_t protocol_id_show(struct device *dev,
- struct device_attribute *attr, char *buf)
+ struct device_attribute *attr, char *buf)
{
struct gbphy_device *gbphy_dev = to_gbphy_dev(dev);
@@ -221,7 +221,7 @@ void gb_gbphy_deregister_driver(struct gbphy_driver *driver)
EXPORT_SYMBOL_GPL(gb_gbphy_deregister_driver);
static struct gbphy_device *gb_gbphy_create_dev(struct gb_bundle *bundle,
- struct greybus_descriptor_cport *cport_desc)
+ struct greybus_descriptor_cport *cport_desc)
{
struct gbphy_device *gbphy_dev;
int retval;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] Staging: greybus: fix open parenthesis issue in gbphy.c
@ 2021-05-19 15:12 F.A.Sulaiman
0 siblings, 0 replies; 4+ messages in thread
From: F.A.Sulaiman @ 2021-05-19 15:12 UTC (permalink / raw)
To: ash15.sulaiman, johan, elder, gregkh
Cc: F.A.Sulaiman, greybus-dev, linux-staging, linux-kernel
This fix "Alignment should match open parenthesis" checkpatch
error.
Signed-off-by: "F.A.Sulaiman" <asha.16@itfac.mrt.ac.lk>
---
drivers/staging/greybus/gbphy.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/greybus/gbphy.c b/drivers/staging/greybus/gbphy.c
index 9fc5c47be9bd..13d319860da5 100644
--- a/drivers/staging/greybus/gbphy.c
+++ b/drivers/staging/greybus/gbphy.c
@@ -27,7 +27,7 @@ struct gbphy_host {
static DEFINE_IDA(gbphy_id);
static ssize_t protocol_id_show(struct device *dev,
- struct device_attribute *attr, char *buf)
+ struct device_attribute *attr, char *buf)
{
struct gbphy_device *gbphy_dev = to_gbphy_dev(dev);
@@ -221,7 +221,7 @@ void gb_gbphy_deregister_driver(struct gbphy_driver *driver)
EXPORT_SYMBOL_GPL(gb_gbphy_deregister_driver);
static struct gbphy_device *gb_gbphy_create_dev(struct gb_bundle *bundle,
- struct greybus_descriptor_cport *cport_desc)
+ struct greybus_descriptor_cport *cport_desc)
{
struct gbphy_device *gbphy_dev;
int retval;
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-19 15:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-19 15:11 [PATCH] Staging: greybus: fix open parenthesis issue in gbphy.c F.A.Sulaiman
2021-05-19 15:12 F.A.Sulaiman
2021-05-19 15:18 F.A.Sulaiman
2021-05-19 15:57 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).