* [PATCH] cpufreq: scmi: Fix an error message
@ 2021-05-06 19:09 Christophe JAILLET
2021-05-07 8:59 ` Sudeep Holla
2021-05-20 3:59 ` Viresh Kumar
0 siblings, 2 replies; 3+ messages in thread
From: Christophe JAILLET @ 2021-05-06 19:09 UTC (permalink / raw)
To: sudeep.holla, cristian.marussi, rjw, viresh.kumar, nicola.mazzucato
Cc: linux-arm-kernel, linux-pm, linux-kernel, kernel-janitors,
Christophe JAILLET
'ret' is known to be 0 here.
The last error code is stored in 'nr_opp', so use it in the error message.
Fixes: 71a37cd6a59d ("scmi-cpufreq: Remove deferred probe")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/cpufreq/scmi-cpufreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c
index c8a4364ad3c2..ec9a87ca2dbb 100644
--- a/drivers/cpufreq/scmi-cpufreq.c
+++ b/drivers/cpufreq/scmi-cpufreq.c
@@ -174,7 +174,7 @@ static int scmi_cpufreq_init(struct cpufreq_policy *policy)
nr_opp = dev_pm_opp_get_opp_count(cpu_dev);
if (nr_opp <= 0) {
dev_err(cpu_dev, "%s: No OPPs for this device: %d\n",
- __func__, ret);
+ __func__, nr_opp);
ret = -ENODEV;
goto out_free_opp;
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] cpufreq: scmi: Fix an error message
2021-05-06 19:09 [PATCH] cpufreq: scmi: Fix an error message Christophe JAILLET
@ 2021-05-07 8:59 ` Sudeep Holla
2021-05-20 3:59 ` Viresh Kumar
1 sibling, 0 replies; 3+ messages in thread
From: Sudeep Holla @ 2021-05-07 8:59 UTC (permalink / raw)
To: Christophe JAILLET
Cc: cristian.marussi, rjw, viresh.kumar, nicola.mazzucato,
linux-arm-kernel, linux-pm, linux-kernel, kernel-janitors
On Thu, May 06, 2021 at 09:09:48PM +0200, Christophe JAILLET wrote:
> 'ret' is known to be 0 here.
> The last error code is stored in 'nr_opp', so use it in the error message.
>
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cpufreq: scmi: Fix an error message
2021-05-06 19:09 [PATCH] cpufreq: scmi: Fix an error message Christophe JAILLET
2021-05-07 8:59 ` Sudeep Holla
@ 2021-05-20 3:59 ` Viresh Kumar
1 sibling, 0 replies; 3+ messages in thread
From: Viresh Kumar @ 2021-05-20 3:59 UTC (permalink / raw)
To: Christophe JAILLET
Cc: sudeep.holla, cristian.marussi, rjw, nicola.mazzucato,
linux-arm-kernel, linux-pm, linux-kernel, kernel-janitors
On 06-05-21, 21:09, Christophe JAILLET wrote:
> 'ret' is known to be 0 here.
> The last error code is stored in 'nr_opp', so use it in the error message.
>
> Fixes: 71a37cd6a59d ("scmi-cpufreq: Remove deferred probe")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/cpufreq/scmi-cpufreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c
> index c8a4364ad3c2..ec9a87ca2dbb 100644
> --- a/drivers/cpufreq/scmi-cpufreq.c
> +++ b/drivers/cpufreq/scmi-cpufreq.c
> @@ -174,7 +174,7 @@ static int scmi_cpufreq_init(struct cpufreq_policy *policy)
> nr_opp = dev_pm_opp_get_opp_count(cpu_dev);
> if (nr_opp <= 0) {
> dev_err(cpu_dev, "%s: No OPPs for this device: %d\n",
> - __func__, ret);
> + __func__, nr_opp);
>
> ret = -ENODEV;
> goto out_free_opp;
Applied. Thanks.
--
viresh
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-20 3:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-06 19:09 [PATCH] cpufreq: scmi: Fix an error message Christophe JAILLET
2021-05-07 8:59 ` Sudeep Holla
2021-05-20 3:59 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).