From: Mel Gorman <mgorman@techsingularity.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Michal Hocko <mhocko@kernel.org>,
David Hildenbrand <david@redhat.com>,
Vlastimil Babka <vbabka@suse.cz>,
Dan Streetman <ddstreet@ieee.org>, Yang Shi <shy828301@gmail.com>,
Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Mel Gorman <mgorman@techsingularity.net>
Subject: [PATCH 11/14] mm/swap: Make swap_address_space an inline function
Date: Thu, 20 May 2021 09:48:06 +0100 [thread overview]
Message-ID: <20210520084809.8576-12-mgorman@techsingularity.net> (raw)
In-Reply-To: <20210520084809.8576-1-mgorman@techsingularity.net>
make W=1 generates the following warning in page_mapping() for allnoconfig
mm/util.c:700:15: warning: variable ‘entry’ set but not used [-Wunused-but-set-variable]
swp_entry_t entry;
^~~~~
swap_address is a #define on !CONFIG_SWAP configurations. Make the helper
an inline function to suppress the warning, add type checking and to apply
any side-effects in the parameter list.
Signed-off-by: Mel Gorman <mgorman@techsingularity.net>
---
include/linux/swap.h | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/include/linux/swap.h b/include/linux/swap.h
index 144727041e78..216462c78a91 100644
--- a/include/linux/swap.h
+++ b/include/linux/swap.h
@@ -526,7 +526,11 @@ static inline struct swap_info_struct *swp_swap_info(swp_entry_t entry)
return NULL;
}
-#define swap_address_space(entry) (NULL)
+static inline struct address_space *swap_address_space(swp_entry_t entry)
+{
+ return NULL;
+}
+
#define get_nr_swap_pages() 0L
#define total_swap_pages 0L
#define total_swapcache_pages() 0UL
--
2.26.2
next prev parent reply other threads:[~2021-05-20 8:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-20 8:47 [PATCH 00/14] Clean W=1 build warnings for mm/ Mel Gorman
2021-05-20 8:47 ` [PATCH 01/14] mm/vmscan: Remove kerneldoc-like comment from isolate_lru_pages Mel Gorman
2021-05-20 8:47 ` [PATCH 02/14] mm/vmalloc: Include header for prototype of set_iounmap_nonlazy Mel Gorman
2021-05-20 8:47 ` [PATCH 03/14] mm/page_alloc: Make should_fail_alloc_page a static function should_fail_alloc_page static Mel Gorman
2021-07-08 19:18 ` Matteo Croce
2021-07-09 9:30 ` Mel Gorman
2021-05-20 8:47 ` [PATCH 04/14] mm/mapping_dirty_helpers: Remove double Note in kerneldoc Mel Gorman
2021-05-20 8:48 ` [PATCH 05/14] mm/early_ioremap: Add prototype for early_memremap_pgprot_adjust Mel Gorman
2021-05-20 8:48 ` [PATCH 06/14] mm/memcontrol.c: Fix kerneldoc comment for mem_cgroup_calculate_protection Mel Gorman
2021-05-20 23:24 ` Chris Down
2021-05-20 8:48 ` [PATCH 07/14] mm/memory_hotplug: Fix kerneldoc comment for __try_online_node Mel Gorman
2021-05-20 10:42 ` David Hildenbrand
2021-05-20 8:48 ` [PATCH 08/14] mm/memory_hotplug: Fix kerneldoc comment for __remove_memory Mel Gorman
2021-05-20 10:42 ` David Hildenbrand
2021-05-20 8:48 ` [PATCH 09/14] mm/zbud: Add kerneldoc fields for zbud_pool Mel Gorman
2021-05-20 8:48 ` [PATCH 10/14] mm/z3fold: Add kerneldoc fields for z3fold_pool Mel Gorman
2021-05-20 8:48 ` Mel Gorman [this message]
2021-05-20 8:48 ` [PATCH 12/14] mm/mmap_lock: Remove dead code for !CONFIG_TRACING configurations Mel Gorman
2021-05-20 8:48 ` [PATCH 13/14] mm/page_alloc: Move prototype for find_suitable_fallback Mel Gorman
2021-05-20 8:48 ` [PATCH 14/14] mm/swap: Make NODE_DATA an inline function on CONFIG_FLATMEM Mel Gorman
2021-05-20 22:51 ` [PATCH 00/14] Clean W=1 build warnings for mm/ Yang Shi
2021-05-25 11:48 ` Vlastimil Babka
2021-05-25 14:25 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210520084809.8576-12-mgorman@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=ddstreet@ieee.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=shy828301@gmail.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).