* [PATCH 00/11] Rid W=1 warnings from TTY
@ 2021-05-20 12:18 Lee Jones
2021-05-20 12:18 ` [PATCH 01/11] tty: vt: selection: Correct misspelled function sel_loadlut() Lee Jones
` (11 more replies)
0 siblings, 12 replies; 14+ messages in thread
From: Lee Jones @ 2021-05-20 12:18 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Al Longyear, Andrew J. Kroll, Andrew Morton,
Bill Hawes, C. Scott Ananian, Greg Kroah-Hartman, Jiri Slaby, --,
linux-arm-kernel, linux-serial, Marko Kohtala, Michael Callahan,
Michal Simek, Nick Holloway, Patrice Chotard, Paul Fulghum,
Paul Mackerras, processes-Sapan Bhatia, Rob Herring,
Russell King
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.
Lee Jones (11):
tty: vt: selection: Correct misspelled function sel_loadlut()
tty: serdev: core: Fix misspelled function name
__serdev_device_driver_register()
tty: tty_io: Fix a few kernel-doc related misdemeanours
tty: n_tty: Fix some misdocumented functions
tty: tty_buffer: Fix incorrectly documented function
__tty_buffer_request_room()
tty: tty_jobctrl: Fix 2 incorrectly documented functions
tty: pty: Fix incorrectly named function pty_resize()
tty: n_hdlc: Fix a little doc-rot in n_hdlc_tty_read()
tty: serial: st-asc: Demote a kernel-doc formatting abuse
tty: n_gsm: Fix function naming and provide missing param descriptions
tty: serial: xilinx_uartps: Fix documentation for
cdns_uart_clk_notifier_cb()
drivers/tty/n_gsm.c | 6 ++++--
drivers/tty/n_hdlc.c | 4 +++-
drivers/tty/n_tty.c | 10 +++++-----
drivers/tty/pty.c | 2 +-
drivers/tty/serdev/core.c | 2 +-
drivers/tty/serial/st-asc.c | 2 +-
drivers/tty/serial/xilinx_uartps.c | 2 +-
drivers/tty/tty_buffer.c | 2 +-
drivers/tty/tty_io.c | 17 +++++------------
drivers/tty/tty_jobctrl.c | 4 ++--
drivers/tty/vt/selection.c | 2 +-
11 files changed, 25 insertions(+), 28 deletions(-)
Cc: Al Longyear <longyear@netcom.com>
Cc: "Andrew J. Kroll" <ag784@freenet.buffalo.edu>
Cc: Andrew Morton <andrewm@uow.edu.eu>
Cc: Bill Hawes <whawes@star.net>
Cc: "C. Scott Ananian" <cananian@alumni.princeton.edu>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>
Cc: -- <julian@uhunix.uhcc.hawaii.edu>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-serial@vger.kernel.org
Cc: Marko Kohtala <Marko.Kohtala@hut.fi>
Cc: Michael Callahan <callahan@maths.ox.ac.uk>
Cc: Michal Simek <michal.simek@xilinx.com>
Cc: Nick Holloway <alfie@dcs.warwick.ac.uk>
Cc: Patrice Chotard <patrice.chotard@foss.st.com>
Cc: Paul Fulghum <paulkf@microgate.com>
Cc: Paul Mackerras <Paul.Mackerras@cs.anu.edu.au>
Cc: processes-Sapan Bhatia <sapan@corewars.org>
Cc: Rob Herring <robh@kernel.org>
Cc: Russell King <rmk@arm.linux.org.uk>
--
2.31.1
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 01/11] tty: vt: selection: Correct misspelled function sel_loadlut()
2021-05-20 12:18 [PATCH 00/11] Rid W=1 warnings from TTY Lee Jones
@ 2021-05-20 12:18 ` Lee Jones
2021-05-20 12:18 ` [PATCH 02/11] tty: serdev: core: Fix misspelled function name __serdev_device_driver_register() Lee Jones
` (10 subsequent siblings)
11 siblings, 0 replies; 14+ messages in thread
From: Lee Jones @ 2021-05-20 12:18 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, Greg Kroah-Hartman, Jiri Slaby
Fixes the following W=1 kernel build warning(s):
drivers/tty/vt/selection.c:119: warning: expecting prototype for set loadlut(). Prototype was for sel_loadlut() instead
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/tty/vt/selection.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/vt/selection.c b/drivers/tty/vt/selection.c
index bcb6bc5731cc4..f7755e73696e7 100644
--- a/drivers/tty/vt/selection.c
+++ b/drivers/tty/vt/selection.c
@@ -109,7 +109,7 @@ static inline int inword(const u32 c)
}
/**
- * set loadlut - load the LUT table
+ * sel_loadlut() - load the LUT table
* @p: user table
*
* Load the LUT table from user space. The caller must hold the console
--
2.31.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 02/11] tty: serdev: core: Fix misspelled function name __serdev_device_driver_register()
2021-05-20 12:18 [PATCH 00/11] Rid W=1 warnings from TTY Lee Jones
2021-05-20 12:18 ` [PATCH 01/11] tty: vt: selection: Correct misspelled function sel_loadlut() Lee Jones
@ 2021-05-20 12:18 ` Lee Jones
2021-05-20 12:18 ` [PATCH 03/11] tty: tty_io: Fix a few kernel-doc related misdemeanours Lee Jones
` (9 subsequent siblings)
11 siblings, 0 replies; 14+ messages in thread
From: Lee Jones @ 2021-05-20 12:18 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Rob Herring, Greg Kroah-Hartman, Jiri Slaby, linux-serial
Fixes the following W=1 kernel build warning(s):
drivers/tty/serdev/core.c:809: warning: expecting prototype for serdev_driver_register(). Prototype was for __serdev_device_driver_register() instead
Cc: Rob Herring <robh@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>
Cc: linux-serial@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/tty/serdev/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c
index aead0c0c97966..9cdfcfe07e87c 100644
--- a/drivers/tty/serdev/core.c
+++ b/drivers/tty/serdev/core.c
@@ -798,7 +798,7 @@ void serdev_controller_remove(struct serdev_controller *ctrl)
EXPORT_SYMBOL_GPL(serdev_controller_remove);
/**
- * serdev_driver_register() - Register client driver with serdev core
+ * __serdev_device_driver_register() - Register client driver with serdev core
* @sdrv: client driver to be associated with client-device.
* @owner: client driver owner to set.
*
--
2.31.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 03/11] tty: tty_io: Fix a few kernel-doc related misdemeanours
2021-05-20 12:18 [PATCH 00/11] Rid W=1 warnings from TTY Lee Jones
2021-05-20 12:18 ` [PATCH 01/11] tty: vt: selection: Correct misspelled function sel_loadlut() Lee Jones
2021-05-20 12:18 ` [PATCH 02/11] tty: serdev: core: Fix misspelled function name __serdev_device_driver_register() Lee Jones
@ 2021-05-20 12:18 ` Lee Jones
2021-05-20 12:18 ` [PATCH 04/11] tty: n_tty: Fix some misdocumented functions Lee Jones
` (8 subsequent siblings)
11 siblings, 0 replies; 14+ messages in thread
From: Lee Jones @ 2021-05-20 12:18 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Greg Kroah-Hartman, Jiri Slaby, Nick Holloway, --,
Marko Kohtala, Bill Hawes, C. Scott Ananian, Russell King,
Andrew Morton
Fixes the following W=1 kernel build warning(s):
drivers/tty/tty_io.c:785: warning: expecting prototype for stop_tty(). Prototype was for __stop_tty() instead
drivers/tty/tty_io.c:816: warning: expecting prototype for start_tty(). Prototype was for __start_tty() instead
drivers/tty/tty_io.c:931: warning: Function parameter or member 'iocb' not described in 'tty_read'
drivers/tty/tty_io.c:931: warning: Function parameter or member 'to' not described in 'tty_read'
drivers/tty/tty_io.c:931: warning: Excess function parameter 'file' description in 'tty_read'
drivers/tty/tty_io.c:931: warning: Excess function parameter 'buf' description in 'tty_read'
drivers/tty/tty_io.c:931: warning: Excess function parameter 'count' description in 'tty_read'
drivers/tty/tty_io.c:931: warning: Excess function parameter 'ppos' description in 'tty_read'
drivers/tty/tty_io.c:1115: warning: Function parameter or member 'iocb' not described in 'file_tty_write'
drivers/tty/tty_io.c:1115: warning: Function parameter or member 'from' not described in 'file_tty_write'
drivers/tty/tty_io.c:1115: warning: expecting prototype for tty_write(). Prototype was for file_tty_write() instead
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>
Cc: Nick Holloway <alfie@dcs.warwick.ac.uk>
Cc: -- <julian@uhunix.uhcc.hawaii.edu>
Cc: Marko Kohtala <Marko.Kohtala@hut.fi>
Cc: Bill Hawes <whawes@star.net>
Cc: "C. Scott Ananian" <cananian@alumni.princeton.edu>
Cc: Russell King <rmk@arm.linux.org.uk>
Cc: Andrew Morton <andrewm@uow.edu.eu>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/tty/tty_io.c | 15 ++++-----------
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
index 8f9e89715a68e..defea9cc20ce9 100644
--- a/drivers/tty/tty_io.c
+++ b/drivers/tty/tty_io.c
@@ -762,7 +762,7 @@ int tty_hung_up_p(struct file *filp)
EXPORT_SYMBOL(tty_hung_up_p);
/**
- * stop_tty - propagate flow control
+ * __stop_tty - propagate flow control
* @tty: tty to stop
*
* Perform flow control to the driver. May be called
@@ -798,7 +798,7 @@ void stop_tty(struct tty_struct *tty)
EXPORT_SYMBOL(stop_tty);
/**
- * start_tty - propagate flow control
+ * __start_tty - propagate flow control
* @tty: tty to start
*
* Start a tty that has been stopped if at all possible. If this
@@ -909,12 +909,8 @@ static int iterate_tty_read(struct tty_ldisc *ld, struct tty_struct *tty,
}
-/**
+/*
* tty_read - read method for tty device files
- * @file: pointer to tty file
- * @buf: user buffer
- * @count: size of user buffer
- * @ppos: unused
*
* Perform the read system call function on this terminal device. Checks
* for hung up devices before calling the line discipline method.
@@ -1093,12 +1089,9 @@ void tty_write_message(struct tty_struct *tty, char *msg)
}
-/**
+/*
* tty_write - write method for tty device file
* @file: tty file pointer
- * @buf: user data to write
- * @count: bytes to write
- * @ppos: unused
*
* Write data to a tty device via the line discipline.
*
--
2.31.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 04/11] tty: n_tty: Fix some misdocumented functions
2021-05-20 12:18 [PATCH 00/11] Rid W=1 warnings from TTY Lee Jones
` (2 preceding siblings ...)
2021-05-20 12:18 ` [PATCH 03/11] tty: tty_io: Fix a few kernel-doc related misdemeanours Lee Jones
@ 2021-05-20 12:18 ` Lee Jones
2021-05-20 12:19 ` [PATCH 05/11] tty: tty_buffer: Fix incorrectly documented function __tty_buffer_request_room() Lee Jones
` (7 subsequent siblings)
11 siblings, 0 replies; 14+ messages in thread
From: Lee Jones @ 2021-05-20 12:18 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Greg Kroah-Hartman, Jiri Slaby, Andrew J. Kroll,
processes-Sapan Bhatia
Fixes the following W=1 kernel build warning(s):
drivers/tty/n_tty.c:623: warning: expecting prototype for process_echoes(). Prototype was for __process_echoes() instead
drivers/tty/n_tty.c:1109: warning: expecting prototype for isig(). Prototype was for __isig() instead
drivers/tty/n_tty.c:1268: warning: expecting prototype for n_tty_receive_char(). Prototype was for n_tty_receive_char_special() instead
drivers/tty/n_tty.c:2132: warning: Function parameter or member 'kbuf' not described in 'n_tty_read'
drivers/tty/n_tty.c:2132: warning: Function parameter or member 'cookie' not described in 'n_tty_read'
drivers/tty/n_tty.c:2132: warning: Function parameter or member 'offset' not described in 'n_tty_read'
drivers/tty/n_tty.c:2132: warning: Excess function parameter 'buf' description in 'n_tty_read'
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>
Cc: "Andrew J. Kroll" <ag784@freenet.buffalo.edu>
Cc: processes-Sapan Bhatia <sapan@corewars.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/tty/n_tty.c | 10 +++++-----
drivers/tty/tty_io.c | 2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c
index 0ec93f1a61f5d..56d3b43d8a3a4 100644
--- a/drivers/tty/n_tty.c
+++ b/drivers/tty/n_tty.c
@@ -596,7 +596,7 @@ static ssize_t process_output_block(struct tty_struct *tty,
}
/**
- * process_echoes - write pending echo characters
+ * __process_echoes - write pending echo characters
* @tty: terminal device
*
* Write previously buffered echo (and other ldisc-generated)
@@ -1092,7 +1092,7 @@ static void eraser(unsigned char c, struct tty_struct *tty)
}
/**
- * isig - handle the ISIG optio
+ * __isig - handle the ISIG optio
* @sig: signal
* @tty: terminal
*
@@ -1248,7 +1248,7 @@ n_tty_receive_signal_char(struct tty_struct *tty, int signal, unsigned char c)
}
/**
- * n_tty_receive_char - perform processing
+ * n_tty_receive_char_special - perform processing
* @tty: terminal device
* @c: character
*
@@ -2042,11 +2042,11 @@ static int job_control(struct tty_struct *tty, struct file *file)
}
-/**
+/*
* n_tty_read - read function for tty
* @tty: tty device
* @file: file object
- * @buf: userspace buffer pointer
+ * @kbuf: userspace buffer pointer
* @nr: size of I/O
*
* Perform reads for the line discipline. We are guaranteed that the
diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
index defea9cc20ce9..7431c9e0c2bfe 100644
--- a/drivers/tty/tty_io.c
+++ b/drivers/tty/tty_io.c
@@ -1090,7 +1090,7 @@ void tty_write_message(struct tty_struct *tty, char *msg)
/*
- * tty_write - write method for tty device file
+ * file_tty_write - write method for tty device file
* @file: tty file pointer
*
* Write data to a tty device via the line discipline.
--
2.31.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 05/11] tty: tty_buffer: Fix incorrectly documented function __tty_buffer_request_room()
2021-05-20 12:18 [PATCH 00/11] Rid W=1 warnings from TTY Lee Jones
` (3 preceding siblings ...)
2021-05-20 12:18 ` [PATCH 04/11] tty: n_tty: Fix some misdocumented functions Lee Jones
@ 2021-05-20 12:19 ` Lee Jones
2021-05-20 12:19 ` [PATCH 06/11] tty: tty_jobctrl: Fix 2 incorrectly documented functions Lee Jones
` (6 subsequent siblings)
11 siblings, 0 replies; 14+ messages in thread
From: Lee Jones @ 2021-05-20 12:19 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, Greg Kroah-Hartman, Jiri Slaby
Fixes the following W=1 kernel build warning(s):
drivers/tty/tty_buffer.c:259: warning: expecting prototype for tty_buffer_request_room(). Prototype was for __tty_buffer_request_room() instead
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/tty/tty_buffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/tty_buffer.c b/drivers/tty/tty_buffer.c
index ace778ed23b91..635d0af229b72 100644
--- a/drivers/tty/tty_buffer.c
+++ b/drivers/tty/tty_buffer.c
@@ -244,7 +244,7 @@ void tty_buffer_flush(struct tty_struct *tty, struct tty_ldisc *ld)
}
/**
- * tty_buffer_request_room - grow tty buffer if needed
+ * __tty_buffer_request_room - grow tty buffer if needed
* @port: tty port
* @size: size desired
* @flags: buffer flags if new buffer allocated (default = 0)
--
2.31.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 06/11] tty: tty_jobctrl: Fix 2 incorrectly documented functions
2021-05-20 12:18 [PATCH 00/11] Rid W=1 warnings from TTY Lee Jones
` (4 preceding siblings ...)
2021-05-20 12:19 ` [PATCH 05/11] tty: tty_buffer: Fix incorrectly documented function __tty_buffer_request_room() Lee Jones
@ 2021-05-20 12:19 ` Lee Jones
2021-05-20 12:19 ` [PATCH 07/11] tty: pty: Fix incorrectly named function pty_resize() Lee Jones
` (5 subsequent siblings)
11 siblings, 0 replies; 14+ messages in thread
From: Lee Jones @ 2021-05-20 12:19 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, Greg Kroah-Hartman, Jiri Slaby
Fixes the following W=1 kernel build warning(s):
drivers/tty/tty_jobctrl.c:33: warning: expecting prototype for tty_check_change(). Prototype was for __tty_check_change() instead
drivers/tty/tty_jobctrl.c:97: warning: expecting prototype for proc_set_tty(). Prototype was for __proc_set_tty() instead
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/tty/tty_jobctrl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/tty_jobctrl.c b/drivers/tty/tty_jobctrl.c
index 6119b5e486108..80b86a7992b50 100644
--- a/drivers/tty/tty_jobctrl.c
+++ b/drivers/tty/tty_jobctrl.c
@@ -20,7 +20,7 @@ static int is_ignored(int sig)
}
/**
- * tty_check_change - check for POSIX terminal changes
+ * __tty_check_change - check for POSIX terminal changes
* @tty: tty to check
* @sig: signal to send
*
@@ -85,7 +85,7 @@ void proc_clear_tty(struct task_struct *p)
}
/**
- * proc_set_tty - set the controlling terminal
+ * __proc_set_tty - set the controlling terminal
* @tty: tty structure
*
* Only callable by the session leader and only if it does not already have
--
2.31.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 07/11] tty: pty: Fix incorrectly named function pty_resize()
2021-05-20 12:18 [PATCH 00/11] Rid W=1 warnings from TTY Lee Jones
` (5 preceding siblings ...)
2021-05-20 12:19 ` [PATCH 06/11] tty: tty_jobctrl: Fix 2 incorrectly documented functions Lee Jones
@ 2021-05-20 12:19 ` Lee Jones
2021-05-20 12:19 ` [PATCH 08/11] tty: n_hdlc: Fix a little doc-rot in n_hdlc_tty_read() Lee Jones
` (4 subsequent siblings)
11 siblings, 0 replies; 14+ messages in thread
From: Lee Jones @ 2021-05-20 12:19 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, Greg Kroah-Hartman, Jiri Slaby, C. Scott Ananian
Fixes the following W=1 kernel build warning(s):
drivers/tty/pty.c:306: warning: expecting prototype for pty_do_resize(). Prototype was for pty_resize() instead
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>
Cc: "C. Scott Ananian" <cananian@alumni.princeton.edu>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/tty/pty.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/pty.c b/drivers/tty/pty.c
index 5ada7e9381eb8..a0898925d2e7a 100644
--- a/drivers/tty/pty.c
+++ b/drivers/tty/pty.c
@@ -282,7 +282,7 @@ static void pty_set_termios(struct tty_struct *tty,
}
/**
- * pty_do_resize - resize event
+ * pty_resize - resize event
* @tty: tty being resized
* @ws: window size being set.
*
--
2.31.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 08/11] tty: n_hdlc: Fix a little doc-rot in n_hdlc_tty_read()
2021-05-20 12:18 [PATCH 00/11] Rid W=1 warnings from TTY Lee Jones
` (6 preceding siblings ...)
2021-05-20 12:19 ` [PATCH 07/11] tty: pty: Fix incorrectly named function pty_resize() Lee Jones
@ 2021-05-20 12:19 ` Lee Jones
2021-05-20 12:19 ` [PATCH 09/11] tty: serial: st-asc: Demote a kernel-doc formatting abuse Lee Jones
` (3 subsequent siblings)
11 siblings, 0 replies; 14+ messages in thread
From: Lee Jones @ 2021-05-20 12:19 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Greg Kroah-Hartman, Jiri Slaby, Paul Fulghum,
Michael Callahan, Al Longyear, Paul Mackerras
Fixes the following W=1 kernel build warning(s):
drivers/tty/n_hdlc.c:421: warning: Function parameter or member 'kbuf' not described in 'n_hdlc_tty_read'
drivers/tty/n_hdlc.c:421: warning: Function parameter or member 'cookie' not described in 'n_hdlc_tty_read'
drivers/tty/n_hdlc.c:421: warning: Function parameter or member 'offset' not described in 'n_hdlc_tty_read'
drivers/tty/n_hdlc.c:421: warning: Excess function parameter 'buf' description in 'n_hdlc_tty_read'
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>
Cc: Paul Fulghum <paulkf@microgate.com>
Cc: Michael Callahan <callahan@maths.ox.ac.uk>
Cc: Al Longyear <longyear@netcom.com>
Cc: Paul Mackerras <Paul.Mackerras@cs.anu.edu.au>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/tty/n_hdlc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/tty/n_hdlc.c b/drivers/tty/n_hdlc.c
index d899ee4e0116f..580a37b3fe1b9 100644
--- a/drivers/tty/n_hdlc.c
+++ b/drivers/tty/n_hdlc.c
@@ -411,8 +411,10 @@ static void n_hdlc_tty_receive(struct tty_struct *tty, const __u8 *data,
* n_hdlc_tty_read - Called to retrieve one frame of data (if available)
* @tty: pointer to tty instance data
* @file: pointer to open file object
- * @buf: pointer to returned data buffer
+ * @kbuf: pointer to returned data buffer
* @nr: size of returned data buffer
+ * @cookie: stored rbuf from previous run
+ * @offset: offset into the data buffer
*
* Returns the number of bytes returned or error code.
*/
--
2.31.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 09/11] tty: serial: st-asc: Demote a kernel-doc formatting abuse
2021-05-20 12:18 [PATCH 00/11] Rid W=1 warnings from TTY Lee Jones
` (7 preceding siblings ...)
2021-05-20 12:19 ` [PATCH 08/11] tty: n_hdlc: Fix a little doc-rot in n_hdlc_tty_read() Lee Jones
@ 2021-05-20 12:19 ` Lee Jones
2021-05-20 12:19 ` [PATCH 10/11] tty: n_gsm: Fix function naming and provide missing param descriptions Lee Jones
` (2 subsequent siblings)
11 siblings, 0 replies; 14+ messages in thread
From: Lee Jones @ 2021-05-20 12:19 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Patrice Chotard, Greg Kroah-Hartman, Jiri Slaby,
linux-arm-kernel, linux-serial
Fixes the following W=1 kernel build warning(s):
drivers/tty/serial/st-asc.c:73: warning: expecting prototype for Some of status comes from higher bits of the character and some come from(). Prototype was for ASC_RXBUF_DUMMY_RX() instead
Cc: Patrice Chotard <patrice.chotard@foss.st.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-serial@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/tty/serial/st-asc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/st-asc.c b/drivers/tty/serial/st-asc.c
index e7048515a79ca..62128bbd03151 100644
--- a/drivers/tty/serial/st-asc.c
+++ b/drivers/tty/serial/st-asc.c
@@ -65,7 +65,7 @@ static struct uart_driver asc_uart_driver;
/* ASC_RXBUF */
#define ASC_RXBUF_PE 0x100
#define ASC_RXBUF_FE 0x200
-/**
+/*
* Some of status comes from higher bits of the character and some come from
* the status register. Combining both of them in to single status using dummy
* bits.
--
2.31.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 10/11] tty: n_gsm: Fix function naming and provide missing param descriptions
2021-05-20 12:18 [PATCH 00/11] Rid W=1 warnings from TTY Lee Jones
` (8 preceding siblings ...)
2021-05-20 12:19 ` [PATCH 09/11] tty: serial: st-asc: Demote a kernel-doc formatting abuse Lee Jones
@ 2021-05-20 12:19 ` Lee Jones
2021-05-20 12:19 ` [PATCH 11/11] tty: serial: xilinx_uartps: Fix documentation for cdns_uart_clk_notifier_cb() Lee Jones
2021-05-20 15:07 ` [PATCH 00/11] Rid W=1 warnings from TTY Greg Kroah-Hartman
11 siblings, 0 replies; 14+ messages in thread
From: Lee Jones @ 2021-05-20 12:19 UTC (permalink / raw)
To: lee.jones; +Cc: linux-kernel, Greg Kroah-Hartman, Jiri Slaby
Fixes the following W=1 kernel build warning(s):
drivers/tty/n_gsm.c:525: warning: expecting prototype for gsm_stuff_packet(). Prototype was for gsm_stuff_frame() instead
drivers/tty/n_gsm.c:1608: warning: expecting prototype for gsm_dlci_control(). Prototype was for gsm_dlci_command() instead
drivers/tty/n_gsm.c:2561: warning: Function parameter or member 'cookie' not described in 'gsmld_read'
drivers/tty/n_gsm.c:2561: warning: Function parameter or member 'offset' not described in 'gsmld_read'
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/tty/n_gsm.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
index bd24dc0d7e967..e907b7a5cab58 100644
--- a/drivers/tty/n_gsm.c
+++ b/drivers/tty/n_gsm.c
@@ -512,7 +512,7 @@ static void gsm_print_packet(const char *hdr, int addr, int cr,
*/
/**
- * gsm_stuff_packet - bytestuff a packet
+ * gsm_stuff_frame - bytestuff a packet
* @input: input buffer
* @output: output buffer
* @len: length of input
@@ -1594,7 +1594,7 @@ static void gsm_dlci_data(struct gsm_dlci *dlci, const u8 *data, int clen)
}
/**
- * gsm_dlci_control - data arrived on control channel
+ * gsm_dlci_command - data arrived on control channel
* @dlci: channel
* @data: block of bytes received
* @len: length of received block
@@ -2557,6 +2557,8 @@ static void gsmld_write_wakeup(struct tty_struct *tty)
* @file: file object
* @buf: userspace buffer pointer
* @nr: size of I/O
+ * @cookie: unused
+ * @offset: unused
*
* Perform reads for the line discipline. We are guaranteed that the
* line discipline will not be closed under us but we may get multiple
--
2.31.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH 11/11] tty: serial: xilinx_uartps: Fix documentation for cdns_uart_clk_notifier_cb()
2021-05-20 12:18 [PATCH 00/11] Rid W=1 warnings from TTY Lee Jones
` (9 preceding siblings ...)
2021-05-20 12:19 ` [PATCH 10/11] tty: n_gsm: Fix function naming and provide missing param descriptions Lee Jones
@ 2021-05-20 12:19 ` Lee Jones
2021-05-20 12:21 ` Michal Simek
2021-05-20 15:07 ` [PATCH 00/11] Rid W=1 warnings from TTY Greg Kroah-Hartman
11 siblings, 1 reply; 14+ messages in thread
From: Lee Jones @ 2021-05-20 12:19 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Greg Kroah-Hartman, Jiri Slaby, Michal Simek,
linux-serial, linux-arm-kernel
Fixes the following W=1 kernel build warning(s):
drivers/tty/serial/xilinx_uartps.c:496: warning: expecting prototype for cdns_uart_clk_notitifer_cb(). Prototype was for cdns_uart_clk_notifier_cb() instead
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>
Cc: Michal Simek <michal.simek@xilinx.com>
Cc: linux-serial@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/tty/serial/xilinx_uartps.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
index 67a2db621e2b7..2cdcfb8f034de 100644
--- a/drivers/tty/serial/xilinx_uartps.c
+++ b/drivers/tty/serial/xilinx_uartps.c
@@ -484,7 +484,7 @@ static unsigned int cdns_uart_set_baud_rate(struct uart_port *port,
#ifdef CONFIG_COMMON_CLK
/**
- * cdns_uart_clk_notitifer_cb - Clock notifier callback
+ * cdns_uart_clk_notifier_cb - Clock notifier callback
* @nb: Notifier block
* @event: Notify event
* @data: Notifier data
--
2.31.1
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH 11/11] tty: serial: xilinx_uartps: Fix documentation for cdns_uart_clk_notifier_cb()
2021-05-20 12:19 ` [PATCH 11/11] tty: serial: xilinx_uartps: Fix documentation for cdns_uart_clk_notifier_cb() Lee Jones
@ 2021-05-20 12:21 ` Michal Simek
0 siblings, 0 replies; 14+ messages in thread
From: Michal Simek @ 2021-05-20 12:21 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Greg Kroah-Hartman, Jiri Slaby, Michal Simek,
linux-serial, linux-arm-kernel
On 5/20/21 2:19 PM, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/tty/serial/xilinx_uartps.c:496: warning: expecting prototype for cdns_uart_clk_notitifer_cb(). Prototype was for cdns_uart_clk_notifier_cb() instead
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jiri Slaby <jirislaby@kernel.org>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Cc: linux-serial@vger.kernel.org
> Cc: linux-arm-kernel@lists.infradead.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/tty/serial/xilinx_uartps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c
> index 67a2db621e2b7..2cdcfb8f034de 100644
> --- a/drivers/tty/serial/xilinx_uartps.c
> +++ b/drivers/tty/serial/xilinx_uartps.c
> @@ -484,7 +484,7 @@ static unsigned int cdns_uart_set_baud_rate(struct uart_port *port,
>
> #ifdef CONFIG_COMMON_CLK
> /**
> - * cdns_uart_clk_notitifer_cb - Clock notifier callback
> + * cdns_uart_clk_notifier_cb - Clock notifier callback
> * @nb: Notifier block
> * @event: Notify event
> * @data: Notifier data
>
Reviewed-by: Michal Simek <michal.simek@xilinx.com>
Thanks,
Michal
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 00/11] Rid W=1 warnings from TTY
2021-05-20 12:18 [PATCH 00/11] Rid W=1 warnings from TTY Lee Jones
` (10 preceding siblings ...)
2021-05-20 12:19 ` [PATCH 11/11] tty: serial: xilinx_uartps: Fix documentation for cdns_uart_clk_notifier_cb() Lee Jones
@ 2021-05-20 15:07 ` Greg Kroah-Hartman
11 siblings, 0 replies; 14+ messages in thread
From: Greg Kroah-Hartman @ 2021-05-20 15:07 UTC (permalink / raw)
To: Lee Jones
Cc: linux-kernel, Al Longyear, Andrew J. Kroll, Andrew Morton,
Bill Hawes, C. Scott Ananian, Jiri Slaby, --,
linux-arm-kernel, linux-serial, Marko Kohtala, Michael Callahan,
Michal Simek, Nick Holloway, Patrice Chotard, Paul Fulghum,
Paul Mackerras, processes-Sapan Bhatia, Rob Herring,
Russell King
On Thu, May 20, 2021 at 01:18:55PM +0100, Lee Jones wrote:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
All but 3 applied to my tree, you should rebase and resend those
remaining ones as they conflicted with things that others recently
changed.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2021-05-20 15:07 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-20 12:18 [PATCH 00/11] Rid W=1 warnings from TTY Lee Jones
2021-05-20 12:18 ` [PATCH 01/11] tty: vt: selection: Correct misspelled function sel_loadlut() Lee Jones
2021-05-20 12:18 ` [PATCH 02/11] tty: serdev: core: Fix misspelled function name __serdev_device_driver_register() Lee Jones
2021-05-20 12:18 ` [PATCH 03/11] tty: tty_io: Fix a few kernel-doc related misdemeanours Lee Jones
2021-05-20 12:18 ` [PATCH 04/11] tty: n_tty: Fix some misdocumented functions Lee Jones
2021-05-20 12:19 ` [PATCH 05/11] tty: tty_buffer: Fix incorrectly documented function __tty_buffer_request_room() Lee Jones
2021-05-20 12:19 ` [PATCH 06/11] tty: tty_jobctrl: Fix 2 incorrectly documented functions Lee Jones
2021-05-20 12:19 ` [PATCH 07/11] tty: pty: Fix incorrectly named function pty_resize() Lee Jones
2021-05-20 12:19 ` [PATCH 08/11] tty: n_hdlc: Fix a little doc-rot in n_hdlc_tty_read() Lee Jones
2021-05-20 12:19 ` [PATCH 09/11] tty: serial: st-asc: Demote a kernel-doc formatting abuse Lee Jones
2021-05-20 12:19 ` [PATCH 10/11] tty: n_gsm: Fix function naming and provide missing param descriptions Lee Jones
2021-05-20 12:19 ` [PATCH 11/11] tty: serial: xilinx_uartps: Fix documentation for cdns_uart_clk_notifier_cb() Lee Jones
2021-05-20 12:21 ` Michal Simek
2021-05-20 15:07 ` [PATCH 00/11] Rid W=1 warnings from TTY Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).