* [sound:for-linus 117/119] sound/usb/mixer_scarlett_gen2.c:2000:5: sparse: sparse: symbol 'snd_scarlett_gen2_controls_create' was not declared. Should it be static?
@ 2021-05-22 18:08 kernel test robot
2021-05-22 18:09 ` [RFC PATCH sound] ALSA: usb-audio: scarlett2: snd_scarlett_gen2_controls_create() can be static kernel test robot
0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2021-05-22 18:08 UTC (permalink / raw)
To: Geoffrey D. Bennett
Cc: kbuild-all, alsa-devel, Takashi Iwai, Jaroslav Kysela,
Joe Perches, Alexander Tsoy, Mark Brown, Greg Kroah-Hartman,
Pierre-Louis Bossart, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1375 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-linus
head: 9ebaef0540a981093bce5df15af32354d32391d9
commit: 265d1a90e4fb6d3264d8122fbd10760e5e733be6 [117/119] ALSA: usb-audio: scarlett2: Improve driver startup messages
config: x86_64-randconfig-s021-20210522 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
# apt-get install sparse
# sparse version: v0.6.3-341-g8af24329-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git/commit/?id=265d1a90e4fb6d3264d8122fbd10760e5e733be6
git remote add sound https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git
git fetch --no-tags sound for-linus
git checkout 265d1a90e4fb6d3264d8122fbd10760e5e733be6
# save the attached .config to linux build tree
make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' W=1 ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
sparse warnings: (new ones prefixed by >>)
>> sound/usb/mixer_scarlett_gen2.c:2000:5: sparse: sparse: symbol 'snd_scarlett_gen2_controls_create' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 39832 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* [RFC PATCH sound] ALSA: usb-audio: scarlett2: snd_scarlett_gen2_controls_create() can be static
2021-05-22 18:08 [sound:for-linus 117/119] sound/usb/mixer_scarlett_gen2.c:2000:5: sparse: sparse: symbol 'snd_scarlett_gen2_controls_create' was not declared. Should it be static? kernel test robot
@ 2021-05-22 18:09 ` kernel test robot
2021-05-23 8:32 ` Takashi Iwai
0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2021-05-22 18:09 UTC (permalink / raw)
To: Geoffrey D. Bennett
Cc: kbuild-all, alsa-devel, Takashi Iwai, Jaroslav Kysela,
Joe Perches, Alexander Tsoy, Pierre-Louis Bossart,
Greg Kroah-Hartman, linux-kernel
sound/usb/mixer_scarlett_gen2.c:2000:5: warning: symbol 'snd_scarlett_gen2_controls_create' was not declared. Should it be static?
Fixes: 265d1a90e4fb ("ALSA: usb-audio: scarlett2: Improve driver startup messages")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
mixer_scarlett_gen2.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/usb/mixer_scarlett_gen2.c b/sound/usb/mixer_scarlett_gen2.c
index 3ad8f61a2095f..4caf379d5b991 100644
--- a/sound/usb/mixer_scarlett_gen2.c
+++ b/sound/usb/mixer_scarlett_gen2.c
@@ -1997,8 +1997,8 @@ static int scarlett2_mixer_status_create(struct usb_mixer_interface *mixer)
return usb_submit_urb(mixer->urb, GFP_KERNEL);
}
-int snd_scarlett_gen2_controls_create(struct usb_mixer_interface *mixer,
- const struct scarlett2_device_info *info)
+static int snd_scarlett_gen2_controls_create(struct usb_mixer_interface *mixer,
+ const struct scarlett2_device_info *info)
{
int err;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFC PATCH sound] ALSA: usb-audio: scarlett2: snd_scarlett_gen2_controls_create() can be static
2021-05-22 18:09 ` [RFC PATCH sound] ALSA: usb-audio: scarlett2: snd_scarlett_gen2_controls_create() can be static kernel test robot
@ 2021-05-23 8:32 ` Takashi Iwai
0 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2021-05-23 8:32 UTC (permalink / raw)
To: kernel test robot
Cc: Geoffrey D. Bennett, kbuild-all, alsa-devel, Jaroslav Kysela,
Joe Perches, Alexander Tsoy, Pierre-Louis Bossart,
Greg Kroah-Hartman, linux-kernel
On Sat, 22 May 2021 20:09:00 +0200,
kernel test robot wrote:
>
> sound/usb/mixer_scarlett_gen2.c:2000:5: warning: symbol 'snd_scarlett_gen2_controls_create' was not declared. Should it be static?
>
> Fixes: 265d1a90e4fb ("ALSA: usb-audio: scarlett2: Improve driver startup messages")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: kernel test robot <lkp@intel.com>
Applied now. Thanks.
Takashi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-23 8:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-22 18:08 [sound:for-linus 117/119] sound/usb/mixer_scarlett_gen2.c:2000:5: sparse: sparse: symbol 'snd_scarlett_gen2_controls_create' was not declared. Should it be static? kernel test robot
2021-05-22 18:09 ` [RFC PATCH sound] ALSA: usb-audio: scarlett2: snd_scarlett_gen2_controls_create() can be static kernel test robot
2021-05-23 8:32 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).