linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] media: atomisp: Replace whitespace at the beginning of line
@ 2021-05-20 15:50 Aniket Bhattacharyea
  2021-05-24 15:20 ` Sakari Ailus
  0 siblings, 1 reply; 2+ messages in thread
From: Aniket Bhattacharyea @ 2021-05-20 15:50 UTC (permalink / raw)
  To: mchehab, sakari.ailus, gregkh, andriy.shevchenko
  Cc: linux-media, linux-staging, linux-kernel, Aniket Bhattacharyea

This patch replaces the whitespaces at the beginning of line with tabs.
Identified by checkpatch: WARNING: please, no spaces at the start of a line.

Signed-off-by: Aniket Bhattacharyea <aniketmail669@gmail.com>
---
 drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c b/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
index 135994d44802..93ac7e183344 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
@@ -1041,9 +1041,9 @@ static struct camera_sensor_platform_data acpi_gmin_plat = {
 };
 
 struct camera_sensor_platform_data *gmin_camera_platform_data(
-    struct v4l2_subdev *subdev,
-    enum atomisp_input_format csi_format,
-    enum atomisp_bayer_order csi_bayer)
+	struct v4l2_subdev *subdev,
+	enum atomisp_input_format csi_format,
+	enum atomisp_bayer_order csi_bayer)
 {
 	u8 pmic_i2c_addr = gmin_detect_pmic(subdev);
 	struct gmin_subdev *gs;
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] media: atomisp: Replace whitespace at the beginning of line
  2021-05-20 15:50 [PATCH] media: atomisp: Replace whitespace at the beginning of line Aniket Bhattacharyea
@ 2021-05-24 15:20 ` Sakari Ailus
  0 siblings, 0 replies; 2+ messages in thread
From: Sakari Ailus @ 2021-05-24 15:20 UTC (permalink / raw)
  To: Aniket Bhattacharyea
  Cc: mchehab, gregkh, andriy.shevchenko, linux-media, linux-staging,
	linux-kernel

Hi Aniket,

On Thu, May 20, 2021 at 09:20:13PM +0530, Aniket Bhattacharyea wrote:
> This patch replaces the whitespaces at the beginning of line with tabs.
> Identified by checkpatch: WARNING: please, no spaces at the start of a line.
> 
> Signed-off-by: Aniket Bhattacharyea <aniketmail669@gmail.com>
> ---
>  drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c b/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
> index 135994d44802..93ac7e183344 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
> @@ -1041,9 +1041,9 @@ static struct camera_sensor_platform_data acpi_gmin_plat = {
>  };
>  
>  struct camera_sensor_platform_data *gmin_camera_platform_data(
> -    struct v4l2_subdev *subdev,
> -    enum atomisp_input_format csi_format,
> -    enum atomisp_bayer_order csi_bayer)
> +	struct v4l2_subdev *subdev,
> +	enum atomisp_input_format csi_format,
> +	enum atomisp_bayer_order csi_bayer)

Please wrap instead after the type if the type and name are too long.

I.e.

struct camera_sensor_platform_data *
gmin_camera_platform_data(...,
			  ...);

>  {
>  	u8 pmic_i2c_addr = gmin_detect_pmic(subdev);
>  	struct gmin_subdev *gs;

-- 
Regards,

Sakari Ailus

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-05-24 15:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-20 15:50 [PATCH] media: atomisp: Replace whitespace at the beginning of line Aniket Bhattacharyea
2021-05-24 15:20 ` Sakari Ailus

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).