From: Lee Jones <lee.jones@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Robert Marko <robert.marko@sartura.hr>,
linus.walleij@linaro.org, bgolaszewski@baylibre.com,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, luka.perkov@sartura.hr,
jmp@epiphyte.org, pmenzel@molgen.mpg.de, buczek@molgen.mpg.de
Subject: Re: [PATCH v2 3/4] dt-bindings: mfd: Add Delta TN48M CPLD drivers bindings
Date: Tue, 25 May 2021 08:46:49 +0100 [thread overview]
Message-ID: <20210525074649.GC4005783@dell> (raw)
In-Reply-To: <20210524230940.GA1350504@robh.at.kernel.org>
On Mon, 24 May 2021, Rob Herring wrote:
> On Mon, May 24, 2021 at 02:05:38PM +0200, Robert Marko wrote:
> > Add binding documents for the Delta TN48M CPLD drivers.
> >
> > Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> > ---
> > Changes in v2:
> > * Implement MFD as a simple I2C MFD
> > * Add GPIO bindings as separate
>
> I don't understand why this changed. This doesn't look like an MFD to
> me. Make your binding complete if there are missing functions.
> Otherwise, stick with what I already ok'ed.
Right. What else, besides GPIO, does this do?
> > .../bindings/gpio/delta,tn48m-gpio.yaml | 42 ++++++++++
> > .../bindings/mfd/delta,tn48m-cpld.yaml | 81 +++++++++++++++++++
> > 2 files changed, 123 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/gpio/delta,tn48m-gpio.yaml
> > create mode 100644 Documentation/devicetree/bindings/mfd/delta,tn48m-cpld.yaml
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2021-05-25 7:46 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 12:05 [PATCH v2 1/4] mfd: simple-mfd-i2c: Add Delta TN48M CPLD support Robert Marko
2021-05-24 12:05 ` [PATCH v2 2/4] gpio: Add Delta TN48M CPLD GPIO driver Robert Marko
2021-05-24 12:44 ` Andy Shevchenko
2021-05-25 14:41 ` Bartosz Golaszewski
2021-05-28 0:37 ` Linus Walleij
2021-05-24 12:05 ` [PATCH v2 3/4] dt-bindings: mfd: Add Delta TN48M CPLD drivers bindings Robert Marko
2021-05-24 23:09 ` Rob Herring
2021-05-25 7:46 ` Lee Jones [this message]
2021-05-25 9:34 ` Robert Marko
2021-05-26 7:52 ` Lee Jones
2021-05-31 8:42 ` Robert Marko
2021-06-01 8:19 ` Lee Jones
2021-06-01 8:22 ` Lee Jones
2021-06-01 9:10 ` Robert Marko
2021-06-01 9:31 ` Lee Jones
2021-06-01 10:09 ` Robert Marko
2021-06-01 9:06 ` Robert Marko
2021-06-01 9:12 ` Lee Jones
2021-06-01 13:54 ` Michael Walle
2021-06-01 13:57 ` Robert Marko
2021-06-01 13:58 ` Lee Jones
2021-06-01 14:48 ` Lee Jones
2021-06-02 9:12 ` Robert Marko
2021-06-02 10:03 ` Lee Jones
2021-06-02 10:22 ` Michael Walle
2021-06-02 10:44 ` Lee Jones
2021-05-25 9:46 ` Robert Marko
2021-05-25 21:43 ` Rob Herring
2021-05-31 13:08 ` Robert Marko
2021-05-24 12:05 ` [PATCH v2 4/4] MAINTAINERS: Add Delta Networks TN48M CPLD drivers Robert Marko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210525074649.GC4005783@dell \
--to=lee.jones@linaro.org \
--cc=bgolaszewski@baylibre.com \
--cc=buczek@molgen.mpg.de \
--cc=devicetree@vger.kernel.org \
--cc=jmp@epiphyte.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luka.perkov@sartura.hr \
--cc=pmenzel@molgen.mpg.de \
--cc=robert.marko@sartura.hr \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).