* [PATCH] platform/x86: thinkpad_acpi: add X1 Carbon Gen 9 second fan support
@ 2021-05-25 15:09 Til Jasper Ullrich
2021-05-27 9:23 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Til Jasper Ullrich @ 2021-05-25 15:09 UTC (permalink / raw)
To: Henrique de Moraes Holschuh
Cc: Hans de Goede, Mark Gross, ibm-acpi-devel, platform-driver-x86,
linux-kernel
The X1 Carbon Gen 9 uses two fans instead of one like the previous
generation. This adds support for the second fan. It has been tested
on my X1 Carbon Gen 9 (20XXS00100) and works fine.
Signed-off-by: Til Jasper Ullrich <tju@tju.me>
---
drivers/platform/x86/thinkpad_acpi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index dd60c9397d35..edd71e744d27 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -8853,6 +8853,7 @@ static const struct tpacpi_quirk fan_quirk_table[] __initconst = {
TPACPI_Q_LNV3('N', '2', 'O', TPACPI_FAN_2CTL), /* P1 / X1 Extreme (2nd gen) */
TPACPI_Q_LNV3('N', '2', 'V', TPACPI_FAN_2CTL), /* P1 / X1 Extreme (3nd gen) */
TPACPI_Q_LNV3('N', '3', '0', TPACPI_FAN_2CTL), /* P15 (1st gen) / P15v (1st gen) */
+ TPACPI_Q_LNV3('N', '3', '2', TPACPI_FAN_2CTL), /* X1 Carbon (9th gen) */
};
static int __init fan_init(struct ibm_init_struct *iibm)
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] platform/x86: thinkpad_acpi: add X1 Carbon Gen 9 second fan support
2021-05-25 15:09 [PATCH] platform/x86: thinkpad_acpi: add X1 Carbon Gen 9 second fan support Til Jasper Ullrich
@ 2021-05-27 9:23 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2021-05-27 9:23 UTC (permalink / raw)
To: Til Jasper Ullrich, Henrique de Moraes Holschuh
Cc: Mark Gross, ibm-acpi-devel, platform-driver-x86, linux-kernel
Hi,
On 5/25/21 5:09 PM, Til Jasper Ullrich wrote:
> The X1 Carbon Gen 9 uses two fans instead of one like the previous
> generation. This adds support for the second fan. It has been tested
> on my X1 Carbon Gen 9 (20XXS00100) and works fine.
>
> Signed-off-by: Til Jasper Ullrich <tju@tju.me>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
I'll also cherry-pick this into the fixes branch so that it will
be included in my next pdx86/fixes pull-req for 5.13.
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> drivers/platform/x86/thinkpad_acpi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index dd60c9397d35..edd71e744d27 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -8853,6 +8853,7 @@ static const struct tpacpi_quirk fan_quirk_table[] __initconst = {
> TPACPI_Q_LNV3('N', '2', 'O', TPACPI_FAN_2CTL), /* P1 / X1 Extreme (2nd gen) */
> TPACPI_Q_LNV3('N', '2', 'V', TPACPI_FAN_2CTL), /* P1 / X1 Extreme (3nd gen) */
> TPACPI_Q_LNV3('N', '3', '0', TPACPI_FAN_2CTL), /* P15 (1st gen) / P15v (1st gen) */
> + TPACPI_Q_LNV3('N', '3', '2', TPACPI_FAN_2CTL), /* X1 Carbon (9th gen) */
> };
>
> static int __init fan_init(struct ibm_init_struct *iibm)
> --
> 2.31.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-27 9:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-25 15:09 [PATCH] platform/x86: thinkpad_acpi: add X1 Carbon Gen 9 second fan support Til Jasper Ullrich
2021-05-27 9:23 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).