* [PATCH] use local variables ei instead of invoking function EXT4_I
@ 2021-05-26 5:29 chenyichong
2021-05-27 2:49 ` riteshh
2021-06-17 20:23 ` Theodore Ts'o
0 siblings, 2 replies; 3+ messages in thread
From: chenyichong @ 2021-05-26 5:29 UTC (permalink / raw)
To: tytso, adilger.kernel; +Cc: linux-ext4, linux-kernel, chenyichong
Signed-off-by: chenyichong <chenyichong@uniontech.com>
---
fs/ext4/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index fe6045a46599..a5c4cd1c757b 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -374,7 +374,7 @@ void ext4_da_update_reserve_space(struct inode *inode,
ei->i_reserved_data_blocks -= used;
percpu_counter_sub(&sbi->s_dirtyclusters_counter, used);
- spin_unlock(&EXT4_I(inode)->i_block_reservation_lock);
+ spin_unlock(&ei->i_block_reservation_lock);
/* Update quota subsystem for data blocks */
if (quota_claim)
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] use local variables ei instead of invoking function EXT4_I
2021-05-26 5:29 [PATCH] use local variables ei instead of invoking function EXT4_I chenyichong
@ 2021-05-27 2:49 ` riteshh
2021-06-17 20:23 ` Theodore Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: riteshh @ 2021-05-27 2:49 UTC (permalink / raw)
To: chenyichong; +Cc: tytso, adilger.kernel, linux-ext4, linux-kernel
On 21/05/26 01:29PM, chenyichong wrote:
Thanks for the patch. Looks good to me.
Feel free to add
Reviewed-by: Ritesh Harjani <riteshh@linux.ibm.com>
> Signed-off-by: chenyichong <chenyichong@uniontech.com>
> ---
> fs/ext4/inode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index fe6045a46599..a5c4cd1c757b 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -374,7 +374,7 @@ void ext4_da_update_reserve_space(struct inode *inode,
> ei->i_reserved_data_blocks -= used;
> percpu_counter_sub(&sbi->s_dirtyclusters_counter, used);
>
> - spin_unlock(&EXT4_I(inode)->i_block_reservation_lock);
> + spin_unlock(&ei->i_block_reservation_lock);
>
> /* Update quota subsystem for data blocks */
> if (quota_claim)
> --
> 2.20.1
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] use local variables ei instead of invoking function EXT4_I
2021-05-26 5:29 [PATCH] use local variables ei instead of invoking function EXT4_I chenyichong
2021-05-27 2:49 ` riteshh
@ 2021-06-17 20:23 ` Theodore Ts'o
1 sibling, 0 replies; 3+ messages in thread
From: Theodore Ts'o @ 2021-06-17 20:23 UTC (permalink / raw)
To: chenyichong; +Cc: adilger.kernel, linux-ext4, linux-kernel
On Wed, May 26, 2021 at 01:29:30PM +0800, chenyichong wrote:
> Signed-off-by: chenyichong <chenyichong@uniontech.com>
Applied, thanks.
- Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-17 20:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-26 5:29 [PATCH] use local variables ei instead of invoking function EXT4_I chenyichong
2021-05-27 2:49 ` riteshh
2021-06-17 20:23 ` Theodore Ts'o
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).