From: Viresh Kumar <viresh.kumar@linaro.org>
To: Vincent Donnefort <vincent.donnefort@arm.com>
Cc: peterz@infradead.org, rjw@rjwysocki.net,
vincent.guittot@linaro.org, qperret@google.com,
linux-kernel@vger.kernel.org, ionela.voinescu@arm.com,
lukasz.luba@arm.com, dietmar.eggemann@arm.com
Subject: Re: [PATCH v2 0/3] EM / PM: Inefficient OPPs
Date: Wed, 26 May 2021 15:09:22 +0530 [thread overview]
Message-ID: <20210526093922.txvxxgl7yvpz27iu@vireshk-i7> (raw)
In-Reply-To: <20210526093807.sih5y4lgltsz3r74@vireshk-i7>
On 26-05-21, 15:08, Viresh Kumar wrote:
> On 26-05-21, 10:01, Vincent Donnefort wrote:
> > I originally considered to add the inefficient knowledge into the CPUFreq table.
>
> I wasn't talking about the cpufreq table here in the beginning, but calling
> dev_pm_opp_disable(), which will eventually reflect in cpufreq table as well.
>
> > But I then gave up the idea for two reasons:
> >
> > * The EM depends on having schedutil enabled. I don't think that any
> > other governor would then manage to rely on the inefficient OPPs. (also I
> > believe Peter had a plan to keep schedutil as the one and only governor)
>
> Right, that EM is only there for schedutil.
>
> I would encourage if this can be done even without the EM dependency, if
> possible. It would be a good thing to do generally for any driver that wants to
> do that.
Another benefit of course is that we will have less work to do in the hotpath,
it was obvious, but I thought of stating it anyway :)
--
viresh
next prev parent reply other threads:[~2021-05-26 9:39 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 16:54 [PATCH v2 0/3] EM / PM: Inefficient OPPs Vincent Donnefort
2021-05-21 16:54 ` [PATCH v2 1/3] PM / EM: Fix inefficient state detection Vincent Donnefort
2021-05-24 12:41 ` Lukasz Luba
2021-05-25 9:50 ` Quentin Perret
2021-05-21 16:54 ` [PATCH v2 2/3] PM / EM: Extend em_perf_domain with a flag field Vincent Donnefort
2021-05-24 12:44 ` Lukasz Luba
2021-05-25 9:54 ` Quentin Perret
2021-05-21 16:54 ` [PATCH v2 3/3] PM / EM: Skip inefficient OPPs Vincent Donnefort
2021-05-24 12:55 ` Lukasz Luba
2021-05-25 8:48 ` Peter Zijlstra
2021-05-25 9:21 ` Vincent Donnefort
2021-05-25 10:00 ` Vincent Donnefort
2021-05-28 5:09 ` Viresh Kumar
2021-06-01 8:47 ` Vincent Donnefort
2021-06-01 8:56 ` Viresh Kumar
2021-06-01 9:07 ` Quentin Perret
2021-06-01 9:13 ` Viresh Kumar
2021-05-25 9:33 ` Quentin Perret
2021-05-25 9:46 ` Vincent Donnefort
2021-05-25 11:03 ` Lukasz Luba
2021-05-25 13:06 ` Quentin Perret
2021-05-25 13:34 ` Lukasz Luba
2021-05-25 9:47 ` Vincent Donnefort
2021-05-28 5:04 ` Viresh Kumar
2021-05-28 9:00 ` Lukasz Luba
2021-05-26 3:47 ` [PATCH v2 0/3] EM / PM: Inefficient OPPs Viresh Kumar
2021-05-26 8:56 ` Lukasz Luba
2021-05-26 9:33 ` Viresh Kumar
2021-05-27 7:13 ` Lukasz Luba
2021-05-26 9:01 ` Vincent Donnefort
2021-05-26 9:38 ` Viresh Kumar
2021-05-26 9:39 ` Viresh Kumar [this message]
2021-05-26 10:24 ` Lukasz Luba
2021-05-26 10:39 ` Lukasz Luba
2021-05-26 11:50 ` Lukasz Luba
2021-05-26 13:49 ` Vincent Donnefort
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210526093922.txvxxgl7yvpz27iu@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=dietmar.eggemann@arm.com \
--cc=ionela.voinescu@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=peterz@infradead.org \
--cc=qperret@google.com \
--cc=rjw@rjwysocki.net \
--cc=vincent.donnefort@arm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).