From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Lee Jones <lee.jones@linaro.org>,
Support Opensource <support.opensource@diasemi.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Tony Lindgren <tony@atomide.com>,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-omap@vger.kernel.org, patches@opensource.cirrus.com
Subject: [RESEND PATCH v2 10/13] mfd: sec: Remove unused device_type in platform data
Date: Wed, 26 May 2021 08:47:08 -0400 [thread overview]
Message-ID: <20210526124711.33223-11-krzysztof.kozlowski@canonical.com> (raw)
In-Reply-To: <20210526124711.33223-1-krzysztof.kozlowski@canonical.com>
The 'device_type' field of platform data structure is not used and can
be safely dropped.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
---
drivers/mfd/sec-core.c | 5 +----
include/linux/mfd/samsung/core.h | 1 -
2 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c
index 653d02b98d53..4c4db3171ce6 100644
--- a/drivers/mfd/sec-core.c
+++ b/drivers/mfd/sec-core.c
@@ -318,7 +318,6 @@ static int sec_pmic_probe(struct i2c_client *i2c,
struct sec_platform_data *pdata;
const struct mfd_cell *sec_devs;
struct sec_pmic_dev *sec_pmic;
- unsigned long device_type;
int ret, num_sec_devs;
sec_pmic = devm_kzalloc(&i2c->dev, sizeof(struct sec_pmic_dev),
@@ -330,16 +329,14 @@ static int sec_pmic_probe(struct i2c_client *i2c,
sec_pmic->dev = &i2c->dev;
sec_pmic->i2c = i2c;
sec_pmic->irq = i2c->irq;
- device_type = (unsigned long)of_device_get_match_data(sec_pmic->dev);
pdata = sec_pmic_i2c_parse_dt_pdata(sec_pmic->dev);
if (IS_ERR(pdata)) {
ret = PTR_ERR(pdata);
return ret;
}
- pdata->device_type = device_type;
- sec_pmic->device_type = pdata->device_type;
+ sec_pmic->device_type = (unsigned long)of_device_get_match_data(sec_pmic->dev);
sec_pmic->irq_base = pdata->irq_base;
sec_pmic->wakeup = pdata->wakeup;
sec_pmic->pdata = pdata;
diff --git a/include/linux/mfd/samsung/core.h b/include/linux/mfd/samsung/core.h
index 68afc2b97a41..bfde1b7c6303 100644
--- a/include/linux/mfd/samsung/core.h
+++ b/include/linux/mfd/samsung/core.h
@@ -81,7 +81,6 @@ int sec_irq_resume(struct sec_pmic_dev *sec_pmic);
struct sec_platform_data {
struct sec_regulator_data *regulators;
struct sec_opmode_data *opmode;
- int device_type;
int num_regulators;
int irq_base;
--
2.27.0
next prev parent reply other threads:[~2021-05-26 12:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 12:46 [RESEND PATCH v2 00/13] Simplify + drop board file support for Samsung PMIC Krzysztof Kozlowski
2021-05-26 12:46 ` [RESEND PATCH v2 01/13] mfd: max8997: Simplify getting of_device_id match data Krzysztof Kozlowski
2021-05-26 12:47 ` [RESEND PATCH v2 02/13] mfd: max8998: " Krzysztof Kozlowski
2021-05-26 12:47 ` [RESEND PATCH v2 03/13] mfd: da9052: " Krzysztof Kozlowski
2021-05-26 12:47 ` [RESEND PATCH v2 04/13] mfd: da9062: " Krzysztof Kozlowski
2021-05-26 12:47 ` [RESEND PATCH v2 05/13] mfd: sec: " Krzysztof Kozlowski
2021-05-26 12:47 ` [RESEND PATCH v2 06/13] mfd: wm831x: Correct kerneldoc Krzysztof Kozlowski
2021-05-26 14:49 ` Lee Jones
2021-05-26 12:47 ` [RESEND PATCH v2 07/13] mfd: twl: " Krzysztof Kozlowski
2021-05-26 14:49 ` Lee Jones
2021-05-26 12:47 ` [RESEND PATCH v2 08/13] mfd: sec: Drop support for board files and require devicetree Krzysztof Kozlowski
2021-05-26 12:47 ` [RESEND PATCH v2 09/13] mfd: sec: Remove unused cfg_pmic_irq in platform data Krzysztof Kozlowski
2021-05-26 12:47 ` Krzysztof Kozlowski [this message]
2021-05-26 12:47 ` [RESEND PATCH v2 11/13] mfd: sec: Remove unused irq_base " Krzysztof Kozlowski
2021-05-26 12:47 ` [RESEND PATCH v2 12/13] mfd: sec: Enable wakeup from suspend via devicetree property Krzysztof Kozlowski
2021-05-26 12:47 ` [RESEND PATCH v2 13/13] mfd: sec: Remove unused platform data members Krzysztof Kozlowski
2021-06-01 15:28 ` [RESEND PATCH v2 00/13] Simplify + drop board file support for Samsung PMIC Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210526124711.33223-11-krzysztof.kozlowski@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=b.zolnierkie@samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=support.opensource@diasemi.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).