From: Lee Jones <lee.jones@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Support Opensource <support.opensource@diasemi.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Tony Lindgren <tony@atomide.com>,
linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-omap@vger.kernel.org, patches@opensource.cirrus.com,
Charles Keepax <ckeepax@opensource.cirrus.com>
Subject: Re: [RESEND PATCH v2 06/13] mfd: wm831x: Correct kerneldoc
Date: Wed, 26 May 2021 15:49:07 +0100 [thread overview]
Message-ID: <20210526144907.GC543307@dell> (raw)
In-Reply-To: <20210526124711.33223-7-krzysztof.kozlowski@canonical.com>
On Wed, 26 May 2021, Krzysztof Kozlowski wrote:
65;6200;1c
> Correct kerneldoc function name to fix W=1 warning:
>
> drivers/mfd/wm831x-core.c:121: warning:
> expecting prototype for wm831x_reg_unlock(). Prototype was for wm831x_reg_lock() instead
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
>
> ---
>
> Changes since v1:
> 1. Add Ack
> ---
> drivers/mfd/wm831x-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This one has been fixed already:
https://lore.kernel.org/lkml/20210520120820.3465562-2-lee.jones@linaro.org/
> diff --git a/drivers/mfd/wm831x-core.c b/drivers/mfd/wm831x-core.c
> index bcef08f58fb3..c31809b17547 100644
> --- a/drivers/mfd/wm831x-core.c
> +++ b/drivers/mfd/wm831x-core.c
> @@ -109,7 +109,7 @@ static int wm831x_reg_locked(struct wm831x *wm831x, unsigned short reg)
> }
>
> /**
> - * wm831x_reg_unlock: Unlock user keyed registers
> + * wm831x_reg_lock: Unlock user keyed registers
> *
> * The WM831x has a user key preventing writes to particularly
> * critical registers. This function locks those registers,
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2021-05-26 14:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 12:46 [RESEND PATCH v2 00/13] Simplify + drop board file support for Samsung PMIC Krzysztof Kozlowski
2021-05-26 12:46 ` [RESEND PATCH v2 01/13] mfd: max8997: Simplify getting of_device_id match data Krzysztof Kozlowski
2021-05-26 12:47 ` [RESEND PATCH v2 02/13] mfd: max8998: " Krzysztof Kozlowski
2021-05-26 12:47 ` [RESEND PATCH v2 03/13] mfd: da9052: " Krzysztof Kozlowski
2021-05-26 12:47 ` [RESEND PATCH v2 04/13] mfd: da9062: " Krzysztof Kozlowski
2021-05-26 12:47 ` [RESEND PATCH v2 05/13] mfd: sec: " Krzysztof Kozlowski
2021-05-26 12:47 ` [RESEND PATCH v2 06/13] mfd: wm831x: Correct kerneldoc Krzysztof Kozlowski
2021-05-26 14:49 ` Lee Jones [this message]
2021-05-26 12:47 ` [RESEND PATCH v2 07/13] mfd: twl: " Krzysztof Kozlowski
2021-05-26 14:49 ` Lee Jones
2021-05-26 12:47 ` [RESEND PATCH v2 08/13] mfd: sec: Drop support for board files and require devicetree Krzysztof Kozlowski
2021-05-26 12:47 ` [RESEND PATCH v2 09/13] mfd: sec: Remove unused cfg_pmic_irq in platform data Krzysztof Kozlowski
2021-05-26 12:47 ` [RESEND PATCH v2 10/13] mfd: sec: Remove unused device_type " Krzysztof Kozlowski
2021-05-26 12:47 ` [RESEND PATCH v2 11/13] mfd: sec: Remove unused irq_base " Krzysztof Kozlowski
2021-05-26 12:47 ` [RESEND PATCH v2 12/13] mfd: sec: Enable wakeup from suspend via devicetree property Krzysztof Kozlowski
2021-05-26 12:47 ` [RESEND PATCH v2 13/13] mfd: sec: Remove unused platform data members Krzysztof Kozlowski
2021-06-01 15:28 ` [RESEND PATCH v2 00/13] Simplify + drop board file support for Samsung PMIC Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210526144907.GC543307@dell \
--to=lee.jones@linaro.org \
--cc=b.zolnierkie@samsung.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=support.opensource@diasemi.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).