* [PATCH] drivers/net/sungem: Fix inconsistent indenting
@ 2021-05-26 10:24 Jiapeng Chong
2021-05-27 0:09 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Jiapeng Chong @ 2021-05-26 10:24 UTC (permalink / raw)
To: davem; +Cc: kuba, netdev, linux-kernel, Jiapeng Chong
Eliminate the follow smatch warning:
drivers/net/sungem_phy.c:412 genmii_read_link() warn: inconsistent
indenting.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
drivers/net/sungem_phy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/sungem_phy.c b/drivers/net/sungem_phy.c
index 291fa44..4daac5f 100644
--- a/drivers/net/sungem_phy.c
+++ b/drivers/net/sungem_phy.c
@@ -409,7 +409,7 @@ static int genmii_read_link(struct mii_phy *phy)
* though magic-aneg shouldn't prevent this case from occurring
*/
- return 0;
+ return 0;
}
static int generic_suspend(struct mii_phy* phy)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drivers/net/sungem: Fix inconsistent indenting
2021-05-26 10:24 [PATCH] drivers/net/sungem: Fix inconsistent indenting Jiapeng Chong
@ 2021-05-27 0:09 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2021-05-27 0:09 UTC (permalink / raw)
To: Jiapeng Chong; +Cc: davem, netdev, linux-kernel
On Wed, 26 May 2021 18:24:08 +0800 Jiapeng Chong wrote:
> Eliminate the follow smatch warning:
>
> drivers/net/sungem_phy.c:412 genmii_read_link() warn: inconsistent
> indenting.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> drivers/net/sungem_phy.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/sungem_phy.c b/drivers/net/sungem_phy.c
> index 291fa44..4daac5f 100644
> --- a/drivers/net/sungem_phy.c
> +++ b/drivers/net/sungem_phy.c
> @@ -409,7 +409,7 @@ static int genmii_read_link(struct mii_phy *phy)
> * though magic-aneg shouldn't prevent this case from occurring
> */
>
> - return 0;
> + return 0;
> }
>
> static int generic_suspend(struct mii_phy* phy)
Do you have any statistics on how many such patches we'd need to apply
to make the kernel free for such warning? If it's too many it's probably
not worth it, this patch for example has net zero effect on readability.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-27 0:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-26 10:24 [PATCH] drivers/net/sungem: Fix inconsistent indenting Jiapeng Chong
2021-05-27 0:09 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).