* [PATCH v2] MOUSE_ATARI: fix kconfig unmet dependency warning
@ 2021-05-27 0:12 Randy Dunlap
2021-05-27 6:56 ` Geert Uytterhoeven
0 siblings, 1 reply; 4+ messages in thread
From: Randy Dunlap @ 2021-05-27 0:12 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, Michael Schmitz, Roman Zippel, Geert Uytterhoeven,
Dmitry Torokhov, linux-input, linux-m68k, Michael Schmitz
Since the code for ATARI_KBD_CORE does not use drivers/input/keyboard/
code, just move ATARI_KBD_CORE to arch/m68k/Kconfig.machine to remove
this dependency.
Removes this kconfig warning:
WARNING: unmet direct dependencies detected for ATARI_KBD_CORE
Depends on [n]: !UML && INPUT [=y] && INPUT_KEYBOARD [=n]
Selected by [y]:
- MOUSE_ATARI [=y] && !UML && INPUT [=y] && INPUT_MOUSE [=y] && ATARI [=y]
Fixes: c04cb856e20a ("m68k: Atari keyboard and mouse support.")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Michael Schmitz <schmitz@debian.org>
Cc: Roman Zippel <zippel@linux-m68k.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org
Cc: linux-m68k@lists.linux-m68k.org
Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
Suggested-by: Michael Schmitz <schmitzmic@gmail.com>
---
v2: move the symbol outside of INPUT_KEYBOARD (Geert) -- all the way
to Kconfig.machine (Michael). Thanks.
arch/m68k/Kconfig.machine | 3 +++
drivers/input/keyboard/Kconfig | 3 ---
2 files changed, 3 insertions(+), 3 deletions(-)
--- linux-next-20210525.orig/arch/m68k/Kconfig.machine
+++ linux-next-20210525/arch/m68k/Kconfig.machine
@@ -25,6 +25,9 @@ config ATARI
this kernel on an Atari, say Y here and browse the material
available in <file:Documentation/m68k>; otherwise say N.
+config ATARI_KBD_CORE
+ bool
+
config MAC
bool "Macintosh support"
depends on MMU
--- linux-next-20210525.orig/drivers/input/keyboard/Kconfig
+++ linux-next-20210525/drivers/input/keyboard/Kconfig
@@ -67,9 +67,6 @@ config KEYBOARD_AMIGA
To compile this driver as a module, choose M here: the
module will be called amikbd.
-config ATARI_KBD_CORE
- bool
-
config KEYBOARD_APPLESPI
tristate "Apple SPI keyboard and trackpad"
depends on ACPI && EFI
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] MOUSE_ATARI: fix kconfig unmet dependency warning
2021-05-27 0:12 [PATCH v2] MOUSE_ATARI: fix kconfig unmet dependency warning Randy Dunlap
@ 2021-05-27 6:56 ` Geert Uytterhoeven
2021-06-02 4:15 ` Dmitry Torokhov
0 siblings, 1 reply; 4+ messages in thread
From: Geert Uytterhoeven @ 2021-05-27 6:56 UTC (permalink / raw)
To: Randy Dunlap
Cc: Linux Kernel Mailing List, Michael Schmitz, Roman Zippel,
Dmitry Torokhov, linux-input, linux-m68k, Michael Schmitz
On Thu, May 27, 2021 at 2:12 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> Since the code for ATARI_KBD_CORE does not use drivers/input/keyboard/
> code, just move ATARI_KBD_CORE to arch/m68k/Kconfig.machine to remove
> this dependency.
>
> Removes this kconfig warning:
>
> WARNING: unmet direct dependencies detected for ATARI_KBD_CORE
> Depends on [n]: !UML && INPUT [=y] && INPUT_KEYBOARD [=n]
> Selected by [y]:
> - MOUSE_ATARI [=y] && !UML && INPUT [=y] && INPUT_MOUSE [=y] && ATARI [=y]
>
> Fixes: c04cb856e20a ("m68k: Atari keyboard and mouse support.")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Michael Schmitz <schmitz@debian.org>
> Cc: Roman Zippel <zippel@linux-m68k.org>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: linux-input@vger.kernel.org
> Cc: linux-m68k@lists.linux-m68k.org
> Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Suggested-by: Michael Schmitz <schmitzmic@gmail.com>
> ---
> v2: move the symbol outside of INPUT_KEYBOARD (Geert) -- all the way
> to Kconfig.machine (Michael). Thanks.
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
I'm willing to queue this in the m68k for-v5.14 branch, if Dmitry agrees.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] MOUSE_ATARI: fix kconfig unmet dependency warning
2021-05-27 6:56 ` Geert Uytterhoeven
@ 2021-06-02 4:15 ` Dmitry Torokhov
2021-06-07 14:36 ` Geert Uytterhoeven
0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Torokhov @ 2021-06-02 4:15 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Randy Dunlap, Linux Kernel Mailing List, Michael Schmitz,
Roman Zippel, linux-input, linux-m68k, Michael Schmitz
On Thu, May 27, 2021 at 08:56:30AM +0200, Geert Uytterhoeven wrote:
> On Thu, May 27, 2021 at 2:12 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> > Since the code for ATARI_KBD_CORE does not use drivers/input/keyboard/
> > code, just move ATARI_KBD_CORE to arch/m68k/Kconfig.machine to remove
> > this dependency.
> >
> > Removes this kconfig warning:
> >
> > WARNING: unmet direct dependencies detected for ATARI_KBD_CORE
> > Depends on [n]: !UML && INPUT [=y] && INPUT_KEYBOARD [=n]
> > Selected by [y]:
> > - MOUSE_ATARI [=y] && !UML && INPUT [=y] && INPUT_MOUSE [=y] && ATARI [=y]
> >
> > Fixes: c04cb856e20a ("m68k: Atari keyboard and mouse support.")
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > Cc: Michael Schmitz <schmitz@debian.org>
> > Cc: Roman Zippel <zippel@linux-m68k.org>
> > Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > Cc: linux-input@vger.kernel.org
> > Cc: linux-m68k@lists.linux-m68k.org
> > Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > Suggested-by: Michael Schmitz <schmitzmic@gmail.com>
>
> > ---
> > v2: move the symbol outside of INPUT_KEYBOARD (Geert) -- all the way
> > to Kconfig.machine (Michael). Thanks.
>
> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
> I'm willing to queue this in the m68k for-v5.14 branch, if Dmitry agrees.
Sure, works for me.
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Thanks.
--
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] MOUSE_ATARI: fix kconfig unmet dependency warning
2021-06-02 4:15 ` Dmitry Torokhov
@ 2021-06-07 14:36 ` Geert Uytterhoeven
0 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2021-06-07 14:36 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: Randy Dunlap, Linux Kernel Mailing List, Michael Schmitz,
Roman Zippel, linux-input, linux-m68k, Michael Schmitz
Hi Dmitry,
On Wed, Jun 2, 2021 at 6:15 AM Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> On Thu, May 27, 2021 at 08:56:30AM +0200, Geert Uytterhoeven wrote:
> > On Thu, May 27, 2021 at 2:12 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> > > Since the code for ATARI_KBD_CORE does not use drivers/input/keyboard/
> > > code, just move ATARI_KBD_CORE to arch/m68k/Kconfig.machine to remove
> > > this dependency.
> > >
> > > Removes this kconfig warning:
> > >
> > > WARNING: unmet direct dependencies detected for ATARI_KBD_CORE
> > > Depends on [n]: !UML && INPUT [=y] && INPUT_KEYBOARD [=n]
> > > Selected by [y]:
> > > - MOUSE_ATARI [=y] && !UML && INPUT [=y] && INPUT_MOUSE [=y] && ATARI [=y]
> > >
> > > Fixes: c04cb856e20a ("m68k: Atari keyboard and mouse support.")
> > > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > > Cc: Michael Schmitz <schmitz@debian.org>
> > > Cc: Roman Zippel <zippel@linux-m68k.org>
> > > Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> > > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > > Cc: linux-input@vger.kernel.org
> > > Cc: linux-m68k@lists.linux-m68k.org
> > > Suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > > Suggested-by: Michael Schmitz <schmitzmic@gmail.com>
> >
> > > ---
> > > v2: move the symbol outside of INPUT_KEYBOARD (Geert) -- all the way
> > > to Kconfig.machine (Michael). Thanks.
> >
> > Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
> >
> > I'm willing to queue this in the m68k for-v5.14 branch, if Dmitry agrees.
>
> Sure, works for me.
>
> Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Thanks, queue in the m68k for-v5.14 branch.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-07 14:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-27 0:12 [PATCH v2] MOUSE_ATARI: fix kconfig unmet dependency warning Randy Dunlap
2021-05-27 6:56 ` Geert Uytterhoeven
2021-06-02 4:15 ` Dmitry Torokhov
2021-06-07 14:36 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).