* [PATCH] staging: media: atomisp: pci: Remove checks before kfree/kvfree
@ 2021-05-27 19:39 Fabio M. De Francesco
2021-05-27 19:52 ` Sakari Ailus
0 siblings, 1 reply; 2+ messages in thread
From: Fabio M. De Francesco @ 2021-05-27 19:39 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Sakari Ailus, Greg Kroah-Hartman,
linux-media, linux-staging, linux-kernel
Cc: Fabio M. De Francesco
Removed checks for pointers != NULL before freeing memory. If kvfree()
and kfree() are given NULL pointers no operations are performed, so
there is no need for the above-mentioned checks. Coccinelle detected the
second of the two unnecessary checks.
Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
---
drivers/staging/media/atomisp/pci/sh_css_firmware.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/sh_css_firmware.c b/drivers/staging/media/atomisp/pci/sh_css_firmware.c
index f4ce8ace9d50..5301cc014c7e 100644
--- a/drivers/staging/media/atomisp/pci/sh_css_firmware.c
+++ b/drivers/staging/media/atomisp/pci/sh_css_firmware.c
@@ -363,10 +363,8 @@ void sh_css_unload_firmware(void)
unsigned int i = 0;
for (i = 0; i < sh_css_num_binaries; i++) {
- if (fw_minibuffer[i].name)
- kfree((void *)fw_minibuffer[i].name);
- if (fw_minibuffer[i].buffer)
- kvfree(fw_minibuffer[i].buffer);
+ kfree((void *)fw_minibuffer[i].name);
+ kvfree(fw_minibuffer[i].buffer);
}
kfree(fw_minibuffer);
fw_minibuffer = NULL;
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: media: atomisp: pci: Remove checks before kfree/kvfree
2021-05-27 19:39 [PATCH] staging: media: atomisp: pci: Remove checks before kfree/kvfree Fabio M. De Francesco
@ 2021-05-27 19:52 ` Sakari Ailus
0 siblings, 0 replies; 2+ messages in thread
From: Sakari Ailus @ 2021-05-27 19:52 UTC (permalink / raw)
To: Fabio M. De Francesco
Cc: Mauro Carvalho Chehab, Greg Kroah-Hartman, linux-media,
linux-staging, linux-kernel
On Thu, May 27, 2021 at 09:39:22PM +0200, Fabio M. De Francesco wrote:
> Removed checks for pointers != NULL before freeing memory. If kvfree()
> and kfree() are given NULL pointers no operations are performed, so
> there is no need for the above-mentioned checks. Coccinelle detected the
> second of the two unnecessary checks.
>
> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
--
Sakari Ailus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-27 19:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-27 19:39 [PATCH] staging: media: atomisp: pci: Remove checks before kfree/kvfree Fabio M. De Francesco
2021-05-27 19:52 ` Sakari Ailus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).