From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-kernel@vger.kernel.org, Pavel Machek <pavel@ucw.cz>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-leds@vger.kernel.org
Subject: Re: [PATCH 05/15] leds: leds-as3645a: Fix function name 'as3645a_set_current()'
Date: Fri, 28 May 2021 12:31:50 +0300 [thread overview]
Message-ID: <20210528093150.GN3@paasikivi.fi.intel.com> (raw)
In-Reply-To: <20210528090629.1800173-6-lee.jones@linaro.org>
Hi Lee,
On Fri, May 28, 2021 at 10:06:19AM +0100, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/leds/leds-as3645a.c:198: warning: expecting prototype for as3645a_set_config(). Prototype was for as3645a_set_current() instead
>
> Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: linux-leds@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/leds/leds-as3645a.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/leds/leds-as3645a.c b/drivers/leds/leds-as3645a.c
> index e8922fa033796..c41937ff8fd33 100644
> --- a/drivers/leds/leds-as3645a.c
> +++ b/drivers/leds/leds-as3645a.c
> @@ -185,7 +185,7 @@ static int as3645a_read(struct as3645a *flash, u8 addr)
> */
>
> /**
> - * as3645a_set_config - Set flash configuration registers
> + * as3645a_set_current - Set flash configuration registers
> * @flash: The flash
> *
> * Configure the hardware with flash, assist and indicator currents, as well as
Thanks for the patch.
The entire comment could be removed. It's wrong and doesn't really tell
more than what you can read in the two functions below (the two are result
of splitting one the documentation was written for).
--
Kind regards,
Sakari Ailus
next prev parent reply other threads:[~2021-05-28 9:31 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-28 9:06 [PATCH 00/15] Rid W=1 warnings from LED Lee Jones
2021-05-28 9:06 ` [PATCH 01/15] leds: trigger: ledtrig-cpu: Fix incorrectly documented param 'ledevt' Lee Jones
2021-05-28 10:03 ` Alexander Dahl
2021-05-28 9:06 ` [PATCH 02/15] leds: leds-gpio-register: Supply description for param 'id' Lee Jones
2021-05-28 9:41 ` Uwe Kleine-König
2021-05-28 9:55 ` Lee Jones
2021-05-28 10:35 ` Uwe Kleine-König
2021-06-01 9:05 ` Lee Jones
2021-06-02 8:24 ` Uwe Kleine-König
2021-06-02 8:33 ` Alexander Dahl
2021-06-04 5:05 ` Uwe Kleine-König
2021-05-28 9:06 ` [PATCH 03/15] leds: led-class: Fix incorrectly documented param 'dev' Lee Jones
2021-05-28 10:10 ` Alexander Dahl
2021-06-01 9:05 ` Lee Jones
2021-05-28 9:06 ` [PATCH 04/15] leds: leds-bcm6328: Demote kernel-doc abuse Lee Jones
2021-05-28 9:06 ` [PATCH 05/15] leds: leds-as3645a: Fix function name 'as3645a_set_current()' Lee Jones
2021-05-28 9:31 ` Sakari Ailus [this message]
2021-05-28 9:40 ` Pavel Machek
2021-05-28 9:55 ` Lee Jones
2021-05-28 9:06 ` [PATCH 06/15] leds: leds-blinkm: Remove unused variable 'ret' Lee Jones
2021-05-28 9:06 ` [PATCH 07/15] leds: leds-is31fl32xx: Provide missing description for member 'sw_shutdown_func' Lee Jones
2021-05-28 9:06 ` [PATCH 08/15] leds: leds-lp3944: Provide missing function names in documentation headers Lee Jones
2021-05-28 9:06 ` [PATCH 09/15] leds: leds-lm3530: Fix incorrect spelling of 'brightness' Lee Jones
2021-05-28 9:06 ` [PATCH 10/15] leds: leds-lm3692x: Fix some kernel-doc formatting issues Lee Jones
2021-05-28 9:06 ` [PATCH 11/15] leds: leds-lm3697: Provide some missing descriptions for struct members Lee Jones
2021-05-28 9:06 ` [PATCH 12/15] leds: leds-mlxreg: Fix incorrect documentation of struct member 'led_cdev' and 'led_cdev_name' Lee Jones
2021-05-28 9:06 ` [PATCH 13/15] leds: leds-lp8860: Fix kernel-doc related formatting issues Lee Jones
2021-05-28 9:06 ` [PATCH 14/15] leds: leds-lm3692x: Demote non-complete kernel-doc Lee Jones
2021-05-28 9:39 ` Pavel Machek
2021-05-28 9:56 ` Lee Jones
2021-05-28 9:06 ` [PATCH 15/15] leds: leds-mlxcpld: Fix a bunch of kernel-doc formatting issues Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210528093150.GN3@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).