linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Dahl <ada@thorsis.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Lee Jones <lee.jones@linaro.org>, Pavel Machek <pavel@ucw.cz>,
	linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH 02/15] leds: leds-gpio-register: Supply description for param 'id'
Date: Wed, 2 Jun 2021 10:33:11 +0200	[thread overview]
Message-ID: <YLdCR9VlDgVmwK7D@ada.ifak-system.com> (raw)
In-Reply-To: <20210602082436.hdi4olxekvvbtzef@pengutronix.de>

Hello Uwe,

Am Wed, Jun 02, 2021 at 10:24:36AM +0200 schrieb Uwe Kleine-König:
> Ah, that the patch is already merged is news to me. Indeed, then fixing
> this is not sensible. My initial feedback was less than an hour after
> you sent the patch and it appeared just yesterday in next, so this
> wasn't easily noticeable for me.
> 
> Usually I'm annoyed about maintainers who don't react to patch series
> and don't apply it. Here I'm more annoyed that I was Cc:d---which I
> interpret as a request for feedback---and an hour later was already too
> late for my review reply and there was (up to today) no maintainer mail
> that the patch set was applied.

Pavel applied (part of) the series quite quickly and stated in reply
to patch 14/15:

https://lore.kernel.org/linux-leds/20210528093921.GA2209@amd/

So I was also surprised my review of two patches, one hour after
posting the series, was already too late.

This is not really motivating to review at all. ¯\_(ツ)_/¯

Greets
Alex


  reply	other threads:[~2021-06-02  8:33 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-28  9:06 [PATCH 00/15] Rid W=1 warnings from LED Lee Jones
2021-05-28  9:06 ` [PATCH 01/15] leds: trigger: ledtrig-cpu: Fix incorrectly documented param 'ledevt' Lee Jones
2021-05-28 10:03   ` Alexander Dahl
2021-05-28  9:06 ` [PATCH 02/15] leds: leds-gpio-register: Supply description for param 'id' Lee Jones
2021-05-28  9:41   ` Uwe Kleine-König
2021-05-28  9:55     ` Lee Jones
2021-05-28 10:35       ` Uwe Kleine-König
2021-06-01  9:05         ` Lee Jones
2021-06-02  8:24           ` Uwe Kleine-König
2021-06-02  8:33             ` Alexander Dahl [this message]
2021-06-04  5:05               ` Uwe Kleine-König
2021-05-28  9:06 ` [PATCH 03/15] leds: led-class: Fix incorrectly documented param 'dev' Lee Jones
2021-05-28 10:10   ` Alexander Dahl
2021-06-01  9:05     ` Lee Jones
2021-05-28  9:06 ` [PATCH 04/15] leds: leds-bcm6328: Demote kernel-doc abuse Lee Jones
2021-05-28  9:06 ` [PATCH 05/15] leds: leds-as3645a: Fix function name 'as3645a_set_current()' Lee Jones
2021-05-28  9:31   ` Sakari Ailus
2021-05-28  9:40     ` Pavel Machek
2021-05-28  9:55       ` Lee Jones
2021-05-28  9:06 ` [PATCH 06/15] leds: leds-blinkm: Remove unused variable 'ret' Lee Jones
2021-05-28  9:06 ` [PATCH 07/15] leds: leds-is31fl32xx: Provide missing description for member 'sw_shutdown_func' Lee Jones
2021-05-28  9:06 ` [PATCH 08/15] leds: leds-lp3944: Provide missing function names in documentation headers Lee Jones
2021-05-28  9:06 ` [PATCH 09/15] leds: leds-lm3530: Fix incorrect spelling of 'brightness' Lee Jones
2021-05-28  9:06 ` [PATCH 10/15] leds: leds-lm3692x: Fix some kernel-doc formatting issues Lee Jones
2021-05-28  9:06 ` [PATCH 11/15] leds: leds-lm3697: Provide some missing descriptions for struct members Lee Jones
2021-05-28  9:06 ` [PATCH 12/15] leds: leds-mlxreg: Fix incorrect documentation of struct member 'led_cdev' and 'led_cdev_name' Lee Jones
2021-05-28  9:06 ` [PATCH 13/15] leds: leds-lp8860: Fix kernel-doc related formatting issues Lee Jones
2021-05-28  9:06 ` [PATCH 14/15] leds: leds-lm3692x: Demote non-complete kernel-doc Lee Jones
2021-05-28  9:39   ` Pavel Machek
2021-05-28  9:56     ` Lee Jones
2021-05-28  9:06 ` [PATCH 15/15] leds: leds-mlxcpld: Fix a bunch of kernel-doc formatting issues Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YLdCR9VlDgVmwK7D@ada.ifak-system.com \
    --to=ada@thorsis.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).