From: Lee Jones <lee.jones@linaro.org>
To: Robert Marko <robert.marko@sartura.hr>
Cc: linux-kernel@vger.kernel.org, linus.walleij@linaro.org,
bgolaszewski@baylibre.com, linux-gpio@vger.kernel.org,
p.zabel@pengutronix.de, robh+dt@kernel.org,
devicetree@vger.kernel.org, luka.perkov@sartura.hr,
jmp@epiphyte.org, pmenzel@molgen.mpg.de, buczek@molgen.mpg.de
Subject: Re: [PATCH v3 1/6] mfd: simple-mfd-i2c: Add Delta TN48M CPLD support
Date: Tue, 1 Jun 2021 09:39:44 +0100 [thread overview]
Message-ID: <20210601083944.GW543307@dell> (raw)
In-Reply-To: <20210531125143.257622-1-robert.marko@sartura.hr>
On Mon, 31 May 2021, Robert Marko wrote:
> Delta TN48M switches have a Lattice CPLD that serves
> multiple purposes including being a GPIO expander.
>
> So, lets use the simple I2C MFD driver to provide the MFD core.
>
> Also add a virtual symbol which pulls in the simple-mfd-i2c driver and
> provide a common symbol on which the subdevice drivers can depend on.
>
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> ---
> Changes in v2:
> * Drop the custom MFD driver and header
> * Use simple I2C MFD driver
>
> drivers/mfd/Kconfig | 10 ++++++++++
> drivers/mfd/simple-mfd-i2c.c | 1 +
> 2 files changed, 11 insertions(+)
I responded to a previous version of this.
The question still remains - why do you need one single Regmap
encompassing all functionality. The register banks look separated to
me at first glance.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2021-06-01 8:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 12:51 [PATCH v3 1/6] mfd: simple-mfd-i2c: Add Delta TN48M CPLD support Robert Marko
2021-05-31 12:51 ` [PATCH v3 2/6] gpio: Add Delta TN48M CPLD GPIO driver Robert Marko
2021-05-31 12:51 ` [PATCH v3 3/6] dt-bindings: reset: Add Delta TN48M Robert Marko
2021-05-31 12:51 ` [PATCH v3 4/6] reset: Add Delta TN48M CPLD reset controller Robert Marko
2021-06-01 15:38 ` Philipp Zabel
2021-06-01 17:09 ` Robert Marko
2021-06-02 8:47 ` Philipp Zabel
2021-06-02 11:48 ` Robert Marko
2021-05-31 12:51 ` [PATCH v3 5/6] dt-bindings: mfd: Add Delta TN48M CPLD drivers bindings Robert Marko
2021-06-02 10:47 ` Lee Jones
2021-06-02 10:54 ` Robert Marko
2021-05-31 12:51 ` [PATCH v3 6/6] MAINTAINERS: Add Delta Networks TN48M CPLD drivers Robert Marko
2021-06-01 8:39 ` Lee Jones [this message]
2021-06-01 9:12 ` [PATCH v3 1/6] mfd: simple-mfd-i2c: Add Delta TN48M CPLD support Robert Marko
2021-06-02 10:49 ` Lee Jones
2021-06-02 11:53 ` Robert Marko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210601083944.GW543307@dell \
--to=lee.jones@linaro.org \
--cc=bgolaszewski@baylibre.com \
--cc=buczek@molgen.mpg.de \
--cc=devicetree@vger.kernel.org \
--cc=jmp@epiphyte.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luka.perkov@sartura.hr \
--cc=p.zabel@pengutronix.de \
--cc=pmenzel@molgen.mpg.de \
--cc=robert.marko@sartura.hr \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).