* [PATCH] vdpa: fix error return in vp_vdpa_probe()
@ 2021-06-01 8:05 Jing Xiangfeng
2021-06-01 10:28 ` Eli Cohen
0 siblings, 1 reply; 2+ messages in thread
From: Jing Xiangfeng @ 2021-06-01 8:05 UTC (permalink / raw)
To: mst, jasowang, elic, sgarzare; +Cc: virtualization, linux-kernel, jingxiangfeng
Fix to return error code '-ENOMEM' from the error handling case instead
of 0.
Fixes: 11d8ffed00b2 ("vp_vdpa: switch to use vp_modern_map_vq_notify()")
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
---
drivers/vdpa/virtio_pci/vp_vdpa.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/vdpa/virtio_pci/vp_vdpa.c b/drivers/vdpa/virtio_pci/vp_vdpa.c
index c76ebb531212..e5d92db728d3 100644
--- a/drivers/vdpa/virtio_pci/vp_vdpa.c
+++ b/drivers/vdpa/virtio_pci/vp_vdpa.c
@@ -442,6 +442,7 @@ static int vp_vdpa_probe(struct pci_dev *pdev, const struct pci_device_id *id)
vp_modern_map_vq_notify(mdev, i,
&vp_vdpa->vring[i].notify_pa);
if (!vp_vdpa->vring[i].notify) {
+ ret = -ENOMEM;
dev_warn(&pdev->dev, "Fail to map vq notify %d\n", i);
goto err;
}
--
2.26.0.106.g9fadedd
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] vdpa: fix error return in vp_vdpa_probe()
2021-06-01 8:05 [PATCH] vdpa: fix error return in vp_vdpa_probe() Jing Xiangfeng
@ 2021-06-01 10:28 ` Eli Cohen
0 siblings, 0 replies; 2+ messages in thread
From: Eli Cohen @ 2021-06-01 10:28 UTC (permalink / raw)
To: Jing Xiangfeng; +Cc: mst, jasowang, sgarzare, virtualization, linux-kernel
On Tue, Jun 01, 2021 at 04:05:05PM +0800, Jing Xiangfeng wrote:
> Fix to return error code '-ENOMEM' from the error handling case instead
> of 0.
>
> Fixes: 11d8ffed00b2 ("vp_vdpa: switch to use vp_modern_map_vq_notify()")
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
Reviewed-by: Eli Cohen <elic@nvidia.com>
> ---
> drivers/vdpa/virtio_pci/vp_vdpa.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/vdpa/virtio_pci/vp_vdpa.c b/drivers/vdpa/virtio_pci/vp_vdpa.c
> index c76ebb531212..e5d92db728d3 100644
> --- a/drivers/vdpa/virtio_pci/vp_vdpa.c
> +++ b/drivers/vdpa/virtio_pci/vp_vdpa.c
> @@ -442,6 +442,7 @@ static int vp_vdpa_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> vp_modern_map_vq_notify(mdev, i,
> &vp_vdpa->vring[i].notify_pa);
> if (!vp_vdpa->vring[i].notify) {
> + ret = -ENOMEM;
> dev_warn(&pdev->dev, "Fail to map vq notify %d\n", i);
> goto err;
> }
> --
> 2.26.0.106.g9fadedd
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-01 10:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-01 8:05 [PATCH] vdpa: fix error return in vp_vdpa_probe() Jing Xiangfeng
2021-06-01 10:28 ` Eli Cohen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).