* [PATCH -next] scsi: bfa: Remove unneeded if-null-free check
@ 2021-06-01 14:19 Zheng Yongjun
0 siblings, 0 replies; only message in thread
From: Zheng Yongjun @ 2021-06-01 14:19 UTC (permalink / raw)
To: jejb, martin.petersen, linux-scsi, linux-kernel
Cc: anil.gurumurthy, sudarsana.kalluru, Zheng Yongjun
Eliminate the following coccicheck warning:
drivers/scsi/bfa/bfad_debugfs.c:375:2-7: WARNING:
NULL check before some freeing functions is not needed.
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
drivers/scsi/bfa/bfad_debugfs.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/scsi/bfa/bfad_debugfs.c b/drivers/scsi/bfa/bfad_debugfs.c
index fd1b378a263a..5e419945c6e2 100644
--- a/drivers/scsi/bfa/bfad_debugfs.c
+++ b/drivers/scsi/bfa/bfad_debugfs.c
@@ -371,9 +371,7 @@ bfad_debugfs_release_fwtrc(struct inode *inode, struct file *file)
if (!fw_debug)
return 0;
- if (fw_debug->debug_buffer)
- vfree(fw_debug->debug_buffer);
-
+ vfree(fw_debug->debug_buffer);
file->private_data = NULL;
kfree(fw_debug);
return 0;
--
2.25.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2021-06-01 14:06 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-01 14:19 [PATCH -next] scsi: bfa: Remove unneeded if-null-free check Zheng Yongjun
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).