* [PATCH -next] drm/etnaviv: Remove unneeded if-null-free check
@ 2021-06-01 14:19 Zheng Yongjun
2021-06-03 13:29 ` Christian Gmeiner
0 siblings, 1 reply; 4+ messages in thread
From: Zheng Yongjun @ 2021-06-01 14:19 UTC (permalink / raw)
To: l.stach, airlied, daniel, dri-devel, linux-kernel
Cc: linux+etnaviv, christian.gmeiner, Zheng Yongjun
Eliminate the following coccicheck warning:
drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c:84:2-8: WARNING:
NULL check before some freeing functions is not needed.
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c b/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
index b390dd4d60b7..d741b1d735f7 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
@@ -80,8 +80,7 @@ static void etnaviv_gem_prime_release(struct etnaviv_gem_object *etnaviv_obj)
/* Don't drop the pages for imported dmabuf, as they are not
* ours, just free the array we allocated:
*/
- if (etnaviv_obj->pages)
- kvfree(etnaviv_obj->pages);
+ kvfree(etnaviv_obj->pages);
drm_prime_gem_destroy(&etnaviv_obj->base, etnaviv_obj->sgt);
}
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] drm/etnaviv: Remove unneeded if-null-free check
2021-06-01 14:19 [PATCH -next] drm/etnaviv: Remove unneeded if-null-free check Zheng Yongjun
@ 2021-06-03 13:29 ` Christian Gmeiner
0 siblings, 0 replies; 4+ messages in thread
From: Christian Gmeiner @ 2021-06-03 13:29 UTC (permalink / raw)
To: Zheng Yongjun
Cc: Lucas Stach, David Airlie, Daniel Vetter, DRI mailing list, LKML,
Russell King
Am Di., 1. Juni 2021 um 16:06 Uhr schrieb Zheng Yongjun
<zhengyongjun3@huawei.com>:
>
> Eliminate the following coccicheck warning:
>
> drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c:84:2-8: WARNING:
> NULL check before some freeing functions is not needed.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com>
--
greets
--
Christian Gmeiner, MSc
https://christian-gmeiner.info/privacypolicy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] drm/etnaviv: remove unneeded if-null-free check
2021-04-09 12:22 [PATCH -next] drm/etnaviv: remove " Qiheng Lin
@ 2021-04-09 15:21 ` Christian Gmeiner
0 siblings, 0 replies; 4+ messages in thread
From: Christian Gmeiner @ 2021-04-09 15:21 UTC (permalink / raw)
To: Qiheng Lin
Cc: Lucas Stach, Russell King, David Airlie, Daniel Vetter,
The etnaviv authors, DRI mailing list, LKML
Am Fr., 9. Apr. 2021 um 14:23 Uhr schrieb Qiheng Lin <linqiheng@huawei.com>:
>
> Eliminate the following coccicheck warning:
>
> drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c:616:2-8: WARNING:
> NULL check before some freeing functions is not needed.
> drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c:618:2-8: WARNING:
> NULL check before some freeing functions is not needed.
> drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c:620:2-8: WARNING:
> NULL check before some freeing functions is not needed.
> drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c:622:2-8: WARNING:
> NULL check before some freeing functions is not needed.
>
> Signed-off-by: Qiheng Lin <linqiheng@huawei.com>
Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com>
--
greets
--
Christian Gmeiner, MSc
https://christian-gmeiner.info/privacypolicy
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH -next] drm/etnaviv: remove unneeded if-null-free check
@ 2021-04-09 12:22 Qiheng Lin
2021-04-09 15:21 ` Christian Gmeiner
0 siblings, 1 reply; 4+ messages in thread
From: Qiheng Lin @ 2021-04-09 12:22 UTC (permalink / raw)
To: l.stach, linux+etnaviv, christian.gmeiner, airlied, daniel
Cc: etnaviv, dri-devel, linux-kernel, Qiheng Lin
Eliminate the following coccicheck warning:
drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c:616:2-8: WARNING:
NULL check before some freeing functions is not needed.
drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c:618:2-8: WARNING:
NULL check before some freeing functions is not needed.
drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c:620:2-8: WARNING:
NULL check before some freeing functions is not needed.
drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c:622:2-8: WARNING:
NULL check before some freeing functions is not needed.
Signed-off-by: Qiheng Lin <linqiheng@huawei.com>
---
drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c
index d05c35994579..bd0d66ebf314 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c
@@ -612,14 +612,10 @@ int etnaviv_ioctl_gem_submit(struct drm_device *dev, void *data,
err_submit_cmds:
if (ret && (out_fence_fd >= 0))
put_unused_fd(out_fence_fd);
- if (stream)
- kvfree(stream);
- if (bos)
- kvfree(bos);
- if (relocs)
- kvfree(relocs);
- if (pmrs)
- kvfree(pmrs);
+ kvfree(stream);
+ kvfree(bos);
+ kvfree(relocs);
+ kvfree(pmrs);
return ret;
}
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-03 13:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-01 14:19 [PATCH -next] drm/etnaviv: Remove unneeded if-null-free check Zheng Yongjun
2021-06-03 13:29 ` Christian Gmeiner
-- strict thread matches above, loose matches on Subject: below --
2021-04-09 12:22 [PATCH -next] drm/etnaviv: remove " Qiheng Lin
2021-04-09 15:21 ` Christian Gmeiner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).