* [PATCH -next] ibft: Remove unneeded semicolon
@ 2021-06-01 14:21 Zheng Yongjun
2021-06-03 1:52 ` Konrad Rzeszutek Wilk
0 siblings, 1 reply; 2+ messages in thread
From: Zheng Yongjun @ 2021-06-01 14:21 UTC (permalink / raw)
To: pjones, konrad, linux-kernel; +Cc: Zheng Yongjun
Remove unneeded semicolon.
Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
---
drivers/firmware/iscsi_ibft.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/iscsi_ibft.c b/drivers/firmware/iscsi_ibft.c
index 7127a04bca19..d46da640f484 100644
--- a/drivers/firmware/iscsi_ibft.c
+++ b/drivers/firmware/iscsi_ibft.c
@@ -802,7 +802,7 @@ static void ibft_unregister(void)
ibft_kobj = boot_kobj->data;
if (ibft_kobj->hdr && ibft_kobj->hdr->id == id_nic)
sysfs_remove_link(&boot_kobj->kobj, "device");
- };
+ }
}
static void ibft_cleanup(void)
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] ibft: Remove unneeded semicolon
2021-06-01 14:21 [PATCH -next] ibft: Remove unneeded semicolon Zheng Yongjun
@ 2021-06-03 1:52 ` Konrad Rzeszutek Wilk
0 siblings, 0 replies; 2+ messages in thread
From: Konrad Rzeszutek Wilk @ 2021-06-03 1:52 UTC (permalink / raw)
To: Zheng Yongjun; +Cc: pjones, konrad, linux-kernel
On Tue, Jun 01, 2021 at 10:21:32PM +0800, Zheng Yongjun wrote:
> Remove unneeded semicolon.
Heya,
Please bear with me - but this semicolon does not seem to be hurting
anyone so not sure what bug this patch is trying to fix?
I would prefer to leave the code as is (with all its warts) unless
there are bugs or features to be added.
Thank you.
>
> Signed-off-by: Zheng Yongjun <zhengyongjun3@huawei.com>
> ---
> drivers/firmware/iscsi_ibft.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/firmware/iscsi_ibft.c b/drivers/firmware/iscsi_ibft.c
> index 7127a04bca19..d46da640f484 100644
> --- a/drivers/firmware/iscsi_ibft.c
> +++ b/drivers/firmware/iscsi_ibft.c
> @@ -802,7 +802,7 @@ static void ibft_unregister(void)
> ibft_kobj = boot_kobj->data;
> if (ibft_kobj->hdr && ibft_kobj->hdr->id == id_nic)
> sysfs_remove_link(&boot_kobj->kobj, "device");
> - };
> + }
> }
>
> static void ibft_cleanup(void)
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-03 1:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-01 14:21 [PATCH -next] ibft: Remove unneeded semicolon Zheng Yongjun
2021-06-03 1:52 ` Konrad Rzeszutek Wilk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).