linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
To: Simon Glass <sjg@chromium.org>
Cc: "Pali Rohár" <pali@kernel.org>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
	"Rob Herring" <robh@kernel.org>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Russell King" <rmk+kernel@armlinux.org.uk>,
	"Marek Behún" <kabel@kernel.org>,
	"Remi Pommarel" <repk@triplefau.lt>, Xogium <contact@xogium.me>,
	"Tomasz Maciej Nowak" <tmn505@gmail.com>,
	"Marc Zyngier" <maz@kernel.org>,
	linux-pci@vger.kernel.org,
	lak <linux-arm-kernel@lists.infradead.org>,
	lk <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 00/42] PCI: aardvark: Various driver fixes
Date: Fri, 4 Jun 2021 15:05:49 +0100	[thread overview]
Message-ID: <20210604140538.GA5204@lpieralisi> (raw)
In-Reply-To: <CAPnjgZ38G2Xzz1pTp3kCdaTZrDe+hKoBbqsGLKHyLfjUM7wH7g@mail.gmail.com>

On Thu, Jun 03, 2021 at 12:02:28PM -0600, Simon Glass wrote:
> Hi,
> 
> On Thu, 3 Jun 2021 at 09:17, Lorenzo Pieralisi
> <lorenzo.pieralisi@arm.com> wrote:
> >
> > On Thu, May 06, 2021 at 05:31:11PM +0200, Pali Rohár wrote:
> > > This patch series fixes various issues in pci-aardvark.c driver
> > > (PCIe controller on Marvell Armada 3700 SoC) used on Espressobin
> > > and Turris Mox.
> > >
> > > First patch fixes kernel panic (or TF-A panic depending on used
> > > firmware) during execution of PIO transfer and I would suggest to
> > > include this fix into v5.13 release to prevent future kernel panics.
> > >
> > > Other patches then fixes PIO issues, PCIe link training, initialization
> > > of PCIe controller, accessing PCIe Root Bridge/Port registers, handling
> > > of interrupts (including ERR and PME), setup of Multi-MSI interrupts,
> > > adding support for masking MSI interrupts, adding support for more than
> > > 32 MSI interrupts with MSI-X support, and adding support for AER.
> > >
> > > Note that there are still some unresolved issues with PCIe on A3720.
> > > I asked Marvell for PCIe documentation or explanations but I have not
> > > received anything (yet).
> > >
> > > Patch "Fix checking for PIO status" is taken from the Marvell github fork
> > > and adapted for inclusion into mainline kernel:
> > > https://github.com/MarvellEmbeddedProcessors/linux-marvell/commit/84444d22023c
> > >
> > > Whole patch series is available also in my git branch pci-aardvark:
> > > https://git.kernel.org/pub/scm/linux/kernel/git/pali/linux.git/log/?h=pci-aardvark
> > >
> > > If you have Espressobin, Turris Mox or other A3720 board with PCIe
> > > please test this patch series with your favourite PCIe card if
> > > everything is working fine.
> > >
> > > Evan Wang (1):
> > >   PCI: aardvark: Fix checking for PIO status
> > >
> > > Pali Rohár (39):
> > >   PCI: aardvark: Fix kernel panic during PIO transfer
> > >   PCI: aardvark: Fix checking for PIO Non-posted Request
> > >   PCI: aardvark: Increase polling delay to 1.5s while waiting for PIO
> > >     response
> > >   PCI: pci-bridge-emul: Add PCIe Root Capabilities Register
> > >   PCI: aardvark: Fix reporting CRS Software Visibility on emulated
> > >     bridge
> > >   PCI: aardvark: Fix link training
> > >   PCI: Add PCI_EXP_DEVCTL_PAYLOAD_* macros
> > >   PCI: aardvark: Fix PCIe Max Payload Size setting
> > >   PCI: aardvark: Implement workaround for the readback value of VEND_ID
> > >   PCI: aardvark: Do not touch status bits of masked interrupts in
> > >     interrupt handler
> > >   PCI: aardvark: Check for virq mapping when processing INTx IRQ
> > >   PCI: aardvark: Remove irq_mask_ack callback for INTx interrupts
> > >   PCI: aardvark: Don't mask irq when mapping
> > >   PCI: aardvark: Change name of INTx irq_chip to advk-INT
> > >   PCI: aardvark: Remove unneeded goto
> > >   PCI: aardvark: Fix support for MSI interrupts
> > >   PCI: aardvark: Correctly clear and unmask all MSI interrupts
> > >   PCI: aardvark: Fix setting MSI address
> > >   PCI: aardvark: Add support for more than 32 MSI interrupts
> > >   PCI: aardvark: Add support for masking MSI interrupts
> > >   PCI: aardvark: Enable MSI-X support
> > >   PCI: aardvark: Fix support for ERR interrupt on emulated bridge
> > >   PCI: aardvark: Fix support for PME on emulated bridge
> > >   PCI: aardvark: Fix support for PME requester on emulated bridge
> > >   PCI: aardvark: Fix support for bus mastering and PCI_COMMAND on
> > >     emulated bridge
> > >   PCI: aardvark: Disable bus mastering and mask all interrupts when
> > >     unbinding driver
> > >   PCI: aardvark: Free config space for emulated root bridge when
> > >     unbinding driver to fix memory leak
> > >   PCI: aardvark: Reset PCIe card and disable PHY when unbinding driver
> > >   PCI: aardvark: Rewrite irq code to chained irq handler
> > >   PCI: aardvark: Use separate INTA interrupt for emulated root bridge
> > >   PCI: pci-bridge-emul: Add description for class_revision field
> > >   PCI: pci-bridge-emul: Add definitions for missing capabilities
> > >     registers
> > >   PCI: aardvark: Add support for DEVCAP2, DEVCTL2, LNKCAP2 and LNKCTL2
> > >     registers on emulated bridge
> > >   PCI: aardvark: Add support for PCI_BRIDGE_CTL_BUS_RESET on emulated
> > >     bridge
> > >   PCI: aardvark: Replace custom PCIE_CORE_ERR_CAPCTL_* macros by
> > >     linux/pci_regs.h macros
> > >   PCI: aardvark: Replace custom PCIE_CORE_INT_* macros by linux
> > >     PCI_INTERRUPT_* values
> > >   PCI: aardvark: Cleanup some register macros
> > >   PCI: aardvark: Add comments for OB_WIN_ENABLE and ADDR_WIN_DISABLE
> > >   PCI: aardvark: Add support for Advanced Error Reporting registers on
> > >     emulated bridge
> > >
> > > Russell King (2):
> > >   PCI: pci-bridge-emul: re-arrange register tests
> > >   PCI: pci-bridge-emul: add support for PCIe extended capabilities
> > >
> > >  drivers/pci/controller/pci-aardvark.c | 980 +++++++++++++++++++-------
> > >  drivers/pci/pci-bridge-emul.c         | 149 ++--
> > >  drivers/pci/pci-bridge-emul.h         |  17 +-
> > >  include/uapi/linux/pci_regs.h         |   6 +
> > >  4 files changed, 850 insertions(+), 302 deletions(-)
> >
> > May I ask you please to split this series in smaller sets so that
> > it is easier to merge ?
> >
> > Let's start with the more urgent fixes that don't involve rework (or
> > you have not received change requests for since they are simple).
> 
> Is this due to the difficulty / time for reviewing them?

Yes.

> I feel it is a bit tough to ask someone to split a series, when it is
> already nicely split into patches. Reordering to put the important
> things first seems reasonable. Otherwise perhaps people can just
> review what they can?

Pali maintains this code, what I do is reviewing the bits of code that
are common across all PCI host controllers; it would help me to have
patches that affect common functionality (even if the changes are only
in the aardvark code) and patches that are aardvark specific to be
split, to speed up the merge.

It is easier to deal with small series but if this is just a series
containing various fixes we can leave it as it is and we go through
it one-by-one.

Lorenzo

      parent reply	other threads:[~2021-06-04 14:06 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-06 15:31 Pali Rohár
2021-05-06 15:31 ` [PATCH 01/42] PCI: aardvark: Fix kernel panic during PIO transfer Pali Rohár
2021-05-19  8:06   ` Pali Rohár
2021-05-06 15:31 ` [PATCH 02/42] PCI: aardvark: Fix checking for PIO Non-posted Request Pali Rohár
2021-05-06 15:31 ` [PATCH 03/42] PCI: aardvark: Fix checking for PIO status Pali Rohár
2021-05-06 15:31 ` [PATCH 04/42] PCI: aardvark: Increase polling delay to 1.5s while waiting for PIO response Pali Rohár
2021-05-06 15:31 ` [PATCH 05/42] PCI: pci-bridge-emul: Add PCIe Root Capabilities Register Pali Rohár
2021-05-06 23:10   ` Bjorn Helgaas
2021-05-07 14:40     ` Pali Rohár
2021-05-07 16:41       ` Bjorn Helgaas
2021-05-06 15:31 ` [PATCH 06/42] PCI: aardvark: Fix reporting CRS Software Visibility on emulated bridge Pali Rohár
2021-05-07 13:03   ` Bjorn Helgaas
2021-05-07 15:25     ` Pali Rohár
2021-05-07 15:33     ` Pali Rohár
2021-05-06 15:31 ` [PATCH 07/42] PCI: aardvark: Fix link training Pali Rohár
2021-05-06 15:31 ` [PATCH 08/42] PCI: Add PCI_EXP_DEVCTL_PAYLOAD_* macros Pali Rohár
2021-05-06 15:31 ` [PATCH 09/42] PCI: aardvark: Fix PCIe Max Payload Size setting Pali Rohár
2021-05-06 15:31 ` [PATCH 10/42] PCI: aardvark: Implement workaround for the readback value of VEND_ID Pali Rohár
2021-05-06 15:31 ` [PATCH 11/42] PCI: aardvark: Do not touch status bits of masked interrupts in interrupt handler Pali Rohár
2021-05-06 15:31 ` [PATCH 12/42] PCI: aardvark: Check for virq mapping when processing INTx IRQ Pali Rohár
2021-05-07  9:15   ` Marc Zyngier
2021-06-04 16:24     ` Pali Rohár
2021-06-04 16:29       ` Marc Zyngier
2021-05-06 15:31 ` [PATCH 13/42] PCI: aardvark: Remove irq_mask_ack callback for INTx interrupts Pali Rohár
2021-05-07  9:16   ` Marc Zyngier
2021-05-06 15:31 ` [PATCH 14/42] PCI: aardvark: Don't mask irq when mapping Pali Rohár
2021-05-07  9:20   ` Marc Zyngier
2021-05-07  9:27     ` Pali Rohár
2021-05-06 15:31 ` [PATCH 15/42] PCI: aardvark: Change name of INTx irq_chip to advk-INT Pali Rohár
2021-05-07  9:08   ` Marc Zyngier
2021-05-24 14:36     ` Marek Behún
2021-05-24 15:14       ` Marc Zyngier
2021-05-06 15:31 ` [PATCH 16/42] PCI: aardvark: Remove unneeded goto Pali Rohár
2021-05-06 15:31 ` [PATCH 17/42] PCI: aardvark: Fix support for MSI interrupts Pali Rohár
2021-05-07 10:16   ` Marc Zyngier
2021-05-07 14:44     ` Pali Rohár
2021-05-07 16:24       ` Marc Zyngier
2021-06-04 16:02         ` Pali Rohár
2021-06-04 16:22           ` Marc Zyngier
2021-05-06 15:31 ` [PATCH 18/42] PCI: aardvark: Correctly clear and unmask all " Pali Rohár
2021-05-07 10:19   ` Marc Zyngier
2021-05-07 10:21     ` Pali Rohár
2021-05-06 15:31 ` [PATCH 19/42] PCI: aardvark: Fix setting MSI address Pali Rohár
2021-05-07 10:25   ` Marc Zyngier
2021-05-06 15:31 ` [PATCH 20/42] PCI: aardvark: Add support for more than 32 MSI interrupts Pali Rohár
2021-07-02 21:35   ` Pali Rohár
2021-05-06 15:31 ` [PATCH 21/42] PCI: aardvark: Add support for masking " Pali Rohár
2021-05-06 15:31 ` [PATCH 22/42] PCI: aardvark: Enable MSI-X support Pali Rohár
2021-05-06 15:31 ` [PATCH 23/42] PCI: aardvark: Fix support for ERR interrupt on emulated bridge Pali Rohár
2021-05-06 15:31 ` [PATCH 24/42] PCI: aardvark: Fix support for PME " Pali Rohár
2021-05-06 15:31 ` [PATCH 25/42] PCI: aardvark: Fix support for PME requester " Pali Rohár
2021-05-06 15:31 ` [PATCH 26/42] PCI: aardvark: Fix support for bus mastering and PCI_COMMAND " Pali Rohár
2021-05-06 15:31 ` [PATCH 27/42] PCI: aardvark: Disable bus mastering and mask all interrupts when unbinding driver Pali Rohár
2021-05-06 15:31 ` [PATCH 28/42] PCI: aardvark: Free config space for emulated root bridge when unbinding driver to fix memory leak Pali Rohár
2021-05-06 15:31 ` [PATCH 29/42] PCI: aardvark: Reset PCIe card and disable PHY when unbinding driver Pali Rohár
2021-05-06 15:31 ` [PATCH 30/42] PCI: aardvark: Rewrite irq code to chained irq handler Pali Rohár
2021-05-06 15:31 ` [PATCH 31/42] PCI: aardvark: Use separate INTA interrupt for emulated root bridge Pali Rohár
2021-05-06 15:31 ` [PATCH 32/42] PCI: pci-bridge-emul: Add description for class_revision field Pali Rohár
2021-05-06 15:31 ` [PATCH 33/42] PCI: pci-bridge-emul: Add definitions for missing capabilities registers Pali Rohár
2021-05-06 15:31 ` [PATCH 34/42] PCI: aardvark: Add support for DEVCAP2, DEVCTL2, LNKCAP2 and LNKCTL2 registers on emulated bridge Pali Rohár
2021-05-06 15:31 ` [PATCH 35/42] PCI: aardvark: Add support for PCI_BRIDGE_CTL_BUS_RESET " Pali Rohár
2021-05-06 15:31 ` [PATCH 36/42] PCI: aardvark: Replace custom PCIE_CORE_ERR_CAPCTL_* macros by linux/pci_regs.h macros Pali Rohár
2021-05-06 15:31 ` [PATCH 37/42] PCI: aardvark: Replace custom PCIE_CORE_INT_* macros by linux PCI_INTERRUPT_* values Pali Rohár
2021-05-06 15:31 ` [PATCH 38/42] PCI: aardvark: Cleanup some register macros Pali Rohár
2021-05-06 15:31 ` [PATCH 39/42] PCI: aardvark: Add comments for OB_WIN_ENABLE and ADDR_WIN_DISABLE Pali Rohár
2021-05-06 15:31 ` [PATCH 40/42] PCI: pci-bridge-emul: re-arrange register tests Pali Rohár
2021-05-06 15:31 ` [PATCH 41/42] PCI: pci-bridge-emul: add support for PCIe extended capabilities Pali Rohár
2021-05-06 15:31 ` [PATCH 42/42] PCI: aardvark: Add support for Advanced Error Reporting registers on emulated bridge Pali Rohár
2021-06-03 15:16 ` [PATCH 00/42] PCI: aardvark: Various driver fixes Lorenzo Pieralisi
2021-06-03 17:02   ` Pali Rohár
2021-06-03 18:02   ` Simon Glass
2021-06-03 18:18     ` Pali Rohár
2021-06-04 14:05     ` Lorenzo Pieralisi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210604140538.GA5204@lpieralisi \
    --to=lorenzo.pieralisi@arm.com \
    --cc=bhelgaas@google.com \
    --cc=contact@xogium.me \
    --cc=kabel@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=pali@kernel.org \
    --cc=repk@triplefau.lt \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=robh@kernel.org \
    --cc=sjg@chromium.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=tmn505@gmail.com \
    --subject='Re: [PATCH 00/42] PCI: aardvark: Various driver fixes' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).