From: menglong8.dong@gmail.com
To: Christian Brauner <christian.brauner@ubuntu.com>
Cc: Menglong Dong <menglong8.dong@gmail.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Kees Cook <keescook@chromium.org>,
Sami Tolvanen <samitolvanen@google.com>,
johan@kernel.org, ojeda@kernel.org, jeyu@kernel.org,
masahiroy@kernel.org, joe@perches.com, Jan Kara <jack@suse.cz>,
hare@suse.de, Jens Axboe <axboe@kernel.dk>,
tj@kernel.org, gregkh@linuxfoundation.org, song@kernel.org,
NeilBrown <neilb@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Barret Rhoden <brho@google.com>,
f.fainelli@gmail.com, palmerdabbelt@google.com,
wangkefeng.wang@huawei.com,
Masami Hiramatsu <mhiramat@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
vbabka@suse.cz, Alexander Potapenko <glider@google.com>,
pmladek@suse.com, johannes.berg@intel.com,
"Eric W. Biederman" <ebiederm@xmission.com>,
jojing64@gmail.com, terrelln@fb.com, geert@linux-m68k.org,
linux-fsdevel@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Luis Chamberlain <mcgrof@kernel.org>,
arnd@arndb.de, Chris Down <chris@chrisdown.name>,
mingo@kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
Josh Triplett <josh@joshtriplett.org>
Subject: Re: [PATCH v6 2/2] init/do_mounts.c: create second mount for initramfs
Date: Mon, 7 Jun 2021 05:15:24 -0700 [thread overview]
Message-ID: <20210607121524.GB3896@www> (raw)
In-Reply-To: <20210607103147.yhniqeulw4pmvjdr@wittgenstein>
On Mon, Jun 07, 2021 at 12:31:47PM +0200, Christian Brauner wrote:
> On Sat, Jun 05, 2021 at 10:47:07PM +0800, Menglong Dong wrote:
[...]
> >
> > I think it's necessary, as I explained in the third patch. When the rootfs
> > is a block device, ramfs is used in init_mount_tree() unconditionally,
> > which can be seen from the enable of is_tmpfs.
> >
> > That makes sense, because rootfs will not become the root if a block
> > device is specified by 'root' in boot cmd, so it makes no sense to use
> > tmpfs, because ramfs is more simple.
> >
> > Here, I make rootfs as ramfs for the same reason: the first mount is not
> > used as the root, so make it ramfs which is more simple.
>
> Ok. If you don't mind I'd like to pull and test this before moving
> further. (Btw, I talked about this at Plumbers before btw.)
> What did you use for testing this? Any way you can share it?
Ok, no problem definitely. I tested this function in 3 way mainly:
1. I debug the kernel with qemu and gdb, and trace the the whole
process, to ensure that there is no abnormal situation.
2. I tested pivot_root() in initramfs and ensured that it can be
used normally. What's more, I also tested docker and ensured
container can run normally without 'DOCKER_RAMDISK=yes' set in
initramfs.
3. I tried to enable and disable CONFIG_INITRAMFS_MOUNT, and
ensured that the system can boot successfully from initramfs, initrd
and sda.
What's more, our team is going to test it comprehensively, such as
ltp, etc.
Thanks!
Menglong Dong
next prev parent reply other threads:[~2021-06-07 12:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-05 3:44 [PATCH v6 0/2] init/initramfs.c: make initramfs support pivot_root menglong8.dong
2021-06-05 3:44 ` [PATCH v6 1/2] init/main.c: introduce function ramdisk_exec_exist() menglong8.dong
2021-06-05 3:44 ` [PATCH v6 2/2] init/do_mounts.c: create second mount for initramfs menglong8.dong
2021-06-05 11:50 ` Christian Brauner
2021-06-05 14:47 ` Menglong Dong
2021-06-07 10:31 ` Christian Brauner
2021-06-07 12:15 ` menglong8.dong [this message]
2021-06-17 3:57 ` Menglong Dong
2021-06-17 14:38 ` Christian Brauner
2021-07-27 12:24 ` Menglong Dong
2021-07-27 12:37 ` Christian Brauner
2021-07-28 8:07 ` Petr Mladek
2021-07-29 13:25 ` Menglong Dong
2021-09-17 1:58 ` Menglong Dong
2021-06-09 14:03 ` [PATCH v6 0/2] init/initramfs.c: make initramfs support pivot_root Masami Hiramatsu
2021-06-10 6:36 ` Menglong Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210607121524.GB3896@www \
--to=menglong8.dong@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=bhelgaas@google.com \
--cc=brho@google.com \
--cc=chris@chrisdown.name \
--cc=christian.brauner@ubuntu.com \
--cc=ebiederm@xmission.com \
--cc=f.fainelli@gmail.com \
--cc=geert@linux-m68k.org \
--cc=glider@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hare@suse.de \
--cc=jack@suse.cz \
--cc=jeyu@kernel.org \
--cc=joe@perches.com \
--cc=johan@kernel.org \
--cc=johannes.berg@intel.com \
--cc=jojing64@gmail.com \
--cc=josh@joshtriplett.org \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=masahiroy@kernel.org \
--cc=mcgrof@kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=neilb@suse.de \
--cc=ojeda@kernel.org \
--cc=palmerdabbelt@google.com \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=samitolvanen@google.com \
--cc=song@kernel.org \
--cc=terrelln@fb.com \
--cc=tj@kernel.org \
--cc=vbabka@suse.cz \
--cc=viro@zeniv.linux.org.uk \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).