* [PATCH] net: appletalk: fix some mistakes in grammar
@ 2021-06-08 4:03 13145886936
0 siblings, 0 replies; 7+ messages in thread
From: 13145886936 @ 2021-06-08 4:03 UTC (permalink / raw)
To: davem, kuba; +Cc: netdev, linux-kernel, gushengxian
From: gushengxian <gushengxian@yulong.com>
Fix some mistakes in grammar.
Signed-off-by: gushengxian <gushengxian@yulong.com>
---
net/appletalk/ddp.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c
index ebda397fa95a..8ade5a4ceaf5 100644
--- a/net/appletalk/ddp.c
+++ b/net/appletalk/ddp.c
@@ -707,7 +707,7 @@ static int atif_ioctl(int cmd, void __user *arg)
/*
* Phase 1 is fine on LocalTalk but we don't do
- * EtherTalk phase 1. Anyone wanting to add it go ahead.
+ * EtherTalk phase 1. Anyone wanting to add it, go ahead.
*/
if (dev->type == ARPHRD_ETHER && nr->nr_phase != 2)
return -EPROTONOSUPPORT;
@@ -828,7 +828,7 @@ static int atif_ioctl(int cmd, void __user *arg)
nr = (struct atalk_netrange *)&(atif->nets);
/*
* Phase 1 is fine on Localtalk but we don't do
- * Ethertalk phase 1. Anyone wanting to add it go ahead.
+ * Ethertalk phase 1. Anyone wanting to add it, go ahead.
*/
if (dev->type == ARPHRD_ETHER && nr->nr_phase != 2)
return -EPROTONOSUPPORT;
@@ -2018,7 +2018,7 @@ module_init(atalk_init);
* by the network device layer.
*
* Ergo, before the AppleTalk module can be removed, all AppleTalk
- * sockets be closed from user space.
+ * sockets should be closed from user space.
*/
static void __exit atalk_exit(void)
{
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH] net: appletalk: fix some mistakes in grammar
@ 2021-06-09 1:52 13145886936
2021-06-09 2:30 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 7+ messages in thread
From: 13145886936 @ 2021-06-09 1:52 UTC (permalink / raw)
To: davem, kuba; +Cc: netdev, linux-kernel, gushengxian
From: gushengxian <gushengxian@yulong.com>
Fix some mistakes in grammar.
Signed-off-by: gushengxian <gushengxian@yulong.com>
---
net/appletalk/ddp.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c
index ebda397fa95a..8ade5a4ceaf5 100644
--- a/net/appletalk/ddp.c
+++ b/net/appletalk/ddp.c
@@ -707,7 +707,7 @@ static int atif_ioctl(int cmd, void __user *arg)
/*
* Phase 1 is fine on LocalTalk but we don't do
- * EtherTalk phase 1. Anyone wanting to add it go ahead.
+ * EtherTalk phase 1. Anyone wanting to add it, go ahead.
*/
if (dev->type == ARPHRD_ETHER && nr->nr_phase != 2)
return -EPROTONOSUPPORT;
@@ -828,7 +828,7 @@ static int atif_ioctl(int cmd, void __user *arg)
nr = (struct atalk_netrange *)&(atif->nets);
/*
* Phase 1 is fine on Localtalk but we don't do
- * Ethertalk phase 1. Anyone wanting to add it go ahead.
+ * Ethertalk phase 1. Anyone wanting to add it, go ahead.
*/
if (dev->type == ARPHRD_ETHER && nr->nr_phase != 2)
return -EPROTONOSUPPORT;
@@ -2018,7 +2018,7 @@ module_init(atalk_init);
* by the network device layer.
*
* Ergo, before the AppleTalk module can be removed, all AppleTalk
- * sockets be closed from user space.
+ * sockets should be closed from user space.
*/
static void __exit atalk_exit(void)
{
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] net: appletalk: fix some mistakes in grammar
2021-06-09 1:52 13145886936
@ 2021-06-09 2:30 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 7+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-06-09 2:30 UTC (permalink / raw)
To: None; +Cc: davem, kuba, netdev, linux-kernel, gushengxian
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Tue, 8 Jun 2021 18:52:57 -0700 you wrote:
> From: gushengxian <gushengxian@yulong.com>
>
> Fix some mistakes in grammar.
>
> Signed-off-by: gushengxian <gushengxian@yulong.com>
> ---
> net/appletalk/ddp.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Here is the summary with links:
- net: appletalk: fix some mistakes in grammar
https://git.kernel.org/netdev/net-next/c/2aa8eca6cbb5
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] net: appletalk: fix some mistakes in grammar
@ 2021-06-08 2:25 13145886936
2021-06-08 2:31 ` Seth David Schoen
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: 13145886936 @ 2021-06-08 2:25 UTC (permalink / raw)
To: davem, kuba; +Cc: netdev, linux-kernel, gushengxian
From: gushengxian <gushengxian@yulong.com>
Fix some mistakes in grammar.
Signed-off-by: gushengxian <gushengxian@yulong.com>
---
net/appletalk/ddp.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c
index ebda397fa95a..bc76b2fa3dfb 100644
--- a/net/appletalk/ddp.c
+++ b/net/appletalk/ddp.c
@@ -707,7 +707,7 @@ static int atif_ioctl(int cmd, void __user *arg)
/*
* Phase 1 is fine on LocalTalk but we don't do
- * EtherTalk phase 1. Anyone wanting to add it go ahead.
+ * EtherTalk phase 1. Anyone wanting to add it goes ahead.
*/
if (dev->type == ARPHRD_ETHER && nr->nr_phase != 2)
return -EPROTONOSUPPORT;
@@ -828,7 +828,7 @@ static int atif_ioctl(int cmd, void __user *arg)
nr = (struct atalk_netrange *)&(atif->nets);
/*
* Phase 1 is fine on Localtalk but we don't do
- * Ethertalk phase 1. Anyone wanting to add it go ahead.
+ * Ethertalk phase 1. Anyone wanting to add it goes ahead.
*/
if (dev->type == ARPHRD_ETHER && nr->nr_phase != 2)
return -EPROTONOSUPPORT;
@@ -2018,7 +2018,7 @@ module_init(atalk_init);
* by the network device layer.
*
* Ergo, before the AppleTalk module can be removed, all AppleTalk
- * sockets be closed from user space.
+ * sockets should be closed from user space.
*/
static void __exit atalk_exit(void)
{
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] net: appletalk: fix some mistakes in grammar
2021-06-08 2:25 13145886936
@ 2021-06-08 2:31 ` Seth David Schoen
2021-06-08 2:32 ` Joe Perches
2021-06-08 2:36 ` Randy Dunlap
2 siblings, 0 replies; 7+ messages in thread
From: Seth David Schoen @ 2021-06-08 2:31 UTC (permalink / raw)
To: 13145886936; +Cc: davem, kuba, netdev, linux-kernel, gushengxian
13145886936@163.com writes:
> * Ergo, before the AppleTalk module can be removed, all AppleTalk
> - * sockets be closed from user space.
> + * sockets should be closed from user space.
> */
This is a good correction, but in the other case
> /*
> * Phase 1 is fine on LocalTalk but we don't do
> - * EtherTalk phase 1. Anyone wanting to add it go ahead.
> + * EtherTalk phase 1. Anyone wanting to add it goes ahead.
"go ahead" is meant as an imperative (like "If you want to add EtherTalk
phase 1 support, please go ahead [and do so]"), not an indicative (like
"If you want to add EtherTalk phase 1 support, you are adding it"). It
is an invitation addressed to future developers.
Addressing unspecified people directly in the second person with "anyone"
is a little unusual, but is grammatically acceptable (more usually with a
comma). Anyone reading this, you now understand this point.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] net: appletalk: fix some mistakes in grammar
2021-06-08 2:25 13145886936
2021-06-08 2:31 ` Seth David Schoen
@ 2021-06-08 2:32 ` Joe Perches
2021-06-08 2:36 ` Randy Dunlap
2 siblings, 0 replies; 7+ messages in thread
From: Joe Perches @ 2021-06-08 2:32 UTC (permalink / raw)
To: 13145886936, davem, kuba; +Cc: netdev, linux-kernel, gushengxian
On Mon, 2021-06-07 at 19:25 -0700, 13145886936@163.com wrote:
> From: gushengxian <gushengxian@yulong.com>
>
> Fix some mistakes in grammar.
[]
> diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c
[]
> @@ -707,7 +707,7 @@ static int atif_ioctl(int cmd, void __user *arg)
>
>
> /*
> * Phase 1 is fine on LocalTalk but we don't do
> - * EtherTalk phase 1. Anyone wanting to add it go ahead.
> + * EtherTalk phase 1. Anyone wanting to add it goes ahead.
This is really not better grammar.
It's describing how anyone should feel free to create an implementation.
It's also really old code that no one will use much anymore, so any
change to this module isn't particularly useful.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] net: appletalk: fix some mistakes in grammar
2021-06-08 2:25 13145886936
2021-06-08 2:31 ` Seth David Schoen
2021-06-08 2:32 ` Joe Perches
@ 2021-06-08 2:36 ` Randy Dunlap
2 siblings, 0 replies; 7+ messages in thread
From: Randy Dunlap @ 2021-06-08 2:36 UTC (permalink / raw)
To: 13145886936, davem, kuba; +Cc: netdev, linux-kernel, gushengxian
On 6/7/21 7:25 PM, 13145886936@163.com wrote:
> From: gushengxian <gushengxian@yulong.com>
>
> Fix some mistakes in grammar.
>
> Signed-off-by: gushengxian <gushengxian@yulong.com>
> ---
> net/appletalk/ddp.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c
> index ebda397fa95a..bc76b2fa3dfb 100644
> --- a/net/appletalk/ddp.c
> +++ b/net/appletalk/ddp.c
> @@ -707,7 +707,7 @@ static int atif_ioctl(int cmd, void __user *arg)
>
> /*
> * Phase 1 is fine on LocalTalk but we don't do
> - * EtherTalk phase 1. Anyone wanting to add it go ahead.
> + * EtherTalk phase 1. Anyone wanting to add it goes ahead.
> */
> if (dev->type == ARPHRD_ETHER && nr->nr_phase != 2)
> return -EPROTONOSUPPORT;
> @@ -828,7 +828,7 @@ static int atif_ioctl(int cmd, void __user *arg)
> nr = (struct atalk_netrange *)&(atif->nets);
> /*
> * Phase 1 is fine on Localtalk but we don't do
> - * Ethertalk phase 1. Anyone wanting to add it go ahead.
> + * Ethertalk phase 1. Anyone wanting to add it goes ahead.
Nak on these 2 changes.
If anything, it could be something like:
Anyone wanting to add it, go ahead.
or
If anyone wants to add it, go ahead.
> */
> if (dev->type == ARPHRD_ETHER && nr->nr_phase != 2)
> return -EPROTONOSUPPORT;
> @@ -2018,7 +2018,7 @@ module_init(atalk_init);
> * by the network device layer.
> *
> * Ergo, before the AppleTalk module can be removed, all AppleTalk
> - * sockets be closed from user space.
> + * sockets should be closed from user space.
ok.
> */
> static void __exit atalk_exit(void)
> {
>
--
~Randy
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-06-09 2:30 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-08 4:03 [PATCH] net: appletalk: fix some mistakes in grammar 13145886936
-- strict thread matches above, loose matches on Subject: below --
2021-06-09 1:52 13145886936
2021-06-09 2:30 ` patchwork-bot+netdevbpf
2021-06-08 2:25 13145886936
2021-06-08 2:31 ` Seth David Schoen
2021-06-08 2:32 ` Joe Perches
2021-06-08 2:36 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).