* [PATCH -next v2] drm/msm: Use list_move_tail instead of list_del/list_add_tail in msm_gem.c
@ 2021-06-09 7:28 Baokun Li
2021-08-05 8:23 ` Dmitry Baryshkov
0 siblings, 1 reply; 2+ messages in thread
From: Baokun Li @ 2021-06-09 7:28 UTC (permalink / raw)
To: linux-kernel, Rob Clark, Sean Paul, David Airlie, Daniel Vetter,
Sumit Semwal, Christian König
Cc: weiyongjun1, yuehaibing, yangjihong1, yukuai3, libaokun1,
linux-arm-msm, dri-devel, freedreno, linux-media, linaro-mm-sig,
kernel-janitors, Hulk Robot
Using list_move_tail() instead of list_del() + list_add_tail() in msm_gem.c.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Baokun Li <libaokun1@huawei.com>
---
V1->V2:
CC mailist
drivers/gpu/drm/msm/msm_gem.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c
index 1865919368f2..5b7d63d3750a 100644
--- a/drivers/gpu/drm/msm/msm_gem.c
+++ b/drivers/gpu/drm/msm/msm_gem.c
@@ -854,8 +854,7 @@ void msm_gem_active_get(struct drm_gem_object *obj, struct msm_gpu *gpu)
mutex_lock(&priv->mm_lock);
if (msm_obj->evictable)
mark_unevictable(msm_obj);
- list_del(&msm_obj->mm_list);
- list_add_tail(&msm_obj->mm_list, &gpu->active_list);
+ list_move_tail(&msm_obj->mm_list, &gpu->active_list);
mutex_unlock(&priv->mm_lock);
}
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next v2] drm/msm: Use list_move_tail instead of list_del/list_add_tail in msm_gem.c
2021-06-09 7:28 [PATCH -next v2] drm/msm: Use list_move_tail instead of list_del/list_add_tail in msm_gem.c Baokun Li
@ 2021-08-05 8:23 ` Dmitry Baryshkov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Baryshkov @ 2021-08-05 8:23 UTC (permalink / raw)
To: Baokun Li, linux-kernel, Rob Clark, Sean Paul, David Airlie,
Daniel Vetter, Sumit Semwal, Christian König
Cc: weiyongjun1, yuehaibing, yangjihong1, yukuai3, linux-arm-msm,
dri-devel, freedreno, linux-media, linaro-mm-sig,
kernel-janitors, Hulk Robot
On 09/06/2021 10:28, Baokun Li wrote:
> Using list_move_tail() instead of list_del() + list_add_tail() in msm_gem.c.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Baokun Li <libaokun1@huawei.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> V1->V2:
> CC mailist
>
> drivers/gpu/drm/msm/msm_gem.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/msm_gem.c b/drivers/gpu/drm/msm/msm_gem.c
> index 1865919368f2..5b7d63d3750a 100644
> --- a/drivers/gpu/drm/msm/msm_gem.c
> +++ b/drivers/gpu/drm/msm/msm_gem.c
> @@ -854,8 +854,7 @@ void msm_gem_active_get(struct drm_gem_object *obj, struct msm_gpu *gpu)
> mutex_lock(&priv->mm_lock);
> if (msm_obj->evictable)
> mark_unevictable(msm_obj);
> - list_del(&msm_obj->mm_list);
> - list_add_tail(&msm_obj->mm_list, &gpu->active_list);
> + list_move_tail(&msm_obj->mm_list, &gpu->active_list);
> mutex_unlock(&priv->mm_lock);
> }
> }
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-05 8:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-09 7:28 [PATCH -next v2] drm/msm: Use list_move_tail instead of list_del/list_add_tail in msm_gem.c Baokun Li
2021-08-05 8:23 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).