linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] sound/arm: Remove unnecessary variables
@ 2021-06-10  2:40 zuoqilin1
  2021-06-10  7:51 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: zuoqilin1 @ 2021-06-10  2:40 UTC (permalink / raw)
  To: daniel, haojian.zhuang, robert.jarzmik, perex, tiwai
  Cc: linux-arm-kernel, alsa-devel, linux-kernel, zuoqilin

From: zuoqilin <zuoqilin@yulong.com>

There is no need to define the variable "ret" to receive.

Signed-off-by: zuoqilin <zuoqilin@yulong.com>
---
 sound/arm/pxa2xx-ac97.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/sound/arm/pxa2xx-ac97.c b/sound/arm/pxa2xx-ac97.c
index 6322e639..a67e668 100644
--- a/sound/arm/pxa2xx-ac97.c
+++ b/sound/arm/pxa2xx-ac97.c
@@ -47,9 +47,7 @@ static unsigned short pxa2xx_ac97_legacy_read(struct snd_ac97 *ac97,
 static void pxa2xx_ac97_legacy_write(struct snd_ac97 *ac97,
 				     unsigned short reg, unsigned short val)
 {
-	int __always_unused ret;
-
-	ret = pxa2xx_ac97_write(ac97->num, reg, val);
+	pxa2xx_ac97_write(ac97->num, reg, val);
 }
 
 static const struct snd_ac97_bus_ops pxa2xx_ac97_ops = {
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] sound/arm: Remove unnecessary variables
  2021-06-10  2:40 [PATCH] sound/arm: Remove unnecessary variables zuoqilin1
@ 2021-06-10  7:51 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2021-06-10  7:51 UTC (permalink / raw)
  To: zuoqilin1
  Cc: daniel, haojian.zhuang, robert.jarzmik, perex, tiwai,
	linux-arm-kernel, alsa-devel, linux-kernel, zuoqilin

On Thu, 10 Jun 2021 04:40:53 +0200,
zuoqilin1@163.com wrote:
> 
> From: zuoqilin <zuoqilin@yulong.com>
> 
> There is no need to define the variable "ret" to receive.
> 
> Signed-off-by: zuoqilin <zuoqilin@yulong.com>

Thanks, applied.


Takashi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-06-10  7:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-10  2:40 [PATCH] sound/arm: Remove unnecessary variables zuoqilin1
2021-06-10  7:51 ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).