* [PATCH] ipwireless: remove unused ipw_tty::closing
@ 2021-06-10 9:03 Jiri Slaby
2021-06-10 10:57 ` David Sterba
0 siblings, 1 reply; 2+ messages in thread
From: Jiri Slaby @ 2021-06-10 9:03 UTC (permalink / raw)
To: gregkh; +Cc: linux-serial, linux-kernel, Jiri Slaby, Jiri Kosina, David Sterba
It's only set, but never read.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: David Sterba <dsterba@suse.com>
---
drivers/tty/ipwireless/tty.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/tty/ipwireless/tty.c b/drivers/tty/ipwireless/tty.c
index e01ca68f24f4..e3a5a5ba752c 100644
--- a/drivers/tty/ipwireless/tty.c
+++ b/drivers/tty/ipwireless/tty.c
@@ -54,7 +54,6 @@ struct ipw_tty {
unsigned int control_lines;
struct mutex ipw_tty_mutex;
int tx_bytes_queued;
- int closing;
};
static struct ipw_tty *ttys[IPWIRELESS_PCMCIA_MINORS];
@@ -525,7 +524,6 @@ void ipwireless_tty_free(struct ipw_tty *tty)
printk(KERN_INFO IPWIRELESS_PCCARD_NAME
": deregistering %s device ttyIPWp%d\n",
tty_type_name(ttyj->tty_type), j);
- ttyj->closing = 1;
if (ttyj->port.tty != NULL) {
mutex_unlock(&ttyj->ipw_tty_mutex);
tty_vhangup(ttyj->port.tty);
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ipwireless: remove unused ipw_tty::closing
2021-06-10 9:03 [PATCH] ipwireless: remove unused ipw_tty::closing Jiri Slaby
@ 2021-06-10 10:57 ` David Sterba
0 siblings, 0 replies; 2+ messages in thread
From: David Sterba @ 2021-06-10 10:57 UTC (permalink / raw)
To: Jiri Slaby; +Cc: gregkh, linux-serial, linux-kernel, Jiri Kosina, David Sterba
On Thu, Jun 10, 2021 at 11:03:07AM +0200, Jiri Slaby wrote:
> It's only set, but never read.
Thanks. Please update the changelog with:
Commit 01261cb94318 ("tty: ipwireless: Remove tty->closing abort from
ipw_open()") removed last use of tty::closing.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-06-10 10:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-10 9:03 [PATCH] ipwireless: remove unused ipw_tty::closing Jiri Slaby
2021-06-10 10:57 ` David Sterba
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).