From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Dave Chinner <dchinner@redhat.com>,
Chandan Babu R <chandanrlinux@gmail.com>,
"Darrick J . Wong" <djwong@kernel.org>,
Allison Henderson <allison.henderson@oracle.com>,
Christoph Hellwig <hch@lst.de>
Cc: linux-xfs@vger.kernel.org, linux-next@vger.kernel.org,
linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert@linux-m68k.org>,
noreply@ellerman.id.au
Subject: [PATCH] xfs: Fix 64-bit division on 32-bit in xlog_state_switch_iclogs()
Date: Thu, 10 Jun 2021 13:00:01 +0200 [thread overview]
Message-ID: <20210610110001.2805317-1-geert@linux-m68k.org> (raw)
On 32-bit (e.g. m68k):
ERROR: modpost: "__udivdi3" [fs/xfs/xfs.ko] undefined!
Fix this by using a uint32_t intermediate, like before.
Reported-by: noreply@ellerman.id.au
Fixes: 7660a5b48fbef958 ("xfs: log stripe roundoff is a property of the log")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
Compile-tested only.
---
fs/xfs/xfs_log.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c
index 0e563ff8cd3be4aa..0c91da5defee6b9f 100644
--- a/fs/xfs/xfs_log.c
+++ b/fs/xfs/xfs_log.c
@@ -3143,8 +3143,8 @@ xlog_state_switch_iclogs(
/* Round up to next log-sunit */
if (log->l_iclog_roundoff > BBSIZE) {
- log->l_curr_block = roundup(log->l_curr_block,
- BTOBB(log->l_iclog_roundoff));
+ uint32_t sunit_bb = BTOBB(log->l_iclog_roundoff);
+ log->l_curr_block = roundup(log->l_curr_block, sunit_bb);
}
if (log->l_curr_block >= log->l_logBBsize) {
--
2.25.1
next reply other threads:[~2021-06-10 11:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-10 11:00 Geert Uytterhoeven [this message]
2021-06-10 22:01 ` [PATCH] xfs: Fix 64-bit division on 32-bit in xlog_state_switch_iclogs() Dave Chinner
2021-06-10 22:50 ` Darrick J. Wong
2021-06-11 6:55 ` Geert Uytterhoeven
2021-06-11 22:46 ` Dave Chinner
2021-06-12 8:54 ` Geert Uytterhoeven
2021-06-14 8:18 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210610110001.2805317-1-geert@linux-m68k.org \
--to=geert@linux-m68k.org \
--cc=allison.henderson@oracle.com \
--cc=chandanrlinux@gmail.com \
--cc=dchinner@redhat.com \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=noreply@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).